Apply simple sonar fixes

Note: A number of these were identified, by SonarLint, in the Test
classes, which are not typically scanned by Sonar.

Removed unnecessary imports.
Removed unneeded "throws Xxx".
Replaced lambda with method references.
Replaced duplicate strings with constants.
Replaced try-fail-catch with assert-j methods to eliminate sonar
complaints about duplicate failure messages.
Added missing @Override annotations.
Use map.computeIfAbsent() where appropriate.
Also fixed some minor checkstyle issues.
Removed unneeded "volatile" declarations.
Replaced some if-else constructs with "?:" construct, per sonar.
Replaced Object.wait() with CountDownLatch.await(); according to sonar
(and javadocs), Object.wait() can return due to "spurious wakeups".
Fixed issue whereby CryptoUtilsTest wouldn't run in my Eclipse.

Change-Id: Ib6b71ed65662cfd6209400dac57ed69279bf29ec
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>

1 files changed, 14 insertions, 13 deletions

diff --git a/common-parameters/src/test/java/org/onap/policy/common/parameters/ExceptionTest.java b/common-parameters/src/test/java/org/onap/policy/common/parameters/ExceptionTest.java
index b65db953..b874db69 100644
--- a/common-parameters/src/test/java/org/onap/policy/common/parameters/ExceptionTest.java
+++ b/common-parameters/src/test/java/org/onap/policy/common/parameters/ExceptionTest.java
@@ -1,19 +1,20 @@
 /*-
  * ============LICENSE_START=======================================================
  *  Copyright (C) 2018 Ericsson. All rights reserved.
+ *  Modifications Copyright (C) 2019 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
- * 
+ *
  * SPDX-License-Identifier: Apache-2.0
  * ============LICENSE_END=========================================================
  */
@@ -27,32 +28,32 @@ import java.io.IOException;
 import org.junit.Test;
 
 public class ExceptionTest {
+    private static final String PARAMETER_EXCEPTION = "Parameter Exception";
+    private static final String EXCEPTION_OBJECT = "Exception Object";
 
     @Test
     public void testParameterException() {
-        assertEquals("Parameter Exception", new ParameterException("Parameter Exception").getMessage());
+        assertEquals(PARAMETER_EXCEPTION, new ParameterException(PARAMETER_EXCEPTION).getMessage());
 
-        String exceptionObject = "Exception Object";
-        assertEquals("Exception Object",
-                        new ParameterException("Parameter Exception", exceptionObject).getObject().toString());
+        assertEquals(EXCEPTION_OBJECT,
+                        new ParameterException(PARAMETER_EXCEPTION, EXCEPTION_OBJECT).getObject().toString());
 
         Exception testException = new IOException("IO Exception");
         assertEquals("Parameter Exception\ncaused by: Parameter Exception\ncaused by: IO Exception",
-                        new ParameterException("Parameter Exception", testException, exceptionObject)
+                        new ParameterException(PARAMETER_EXCEPTION, testException, EXCEPTION_OBJECT)
                                         .getCascadedMessage());
     }
 
     @Test
     public void testParameterRuntimeException() {
-        assertEquals("Parameter Exception", new ParameterRuntimeException("Parameter Exception").getMessage());
+        assertEquals(PARAMETER_EXCEPTION, new ParameterRuntimeException(PARAMETER_EXCEPTION).getMessage());
 
-        String exceptionObject = "Exception Object";
-        assertEquals("Exception Object",
-                        new ParameterRuntimeException("Parameter Exception", exceptionObject).getObject().toString());
+        assertEquals(EXCEPTION_OBJECT,
+                        new ParameterRuntimeException(PARAMETER_EXCEPTION, EXCEPTION_OBJECT).getObject().toString());
 
         Exception testException = new IOException("IO Exception");
         assertEquals("Parameter Exception\ncaused by: Parameter Exception\ncaused by: IO Exception",
-                        new ParameterRuntimeException("Parameter Exception", testException, exceptionObject)
+                        new ParameterRuntimeException(PARAMETER_EXCEPTION, testException, EXCEPTION_OBJECT)
                                         .getCascadedMessage());
     }
 }