diff options
| author |   Jim Hahn <jrh3@att.com> | 2018-02-20 13:41:59 -0500 |
|---|---|---|
| committer | Jim Hahn <jrh3@att.com> | 2018-02-20 14:16:41 -0500 |
| commit | 7f6b1b0add6878e996e559c15337f46339c98901 (patch) | |
| tree | ed381d4fdaaed33a590c06145a9834331e32aa35 /common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/Logger4J.java | |
| parent | 19d3bfa5a1e6f69cde7a5e814b1975330249dcd0 (diff) | |
Increase junit coverage in ONAP-logging
Added some junit tests to increase coverage of ONAP-logger.
Many classes still need test cases.
Also fixed some sonar issues:
Returned interface instead of ConcurrentHashMap.
Used EnumMap instead of HashMap.
Used StringBuilder instead of StringBuffer.
Replaced literals with constants.
Replaced enum1.toString().equals(enum2.toString()) with enum1 == enum2
Updated license dates.
Updated another license date.
Change-Id: I777b6a913d7d03187a29dfeb817800b386ee23aa
Issue-ID: POLICY-582
Signed-off-by: Jim Hahn <jrh3@att.com>
Diffstat (limited to 'common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/Logger4J.java')
| -rw-r--r-- | common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/Logger4J.java | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/Logger4J.java b/common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/Logger4J.java index 746012d1..30349d5c 100644 --- a/common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/Logger4J.java +++ b/common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/Logger4J.java @@ -1,8 +1,8 @@ -/*- +/* * ============LICENSE_START======================================================= * ONAP-Logging * ================================================================================ - * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved. + * Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -183,7 +183,7 @@ public class Logger4J implements org.onap.policy.common.logging.flexlogger.Logge */ @Override public boolean isAuditEnabled(){ - return !(PolicyLogger.getAuditLevel() != null && PolicyLogger.getAuditLevel().toString().equals(Level.OFF.toString())); + return(PolicyLogger.getAuditLevel() != Level.OFF); } /** @@ -191,8 +191,8 @@ public class Logger4J implements org.onap.policy.common.logging.flexlogger.Logge * @return boolean */ @Override - public boolean isMetricsEnabled(){ - return !(PolicyLogger.getMetricsLevel() != null && PolicyLogger.getMetricsLevel().toString().equals(Level.OFF.toString())); + public boolean isMetricsEnabled(){ + return(PolicyLogger.getMetricsLevel() != Level.OFF); } /** |