diff options
| author |   Jim Hahn <jrh3@att.com> | 2019-07-05 13:03:06 -0400 |
|---|---|---|
| committer | Jim Hahn <jrh3@att.com> | 2019-07-05 17:36:12 -0400 |
| commit | 02ba37e23bebc5fc8831feaa4ce073295c3c93d8 (patch) | |
| tree | 4b4b99ec0d2d429fe2d857e3992d5e893615f6b1 /common-logging/pom.xml | |
| parent | 53f9550501ca1854318c1f552b0aba2e255b6748 (diff) | |
Fix sonar issues in policy ONAP logging
Sonar fixes, other than code coverage. These changes are disruptive
and will likely cause breakage in a number of policy repos.
Renamed constants.
Moved constants/factories from interfaces to classes.
Also fixed remaining checkstyle issues, which was equally disruptive,
as it required renaming of methods and classes.
Split out Onap config properties from EELF config properties, in
case changes are made in the future such that Onap properties can
no longer subclass from EELF properties (e.g., if EELF properties are
converted from a interface to a utility class with a private constructor).
Attempted to eliminate some duplicate blocks of code by refactoring
out common methods.
Change-Id: Ie038d2d4ed553037a9af3f0ddf31baf2b3628fa3
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>
Diffstat (limited to 'common-logging/pom.xml')
| -rw-r--r-- | common-logging/pom.xml | 18 |
1 files changed, 13 insertions, 5 deletions
diff --git a/common-logging/pom.xml b/common-logging/pom.xml index 8e34d66f..851dabb8 100644 --- a/common-logging/pom.xml +++ b/common-logging/pom.xml @@ -2,14 +2,14 @@ ============LICENSE_START======================================================= ONAP Policy Engine - Common Modules ================================================================================ - Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved. + Copyright (C) 2017-2019 AT&T Intellectual Property. All rights reserved. ================================================================================ Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at - + http://www.apache.org/licenses/LICENSE-2.0 - + Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. @@ -33,6 +33,11 @@ <dependencies> <dependency> + <groupId>org.projectlombok</groupId> + <artifactId>lombok</artifactId> + <scope>provided</scope> + </dependency> + <dependency> <groupId>log4j</groupId> <artifactId>log4j</artifactId> <scope>provided</scope> @@ -51,6 +56,10 @@ <artifactId>eelf-core</artifactId> <version>1.0.1-oss</version> </dependency> + <dependency> + <groupId>org.apache.commons</groupId> + <artifactId>commons-lang3</artifactId> + </dependency> <dependency> <groupId>org.powermock</groupId> <artifactId>powermock-api-mockito</artifactId> @@ -81,7 +90,6 @@ <includeTestResources>true</includeTestResources> <excludes> </excludes> - <suppressionsLocation>${project.basedir}/checkstyle-suppressions.xml</suppressionsLocation> <consoleOutput>true</consoleOutput> <failsOnViolation>true</failsOnViolation> <violationSeverity>warning</violationSeverity> @@ -110,7 +118,7 @@ </execution> </executions> <dependencies> - <!-- We need to include the dependency of the project so that its include + <!-- We need to include the dependency of the project so that its include in classpath when running plugin --> <dependency> <groupId>org.onap.policy.common</groupId> |