Fix validation in ACM-runtime

Fix validation after migration fail
and undeploy fail in ACM-runtime.
Add more information in fail validation.

Issue-ID: POLICY-5195
Change-Id: I870fd31b59bb65db8cb6e8e1b9ee502fc3d63743
Signed-off-by: FrancescoFioraEst <francesco.fiora@est.tech>

1 files changed, 6 insertions, 1 deletions

diff --git a/runtime-acm/src/main/java/org/onap/policy/clamp/acm/runtime/instantiation/AutomationCompositionInstantiationProvider.java b/runtime-acm/src/main/java/org/onap/policy/clamp/acm/runtime/instantiation/AutomationCompositionInstantiationProvider.java
index 42af70596..0979a811b 100644
--- a/runtime-acm/src/main/java/org/onap/policy/clamp/acm/runtime/instantiation/AutomationCompositionInstantiationProvider.java
+++ b/runtime-acm/src/main/java/org/onap/policy/clamp/acm/runtime/instantiation/AutomationCompositionInstantiationProvider.java
@@ -68,6 +68,8 @@ import org.springframework.transaction.annotation.Transactional;
 public class AutomationCompositionInstantiationProvider {
     private static final String DO_NOT_MATCH = " do not match with ";
     private static final String ELEMENT_ID_NOT_PRESENT = "Element id not present ";
+    private static final String NOT_VALID_ORDER =
+            "Not valid order %s; DeployState: %s; LockState: %s; SubState: %s; StateChangeResult: %s";
 
     private static final Logger LOGGER = LoggerFactory.getLogger(AutomationCompositionInstantiationProvider.class);
 
@@ -472,7 +474,10 @@ public class AutomationCompositionInstantiationProvider {
                 break;
 
             default:
-                throw new PfModelRuntimeException(Status.BAD_REQUEST, "Not valid " + acInstanceStateUpdate);
+                var msg = String.format(NOT_VALID_ORDER, acInstanceStateUpdate,
+                        automationComposition.getDeployState(), automationComposition.getLockState(),
+                        automationComposition.getSubState(), automationComposition.getStateChangeResult());
+                throw new PfModelRuntimeException(Status.BAD_REQUEST, msg);
         }
     }
 }