diff options
Diffstat (limited to 'model')
6 files changed, 38 insertions, 19 deletions
diff --git a/model/pom.xml b/model/pom.xml index e6312da71..bdbb7f7d6 100644 --- a/model/pom.xml +++ b/model/pom.xml @@ -24,7 +24,7 @@ <parent> <groupId>org.onap.policy.apex-pdp</groupId> <artifactId>apex-pdp</artifactId> - <version>4.0.0-SNAPSHOT</version> + <version>4.0.1-SNAPSHOT</version> </parent> <groupId>org.onap.policy.apex-pdp.model</groupId> diff --git a/model/src/main/java/org/onap/policy/apex/model/policymodel/handling/PolicyLogicReader.java b/model/src/main/java/org/onap/policy/apex/model/policymodel/handling/PolicyLogicReader.java index 8b0dec7b7..4a8780a4f 100644 --- a/model/src/main/java/org/onap/policy/apex/model/policymodel/handling/PolicyLogicReader.java +++ b/model/src/main/java/org/onap/policy/apex/model/policymodel/handling/PolicyLogicReader.java @@ -23,7 +23,6 @@ package org.onap.policy.apex.model.policymodel.handling; import static org.onap.policy.apex.model.basicmodel.concepts.AxConcept.WHITESPACE_REGEX; -import org.jetbrains.annotations.NotNull; import org.onap.policy.apex.model.basicmodel.concepts.AxKey; import org.onap.policy.apex.model.policymodel.concepts.AxLogic; import org.onap.policy.apex.model.policymodel.concepts.AxLogicReader; @@ -124,7 +123,7 @@ public class PolicyLogicReader implements AxLogicReader { return logicString.replaceAll(WHITESPACE_REGEX, ""); } - private @NotNull String getFullLogicFilePath(AxLogic axLogic) { + private String getFullLogicFilePath(AxLogic axLogic) { String fullLogicFilePath = logicPackage.replace(".", "/"); // Now, the logic should be in a subdirectory for the logic executor type diff --git a/model/src/test/java/org/onap/policy/apex/model/basicmodel/handling/SupportApexBasicModelTest.java b/model/src/test/java/org/onap/policy/apex/model/basicmodel/handling/SupportApexBasicModelTest.java index 8c1f756c1..b5028273c 100644 --- a/model/src/test/java/org/onap/policy/apex/model/basicmodel/handling/SupportApexBasicModelTest.java +++ b/model/src/test/java/org/onap/policy/apex/model/basicmodel/handling/SupportApexBasicModelTest.java @@ -54,7 +54,7 @@ class SupportApexBasicModelTest { @Test void testModelValid() throws Exception { final AxValidationResult result = testApexModel.testApexModelValid(); - var expectedResult = ResourceUtils.getResourceAsString(VALID_MODEL_STRING); + var expectedResult = normalizeNewlines(ResourceUtils.getResourceAsString(VALID_MODEL_STRING)); assertEquals(expectedResult, result.toString()); } @@ -67,21 +67,21 @@ class SupportApexBasicModelTest { @Test void testApexModelValidateWarning() throws Exception { final AxValidationResult result = testApexModel.testApexModelValidateWarning(); - var expectedResult = ResourceUtils.getResourceAsString(WARNING_MODEL_STRING); + var expectedResult = normalizeNewlines(ResourceUtils.getResourceAsString(WARNING_MODEL_STRING)); assertEquals(expectedResult, result.toString()); } @Test void testModelValidateInvalidModel() throws Exception { final AxValidationResult result = testApexModel.testApexModelValidateInvalidModel(); - var expectedResult = ResourceUtils.getResourceAsString(INVALID_MODEL_STRING); + var expectedResult = normalizeNewlines(ResourceUtils.getResourceAsString(INVALID_MODEL_STRING)); assertEquals(expectedResult, result.toString()); } @Test void testModelValidateMalstructured() throws Exception { final AxValidationResult result = testApexModel.testApexModelValidateMalstructured(); - var expectedResult = ResourceUtils.getResourceAsString(INVALID_MODEL_MALSTRUCTURED_STRING); + var expectedResult = normalizeNewlines(ResourceUtils.getResourceAsString(INVALID_MODEL_MALSTRUCTURED_STRING)); assertEquals(expectedResult, result.toString()); } @@ -89,4 +89,8 @@ class SupportApexBasicModelTest { void testModelWriteReadJson() throws Exception { testApexModel.testApexModelWriteReadJson(); } + + private String normalizeNewlines(String input) { + return input.replace("\r\n", "\n"); + } } diff --git a/model/src/test/java/org/onap/policy/apex/model/contextmodel/handling/ApexContextModelTest.java b/model/src/test/java/org/onap/policy/apex/model/contextmodel/handling/ApexContextModelTest.java index a9cb16914..31083d4c4 100644 --- a/model/src/test/java/org/onap/policy/apex/model/contextmodel/handling/ApexContextModelTest.java +++ b/model/src/test/java/org/onap/policy/apex/model/contextmodel/handling/ApexContextModelTest.java @@ -68,28 +68,28 @@ class ApexContextModelTest { @Test void testApexModelValidateObservation() throws Exception { final AxValidationResult result = testApexModel.testApexModelValidateObservation(); - var expectedResult = ResourceUtils.getResourceAsString(OBSERVATION_MODEL_STRING); + var expectedResult = normalizeNewlines(ResourceUtils.getResourceAsString(OBSERVATION_MODEL_STRING)); assertEquals(expectedResult, result.toString()); } @Test void testApexModelValidateWarning() throws Exception { final AxValidationResult result = testApexModel.testApexModelValidateWarning(); - var expectedResult = ResourceUtils.getResourceAsString(WARNING_MODEL_STRING); + var expectedResult = normalizeNewlines(ResourceUtils.getResourceAsString(WARNING_MODEL_STRING)); assertEquals(expectedResult, result.toString()); } @Test void testModelValidateInvalidModel() throws Exception { final AxValidationResult result = testApexModel.testApexModelValidateInvalidModel(); - var expectedResult = ResourceUtils.getResourceAsString(INVALID_MODEL_STRING); + var expectedResult = normalizeNewlines(ResourceUtils.getResourceAsString(INVALID_MODEL_STRING)); assertEquals(expectedResult, result.toString()); } @Test void testModelValidateMalstructured() throws Exception { final AxValidationResult result = testApexModel.testApexModelValidateMalstructured(); - var expectedResult = ResourceUtils.getResourceAsString(INVALID_MODEL_MALSTRUCTURED_STRING); + var expectedResult = normalizeNewlines(ResourceUtils.getResourceAsString(INVALID_MODEL_MALSTRUCTURED_STRING)); assertEquals(expectedResult, result.toString()); } @@ -97,4 +97,8 @@ class ApexContextModelTest { void testModelWriteReadJson() throws Exception { testApexModel.testApexModelWriteReadJson(); } + + private String normalizeNewlines(String input) { + return input.replace("\r\n", "\n"); + } } diff --git a/model/src/test/java/org/onap/policy/apex/model/eventmodel/handling/ApexEventModelTest.java b/model/src/test/java/org/onap/policy/apex/model/eventmodel/handling/ApexEventModelTest.java index df1857c82..bb50fb35e 100644 --- a/model/src/test/java/org/onap/policy/apex/model/eventmodel/handling/ApexEventModelTest.java +++ b/model/src/test/java/org/onap/policy/apex/model/eventmodel/handling/ApexEventModelTest.java @@ -64,28 +64,28 @@ class ApexEventModelTest { @Test void testApexModelValidateObservation() throws Exception { final AxValidationResult result = testApexModel.testApexModelValidateObservation(); - String expected = ResourceUtils.getResourceAsString(OBSERVATION_MODEL_STRING); + var expected = normalizeNewlines(ResourceUtils.getResourceAsString(OBSERVATION_MODEL_STRING)); assertEquals(expected, result.toString()); } @Test void testApexModelValidateWarning() throws Exception { final AxValidationResult result = testApexModel.testApexModelValidateWarning(); - String expected = ResourceUtils.getResourceAsString(WARNING_MODEL_STRING); + var expected = normalizeNewlines(ResourceUtils.getResourceAsString(WARNING_MODEL_STRING)); assertEquals(expected, result.toString()); } @Test void testModelValidateInvalidModel() throws Exception { final AxValidationResult result = testApexModel.testApexModelValidateInvalidModel(); - String expected = ResourceUtils.getResourceAsString(INVALID_MODEL_STRING); + var expected = normalizeNewlines(ResourceUtils.getResourceAsString(INVALID_MODEL_STRING)); assertEquals(expected, result.toString()); } @Test void testModelValidateMalstructured() throws Exception { final AxValidationResult result = testApexModel.testApexModelValidateMalstructured(); - String expected = ResourceUtils.getResourceAsString(INVALID_MODEL_MALSTRUCTURED_STRING); + var expected = normalizeNewlines(ResourceUtils.getResourceAsString(INVALID_MODEL_MALSTRUCTURED_STRING)); assertEquals(expected, result.toString()); } @@ -93,4 +93,8 @@ class ApexEventModelTest { void testModelWriteReadJson() throws Exception { testApexModel.testApexModelWriteReadJson(); } + + private String normalizeNewlines(String input) { + return input.replace("\r\n", "\n"); + } } diff --git a/model/src/test/java/org/onap/policy/apex/model/policymodel/handling/ApexPolicyModelTest.java b/model/src/test/java/org/onap/policy/apex/model/policymodel/handling/ApexPolicyModelTest.java index 01f7062e1..c943befd5 100644 --- a/model/src/test/java/org/onap/policy/apex/model/policymodel/handling/ApexPolicyModelTest.java +++ b/model/src/test/java/org/onap/policy/apex/model/policymodel/handling/ApexPolicyModelTest.java @@ -61,29 +61,37 @@ class ApexPolicyModelTest { @Test void testApexModelValidateObservation() throws Exception { final AxValidationResult result = testApexModel.testApexModelValidateObservation(); - assertEquals(ResourceUtils.getResourceAsString(OBSERVATION_MODEL_STRING), result.toString()); + var expectedOutput = normalizeNewlines(ResourceUtils.getResourceAsString(OBSERVATION_MODEL_STRING)); + assertEquals(expectedOutput, result.toString()); } @Test void testApexModelValidateWarning() throws Exception { final AxValidationResult result = testApexModel.testApexModelValidateWarning(); - assertEquals(ResourceUtils.getResourceAsString(WARNING_MODEL_STRING), result.toString()); + var expectedOutput = normalizeNewlines(ResourceUtils.getResourceAsString(WARNING_MODEL_STRING)); + assertEquals(expectedOutput, result.toString()); } @Test void testModelValidateInvalidModel() throws Exception { final AxValidationResult result = testApexModel.testApexModelValidateInvalidModel(); - assertEquals(ResourceUtils.getResourceAsString(INVALID_MODEL_STRING), result.toString()); + var expectedOutput = normalizeNewlines(ResourceUtils.getResourceAsString(INVALID_MODEL_STRING)); + assertEquals(expectedOutput, result.toString()); } @Test void testModelValidateMalstructured() throws Exception { final AxValidationResult result = testApexModel.testApexModelValidateMalstructured(); - assertEquals(ResourceUtils.getResourceAsString(INVALID_MODEL_MALSTRUCTURED_STRING), result.toString()); + var expectedOutput = normalizeNewlines(ResourceUtils.getResourceAsString(INVALID_MODEL_MALSTRUCTURED_STRING)); + assertEquals(expectedOutput, result.toString()); } @Test void testModelWriteReadJson() throws Exception { testApexModel.testApexModelWriteReadJson(); } + + private String normalizeNewlines(String input) { + return input.replace("\r\n", "\n"); + } } |