Convert junit4 to junit5

- clean up any references to junit4
- clean up some sonar complaints
- remove not used integration tests

Issue-ID: POLICY-5041
Change-Id: I67e7a8f00df5b6c5ba514f4ea2ecd96bf942d4c7
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>

2 files changed, 6 insertions, 7 deletions

diff --git a/core/src/main/java/org/onap/policy/apex/core/engine/engine/impl/ApexEngineImpl.java b/core/src/main/java/org/onap/policy/apex/core/engine/engine/impl/ApexEngineImpl.java
index 773923444..862c357be 100644
--- a/core/src/main/java/org/onap/policy/apex/core/engine/engine/impl/ApexEngineImpl.java
+++ b/core/src/main/java/org/onap/policy/apex/core/engine/engine/impl/ApexEngineImpl.java
@@ -385,7 +385,7 @@ public class ApexEngineImpl implements ApexEngine {
         }
         updateStatePrometheusMetric();
 
-        String message = "execute(): triggered by event " + incomingEvent.toString();
+        String message = "execute(): triggered by event " + incomingEvent;
         LOGGER.debug(message);
 
         // By default, we return a null event on errors
diff --git a/core/src/main/java/org/onap/policy/apex/core/infrastructure/threading/ApplicationThreadFactory.java b/core/src/main/java/org/onap/policy/apex/core/infrastructure/threading/ApplicationThreadFactory.java
index cea505854..a9c3f68c5 100644
--- a/core/src/main/java/org/onap/policy/apex/core/infrastructure/threading/ApplicationThreadFactory.java
+++ b/core/src/main/java/org/onap/policy/apex/core/infrastructure/threading/ApplicationThreadFactory.java
@@ -3,7 +3,7 @@
  *  Copyright (C) 2016-2018 Ericsson. All rights reserved.
  *  Modifications Copyright (C) 2021 AT&T Intellectual Property. All rights reserved.
  *  Modifications Copyright (C) 2021 Bell Canada. All rights reserved.
- *  Modifications Copyright (C) 2023 Nordix Foundation.
+ *  Modifications Copyright (C) 2023-2024 Nordix Foundation.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -68,16 +68,15 @@ public class ApplicationThreadFactory implements ThreadFactory {
     /**
      * Instantiates a new application thread factory with a specified thread priority.
      *
-     * @param nameLocal the name local
-     * @param stackSize the stack size
+     * @param nameLocal      the name local
+     * @param stackSize      the stack size
      * @param threadPriority the thread priority
      */
     @SuppressWarnings({
         "deprecation", "removal"
     })
     public ApplicationThreadFactory(final String nameLocal, final long stackSize, final int threadPriority) {
-        @SuppressWarnings("removal")
-        final var s = System.getSecurityManager();
+        @SuppressWarnings("removal") final var s = System.getSecurityManager();
         group = (s != null) ? s.getThreadGroup() : Thread.currentThread().getThreadGroup();
         name = APPLICATION_NAME + nameLocal + HYPHEN + NEXT_POOL_NUMBER.getAndIncrement();
         this.stackSize = stackSize;
@@ -118,6 +117,6 @@ public class ApplicationThreadFactory implements ThreadFactory {
     @Override
     public String toString() {
         return "ApplicationThreadFactory [nextPoolNumber=" + NEXT_POOL_NUMBER + ",nextThreadNumber=" + nextThreadNumber
-                + ", name=" + name + ", stackSize=" + stackSize + ", threadPriority=" + threadPriority + "]";
+            + ", name=" + name + ", stackSize=" + stackSize + ", threadPriority=" + threadPriority + "]";
     }
 }