aboutsummaryrefslogtreecommitdiffstats
path: root/checkstyle/src/main/resources
AgeCommit message (Collapse)AuthorFilesLines
2022-03-30Enable @surpressWarnings for CheckstylejakartaToineSiebelink1-0/+2
Documentation is a bit ambigous but below changes should enable @SupressWarnings (in source code) for checkstyle rules we have some false positives from Checkstyle we want to supress this way e.g. https://tinyurl.com/4b527vvr lines 258/259; checkstyle forced us to add those lines, instead I want to supress the warning on this method using annotation like @supresswraning(checkstyle:missingSwitchDefault)) Issue-ID: CPS-475 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I07f865a279b4951f2ce3240fedcec6b5c46933e0
2021-06-17Update Checkstyle to version 8.43liamfallon1-2/+0
The checkstyle plugin in the 2021-03 version of Eclipse defaults to version 8.43 of Checkstyle. This version of Checkstyle removes the "scope" keyword from the JavadocMethod module, because it is redundant, so the ONAP checkstyle onap-kava-style.xml file breaks. This review: - Removes the "scope" property from the "JavadocMethod" module, where it is redundant anyhow (scope applies on the "MissingJavadocMethod" module - Removes the "scope" property from the "MissingJavadocMethod" because it defaults to the correct value for ONAP, that is "public" Issue-ID: POLICY-3206 Change-Id: I62736ec812595929392b5eef0658acb77365c52a Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-06-19Upgrade checkstyle to version 8.32 Google styleliamfallon1-130/+242
This review upgrades the checckstyle in ONAP to version 8.32, and re-aligns the ONAP style definition with the 8.32 version of the Google style guide. This change was triggered by incompatible changes in checkstyle version 8.32. Checkstyle has removed the directives "allowMissingThrowsTag" and "allowThrowsTagsForSubclasses". These directives controlled whether the existence of @Throws tags should be checked or not. In ONAP, these directives were set to "don't check". The default behaviour in checkstyle now is not to check @Throws javadoc tags for existence. See: https://github.com/checkstyle/checkstyle/issues/7329 Issue-ID: INT-1271 Change-Id: Iaabbf05b6aaf244388f654aa4e965da3d3a4f4e9 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-12-09Update checkstyle rules to exclude methodsliamfallon1-0/+3
Checkstyle rules updated to: 1) allow getters and setters not to have javadoc 2) allow methods with less than 2 lines to not have javadoc 3) allow protected and private methods not to have javadoc 4) allow methods with names beginning with test|before|after not to have javaodc Issue-ID: INT-1395 Change-Id: I570cd90034c7b20d45a7e5a6ecacacdef80876a1 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-12-06Upgrade oparent to checkstyle 8.27liamfallon1-5/+9
Checkstyle 8.27 introduces incompatible changes in the checkstyle rule definition xml file. The latest Eclipse checkstyle plugin (version 8.26) uses this new checkstyle xml rule format. This change brings in the checkstyle 8.27 rule formats into oparent. Issue-ID: INT-1395 Change-Id: I453120e5cc95fa2e30a5d2f24083fd030e960a01 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-11-18Revert "update version of checkstyle for latest google style and jdk 8"Brian Freeman1-268/+0
This reverts commit 6a2d8c71aa39a6f47a683c38267c07cd9a00dfeb. Revert until we fix the jjb verify and master Issue-ID: INT-1271 Change-Id: I11da29bee4f17c40ae96ab647d1517572a20b864 Signed-off-by: Brian Freeman <bf1936@att.com>
2019-11-18update version of checkstyle for latest google style and jdk 8John J. Franey1-0/+268
Upgrade to use the latest google style (plus onap style). This latest style adds rules for jdk 8 source level. Upgrade the version of checkstyle to 8.24. The latest google style rules are compatible with 8.24 and later. Upgrade checkstyle maven plugin to 3.1.0 (from 2.17). This jdk8 version of checkstyle is active only when the build-time java runtime is jdk8 or later, otherwise, the original checkstyle is active. Issue-ID: INT-1271 Change-Id: Ib190b39efc5a6028ab4874301e6a813f0a36b138 Signed-off-by: John J. Franey <john.franey@att.com>
2019-02-07Fix checkstyle build and xmlPamela Dragosh1-1/+0
The XML for onap-java-code style has a bug identified by Eclipse. The maxLineLength field is not allowed. In addition, not sure how any jobs work already, the sourceDirectory appends and extra "src/main/java" to the path so some builds don't always find the correct source files to generate warnings. The plugin is a bit flaky and sometimes seems to find the java files, while other times it does not. So some checkstyle warnings are not generated. Change-Id: Ia07065a0d0df1429643680cb5bd70b5ec13bebde Issue-ID: TSC-71 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-15Add missing license headerGary Wu1-0/+15
Change-Id: Ie7ce5da5f0baa6a77dd3bfefd523f28682fe27ba Issue-ID: INT-103 Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
2017-09-05Relax O-Parent license check requirementsv0.1.11.0.0-ONAP1.0.0-AmsterdamGary Wu1-14/+14
Relax O-Parent license check formatting requirements. At the same time, violations will now become errors and will fail builds. Change-Id: Ie581895796cc06a9f008d7b739583fb44673aa19 Issue-ID: INT-135 Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
2017-08-21Refactor oparent for independent versioningGary Wu3-0/+0
Change-Id: I543f394b360b6926986f33b48bef4b3355363beb Issue-id: INT-103 Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
2017-06-21Make license check warning only for nowGary Wu1-1/+1
Make license check warning only for now. Set default java version to 8. Change-Id: Idbbc617c739a45bbecbfdd3f8bc394e648b852a8 Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
2017-06-21Initial commit using OPEN-O seed codeGary Wu3-0/+254
Change-Id: I74f6c92bcc2327ad41bc997c04091e2c01fdf1da Signed-off-by: Gary Wu <gary.i.wu@huawei.com>