aboutsummaryrefslogtreecommitdiffstats
path: root/certServiceClient
diff options
context:
space:
mode:
authorawudzins <adam.wudzinski@nokia.com>2020-03-13 16:54:18 +0100
committerawudzins <adam.wudzinski@nokia.com>2020-04-03 11:29:59 +0200
commitb81c681cb6be761a2abb5e2f5af1b923bef1f6b4 (patch)
tree9e0712775bee897d3c0156a8fa6bf9d69846f2ed /certServiceClient
parentfa33d3f9cf9b613968bf277284841164d392fc21 (diff)
Switch client and server to communicate over TLS
Issue-ID: AAF-1084 Signed-off-by: Adam WudziƄski <adam.wudzinski@nokia.com> Change-Id: I7f11b27c7dcdf4fc3eba2d5e64b6dc775c80dd74
Diffstat (limited to 'certServiceClient')
-rw-r--r--certServiceClient/README.md4
-rw-r--r--certServiceClient/src/main/java/org/onap/aaf/certservice/client/CertServiceClient.java17
-rw-r--r--certServiceClient/src/main/java/org/onap/aaf/certservice/client/api/ExitStatus.java3
-rw-r--r--certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/EnvsForTls.java47
-rw-r--r--certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/TlsConfigurationEnvs.java28
-rw-r--r--certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/exception/TlsConfigurationException.java36
-rw-r--r--certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/factory/CsrConfigurationFactory.java2
-rw-r--r--certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/factory/SslContextFactory.java85
-rw-r--r--certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/model/ClientConfiguration.java2
-rw-r--r--certServiceClient/src/main/java/org/onap/aaf/certservice/client/httpclient/CloseableHttpsClientProvider.java (renamed from certServiceClient/src/main/java/org/onap/aaf/certservice/client/httpclient/CloseableHttpClientProvider.java)13
-rw-r--r--certServiceClient/src/main/java/org/onap/aaf/certservice/client/httpclient/HttpClient.java4
-rw-r--r--certServiceClient/src/test/java/org/onap/aaf/certservice/client/configuration/factory/SslContextFactoryTest.java197
-rw-r--r--certServiceClient/src/test/java/org/onap/aaf/certservice/client/configuration/model/ClientConfigurationFactoryTest.java4
-rw-r--r--certServiceClient/src/test/java/org/onap/aaf/certservice/client/httpclient/HttpClientTest.java2
-rw-r--r--certServiceClient/src/test/resources/keystore.jksbin0 -> 5581 bytes
-rw-r--r--certServiceClient/src/test/resources/truststore.jksbin0 -> 1722 bytes
16 files changed, 427 insertions, 17 deletions
diff --git a/certServiceClient/README.md b/certServiceClient/README.md
index 7748b29b..43d732c8 100644
--- a/certServiceClient/README.md
+++ b/certServiceClient/README.md
@@ -43,6 +43,10 @@ LOCATION=San-Francisco
STATE=California
COUNTRY=US
SANS=example.com:example2.com
+KEYSTORE_PATH=/etc/onap/aaf/certservice/certs/certServiceClient-keystore.jks
+KEYSTORE_PASSWORD=secret
+TRUSTSTORE_PATH=/etc/onap/aaf/certservice/certs/truststore.jks
+TRUSTSTORE_PASSWORD=secret
```
### Logs locally
diff --git a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/CertServiceClient.java b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/CertServiceClient.java
index 0916bb8a..1b5b8ee3 100644
--- a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/CertServiceClient.java
+++ b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/CertServiceClient.java
@@ -19,26 +19,30 @@
package org.onap.aaf.certservice.client;
-import java.security.KeyPair;
import org.onap.aaf.certservice.client.api.ExitableException;
-import org.onap.aaf.certservice.client.certification.PrivateKeyToPemEncoder;
import org.onap.aaf.certservice.client.certification.CsrFactory;
import org.onap.aaf.certservice.client.certification.KeyPairFactory;
+import org.onap.aaf.certservice.client.certification.PrivateKeyToPemEncoder;
import org.onap.aaf.certservice.client.certification.conversion.KeystoreTruststoreCreator;
import org.onap.aaf.certservice.client.certification.conversion.KeystoreTruststoreCreatorFactory;
import org.onap.aaf.certservice.client.common.Base64Encoder;
import org.onap.aaf.certservice.client.configuration.EnvsForClient;
import org.onap.aaf.certservice.client.configuration.EnvsForCsr;
+import org.onap.aaf.certservice.client.configuration.EnvsForTls;
import org.onap.aaf.certservice.client.configuration.factory.ClientConfigurationFactory;
import org.onap.aaf.certservice.client.configuration.factory.CsrConfigurationFactory;
+import org.onap.aaf.certservice.client.configuration.factory.SslContextFactory;
import org.onap.aaf.certservice.client.configuration.model.ClientConfiguration;
import org.onap.aaf.certservice.client.configuration.model.CsrConfiguration;
-import org.onap.aaf.certservice.client.httpclient.CloseableHttpClientProvider;
+import org.onap.aaf.certservice.client.httpclient.CloseableHttpsClientProvider;
import org.onap.aaf.certservice.client.httpclient.HttpClient;
import org.onap.aaf.certservice.client.httpclient.model.CertServiceResponse;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import javax.net.ssl.SSLContext;
+import java.security.KeyPair;
+
import static org.onap.aaf.certservice.client.api.ExitStatus.SUCCESS;
import static org.onap.aaf.certservice.client.certification.EncryptionAlgorithmConstants.KEY_SIZE;
import static org.onap.aaf.certservice.client.certification.EncryptionAlgorithmConstants.RSA_ENCRYPTION_ALGORITHM;
@@ -62,9 +66,10 @@ public class CertServiceClient {
CsrConfiguration csrConfiguration = new CsrConfigurationFactory(new EnvsForCsr()).create();
KeyPair keyPair = keyPairFactory.create();
CsrFactory csrFactory = new CsrFactory(csrConfiguration);
+ SSLContext sslContext = new SslContextFactory(new EnvsForTls()).create();
- CloseableHttpClientProvider provider = new CloseableHttpClientProvider(
- clientConfiguration.getRequestTimeout());
+ CloseableHttpsClientProvider provider = new CloseableHttpsClientProvider(
+ sslContext, clientConfiguration.getRequestTimeout());
HttpClient httpClient = new HttpClient(provider, clientConfiguration.getUrlToCertService());
CertServiceResponse certServiceData =
@@ -74,7 +79,7 @@ public class CertServiceClient {
base64Encoder.encode(pkEncoder.encodePrivateKeyToPem(keyPair.getPrivate())));
KeystoreTruststoreCreator filesCreator = new KeystoreTruststoreCreatorFactory(
- clientConfiguration.getCertsOutputPath()).create();
+ clientConfiguration.getCertsOutputPath()).create();
filesCreator.createKeystore(certServiceData.getCertificateChain(), keyPair.getPrivate());
filesCreator.createTruststore(certServiceData.getTrustedCertificates());
} catch (ExitableException e) {
diff --git a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/api/ExitStatus.java b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/api/ExitStatus.java
index c474fd03..78ecc778 100644
--- a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/api/ExitStatus.java
+++ b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/api/ExitStatus.java
@@ -28,7 +28,8 @@ public enum ExitStatus {
CERT_SERVICE_API_CONNECTION_EXCEPTION(5,"CertService HTTP unsuccessful response"),
HTTP_CLIENT_EXCEPTION(6,"Internal HTTP Client connection problem"),
PKCS12_CONVERSION_EXCEPTION(7,"Fail in PKCS12 conversion"),
- PK_TO_PEM_ENCODING_EXCEPTION(8,"Fail in Private Key to PEM Encoding");
+ PK_TO_PEM_ENCODING_EXCEPTION(8,"Fail in Private Key to PEM Encoding"),
+ TLS_CONFIGURATION_EXCEPTION(9, "Invalid TLS configuration");
private final int value;
private final String message;
diff --git a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/EnvsForTls.java b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/EnvsForTls.java
new file mode 100644
index 00000000..b2f782c2
--- /dev/null
+++ b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/EnvsForTls.java
@@ -0,0 +1,47 @@
+/*
+ * ============LICENSE_START=======================================================
+ * aaf-certservice-client
+ * ================================================================================
+ * Copyright (C) 2020 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.aaf.certservice.client.configuration;
+
+import java.util.Optional;
+
+public class EnvsForTls {
+ private final EnvProvider envProvider = new EnvProvider();
+
+ public Optional<String> getKeystorePath() {
+ return readEnv(TlsConfigurationEnvs.KEYSTORE_PATH);
+ }
+
+ public Optional<String> getKeystorePassword() {
+ return readEnv(TlsConfigurationEnvs.KEYSTORE_PASSWORD);
+ }
+
+ public Optional<String> getTruststorePath() {
+ return readEnv(TlsConfigurationEnvs.TRUSTSTORE_PATH);
+ }
+
+ public Optional<String> getTruststorePassword() {
+ return readEnv(TlsConfigurationEnvs.TRUSTSTORE_PASSWORD);
+ }
+
+ private Optional<String> readEnv(TlsConfigurationEnvs envName) {
+ return envProvider.readEnvVariable(envName.toString());
+ }
+}
diff --git a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/TlsConfigurationEnvs.java b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/TlsConfigurationEnvs.java
new file mode 100644
index 00000000..4009a088
--- /dev/null
+++ b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/TlsConfigurationEnvs.java
@@ -0,0 +1,28 @@
+/*
+ * ============LICENSE_START=======================================================
+ * aaf-certservice-client
+ * ================================================================================
+ * Copyright (C) 2020 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.aaf.certservice.client.configuration;
+
+public enum TlsConfigurationEnvs {
+ KEYSTORE_PATH,
+ KEYSTORE_PASSWORD,
+ TRUSTSTORE_PATH,
+ TRUSTSTORE_PASSWORD
+}
diff --git a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/exception/TlsConfigurationException.java b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/exception/TlsConfigurationException.java
new file mode 100644
index 00000000..a10185b2
--- /dev/null
+++ b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/exception/TlsConfigurationException.java
@@ -0,0 +1,36 @@
+/*
+ * ============LICENSE_START=======================================================
+ * aaf-certservice-client
+ * ================================================================================
+ * Copyright (C) 2020 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.aaf.certservice.client.configuration.exception;
+
+import org.onap.aaf.certservice.client.api.ExitStatus;
+import org.onap.aaf.certservice.client.api.ExitableException;
+
+public class TlsConfigurationException extends ExitableException {
+ private static final ExitStatus EXIT_STATUS = ExitStatus.CERT_SERVICE_API_CONNECTION_EXCEPTION;
+
+ public TlsConfigurationException(String message) {
+ super(message);
+ }
+
+ public ExitStatus applicationExitStatus() {
+ return EXIT_STATUS;
+ }
+}
diff --git a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/factory/CsrConfigurationFactory.java b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/factory/CsrConfigurationFactory.java
index a94c906f..1d4cf2b2 100644
--- a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/factory/CsrConfigurationFactory.java
+++ b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/factory/CsrConfigurationFactory.java
@@ -27,12 +27,12 @@ import org.onap.aaf.certservice.client.configuration.model.CsrConfiguration;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+
public class CsrConfigurationFactory extends AbstractConfigurationFactory<CsrConfiguration> {
private static final Logger LOGGER = LoggerFactory.getLogger(CsrConfigurationFactory.class);
private final EnvsForCsr envsForCsr;
-
public CsrConfigurationFactory(EnvsForCsr envsForCsr) {
this.envsForCsr = envsForCsr;
}
diff --git a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/factory/SslContextFactory.java b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/factory/SslContextFactory.java
new file mode 100644
index 00000000..ef74d830
--- /dev/null
+++ b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/factory/SslContextFactory.java
@@ -0,0 +1,85 @@
+/*============LICENSE_START=======================================================
+ * aaf-certservice-client
+ * ================================================================================
+ * Copyright (C) 2020 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.aaf.certservice.client.configuration.factory;
+
+import org.apache.http.ssl.SSLContexts;
+import org.onap.aaf.certservice.client.configuration.EnvsForTls;
+import org.onap.aaf.certservice.client.configuration.TlsConfigurationEnvs;
+import org.onap.aaf.certservice.client.configuration.exception.TlsConfigurationException;
+
+import javax.net.ssl.SSLContext;
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.security.KeyStore;
+import java.security.KeyStoreException;
+import java.security.NoSuchAlgorithmException;
+import java.security.cert.CertificateException;
+
+public class SslContextFactory {
+
+ private static final String JKS = "jks";
+
+ private EnvsForTls envsForTls;
+
+ public SslContextFactory(EnvsForTls envsForTls) {
+ this.envsForTls = envsForTls;
+ }
+
+ public SSLContext create() throws TlsConfigurationException {
+ String keystorePath = envsForTls.getKeystorePath()
+ .orElseThrow(() -> new TlsConfigurationException(createEnvMissingMessage(TlsConfigurationEnvs.KEYSTORE_PATH)));
+ String keystorePassword = envsForTls.getKeystorePassword()
+ .orElseThrow(() -> new TlsConfigurationException(createEnvMissingMessage(TlsConfigurationEnvs.KEYSTORE_PASSWORD)));
+ String truststorePath = envsForTls.getTruststorePath()
+ .orElseThrow(() -> new TlsConfigurationException(createEnvMissingMessage(TlsConfigurationEnvs.TRUSTSTORE_PATH)));
+ String truststorePassword = envsForTls.getTruststorePassword()
+ .orElseThrow(() -> new TlsConfigurationException(createEnvMissingMessage(TlsConfigurationEnvs.TRUSTSTORE_PASSWORD)));
+
+ return createSSLContext(keystorePath, keystorePassword, truststorePath, truststorePassword);
+ }
+
+ private String createEnvMissingMessage(TlsConfigurationEnvs keystorePath) {
+ return String.format("%s env is missing.", keystorePath);
+ }
+
+ private KeyStore setupKeystore(String keystorePath, String certPassword)
+ throws KeyStoreException, IOException, NoSuchAlgorithmException, CertificateException {
+ KeyStore keyStore = KeyStore.getInstance(JKS);
+ FileInputStream identityKeyStoreFile = new FileInputStream(new File(
+ keystorePath));
+ keyStore.load(identityKeyStoreFile, certPassword.toCharArray());
+ return keyStore;
+ }
+
+ private SSLContext createSSLContext(String keystorePath, String keystorePassword, String truststorePath, String truststorePassword) throws TlsConfigurationException {
+ try {
+ KeyStore identityKeystore = setupKeystore(keystorePath, keystorePassword);
+ KeyStore trustKeystore = setupKeystore(truststorePath, truststorePassword);
+
+ return SSLContexts.custom()
+ .loadKeyMaterial(identityKeystore, keystorePassword.toCharArray())
+ .loadTrustMaterial(trustKeystore, null)
+ .build();
+ } catch (Exception e) {
+ throw new TlsConfigurationException("TLS configuration exception: " + e);
+ }
+ }
+}
diff --git a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/model/ClientConfiguration.java b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/model/ClientConfiguration.java
index ff2db831..2ac481dc 100644
--- a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/model/ClientConfiguration.java
+++ b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/configuration/model/ClientConfiguration.java
@@ -25,7 +25,7 @@ import org.onap.aaf.certservice.client.configuration.ClientConfigurationEnvs;
public class ClientConfiguration implements ConfigurationModel {
private static final Integer DEFAULT_TIMEOUT_MS = 30000;
- private static final String DEFAULT_REQUEST_URL = "http://aaf-cert-service-service:8080/v1/certificate/";
+ private static final String DEFAULT_REQUEST_URL = "https://aaf-cert-service:8443/v1/certificate/";
private String urlToCertService;
private Integer requestTimeout;
diff --git a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/httpclient/CloseableHttpClientProvider.java b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/httpclient/CloseableHttpsClientProvider.java
index 5ad933ff..3b7a46ab 100644
--- a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/httpclient/CloseableHttpClientProvider.java
+++ b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/httpclient/CloseableHttpsClientProvider.java
@@ -24,11 +24,15 @@ import org.apache.http.client.config.RequestConfig;
import org.apache.http.impl.client.CloseableHttpClient;
import org.apache.http.impl.client.HttpClientBuilder;
-public class CloseableHttpClientProvider {
+import javax.net.ssl.SSLContext;
+
+public class CloseableHttpsClientProvider {
private final int timeout;
+ private final SSLContext sslContext;
- public CloseableHttpClientProvider(int timeout) {
+ public CloseableHttpsClientProvider(SSLContext sslContext, int timeout) {
+ this.sslContext = sslContext;
this.timeout = timeout;
}
@@ -39,6 +43,9 @@ public class CloseableHttpClientProvider {
.setConnectTimeout(timeout)
.setSocketTimeout(timeout)
.build();
- return HttpClientBuilder.create().setDefaultRequestConfig(config).build();
+
+ return HttpClientBuilder.create()
+ .setSSLContext(sslContext)
+ .setDefaultRequestConfig(config).build();
}
}
diff --git a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/httpclient/HttpClient.java b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/httpclient/HttpClient.java
index 7512830d..0780afad 100644
--- a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/httpclient/HttpClient.java
+++ b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/httpclient/HttpClient.java
@@ -44,10 +44,10 @@ public class HttpClient {
private static final String CHARSET_UTF_8 = "UTF-8";
private final Gson gson = new Gson();
- private final CloseableHttpClientProvider httpClientProvider;
+ private final CloseableHttpsClientProvider httpClientProvider;
private final String certServiceAddress;
- public HttpClient(CloseableHttpClientProvider httpClientProvider, String certServiceAddress) {
+ public HttpClient(CloseableHttpsClientProvider httpClientProvider, String certServiceAddress) {
this.httpClientProvider = httpClientProvider;
this.certServiceAddress = certServiceAddress;
}
diff --git a/certServiceClient/src/test/java/org/onap/aaf/certservice/client/configuration/factory/SslContextFactoryTest.java b/certServiceClient/src/test/java/org/onap/aaf/certservice/client/configuration/factory/SslContextFactoryTest.java
new file mode 100644
index 00000000..e71e9895
--- /dev/null
+++ b/certServiceClient/src/test/java/org/onap/aaf/certservice/client/configuration/factory/SslContextFactoryTest.java
@@ -0,0 +1,197 @@
+/*
+ * ============LICENSE_START=======================================================
+ * aaf-certservice-client
+ * ================================================================================
+ * Copyright (C) 2020 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.aaf.certservice.client.configuration.factory;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+import org.onap.aaf.certservice.client.configuration.EnvsForTls;
+import org.onap.aaf.certservice.client.configuration.exception.TlsConfigurationException;
+
+import javax.net.ssl.SSLContext;
+import java.util.Optional;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.Mockito.when;
+
+
+@ExtendWith(MockitoExtension.class)
+public class SslContextFactoryTest {
+
+ public static final String INVALID_KEYSTORE_PATH = "nonexistent/keystore";
+ public static final String VALID_KEYSTORE_NAME = "keystore.jks";
+ public static final String VALID_KEYSTORE_PASSWORD = "secret";
+ public static final String INVALID_KEYSTORE_PASSWORD = "wrong_secret";
+ public static final String INVALID_TRUSTSTORE_PATH = "nonexistent/truststore";
+ public static final String VALID_TRUSTSTORE_PASSWORD = "secret";
+ public static final String INVALID_TRUSTSTORE_PASSWORD = "wrong_secret";
+ public static final String VALID_TRUSTSTORE_NAME = "truststore.jks";
+ @Mock
+ private EnvsForTls envsForTls;
+
+ @Test
+ public void shouldThrowExceptionWhenKeystorePathEnvIsMissing() {
+ // Given
+ when(envsForTls.getKeystorePath()).thenReturn(Optional.empty());
+ SslContextFactory sslContextFactory = new SslContextFactory(envsForTls);
+
+ // When, Then
+ Exception exception = assertThrows(
+ TlsConfigurationException.class, sslContextFactory::create
+ );
+ assertThat(exception.getMessage()).contains("KEYSTORE_PATH");
+ }
+
+ @Test
+ public void shouldThrowExceptionWhenKeystorePasswordEnvIsMissing() {
+ // Given
+ when(envsForTls.getKeystorePath()).thenReturn(Optional.of("keystore"));
+ when(envsForTls.getKeystorePassword()).thenReturn(Optional.empty());
+ SslContextFactory sslContextFactory = new SslContextFactory(envsForTls);
+
+ // When, Then
+ Exception exception = assertThrows(
+ TlsConfigurationException.class, sslContextFactory::create
+ );
+ assertThat(exception.getMessage()).contains("KEYSTORE_PASSWORD");
+ }
+
+ @Test
+ public void shouldThrowExceptionWhenTruststorePathEnvIsMissing() {
+ // Given
+ when(envsForTls.getKeystorePath()).thenReturn(Optional.of("keystore"));
+ when(envsForTls.getKeystorePassword()).thenReturn(Optional.of("password"));
+ when(envsForTls.getTruststorePath()).thenReturn(Optional.empty());
+ SslContextFactory sslContextFactory = new SslContextFactory(envsForTls);
+
+ // When, Then
+ Exception exception = assertThrows(
+ TlsConfigurationException.class, sslContextFactory::create
+ );
+ assertThat(exception.getMessage()).contains("TRUSTSTORE_PATH");
+ }
+
+ @Test
+ public void shouldThrowExceptionWhenTruststorePasswordEnvIsMissing() {
+ // Given
+ when(envsForTls.getKeystorePath()).thenReturn(Optional.of("keystore"));
+ when(envsForTls.getKeystorePassword()).thenReturn(Optional.of("password"));
+ when(envsForTls.getTruststorePath()).thenReturn(Optional.of("truststore"));
+ when(envsForTls.getTruststorePassword()).thenReturn(Optional.empty());
+ SslContextFactory sslContextFactory = new SslContextFactory(envsForTls);
+
+ // When, Then
+ Exception exception = assertThrows(
+ TlsConfigurationException.class, sslContextFactory::create
+ );
+ assertThat(exception.getMessage()).contains("TRUSTSTORE_PASSWORD");
+ }
+
+ @Test
+ public void shouldThrowExceptionWhenKeystoreIsMissing() {
+ // Given
+ when(envsForTls.getKeystorePath()).thenReturn(Optional.of(INVALID_KEYSTORE_PATH));
+ when(envsForTls.getKeystorePassword()).thenReturn(Optional.of("secret"));
+ when(envsForTls.getTruststorePath()).thenReturn(Optional.of("truststore.jks"));
+ when(envsForTls.getTruststorePassword()).thenReturn(Optional.of("secret"));
+ SslContextFactory sslContextFactory = new SslContextFactory(envsForTls);
+
+ // When, Then
+ assertThrows(
+ TlsConfigurationException.class, sslContextFactory::create
+ );
+ }
+
+ @Test
+ public void shouldThrowExceptionWhenKeystorePasswordIsWrong() {
+ // Given
+ String keystorePath = getResourcePath(VALID_KEYSTORE_NAME);
+ when(envsForTls.getKeystorePath()).thenReturn(Optional.of(keystorePath));
+ when(envsForTls.getKeystorePassword()).thenReturn(Optional.of(INVALID_KEYSTORE_PASSWORD));
+ when(envsForTls.getTruststorePath()).thenReturn(Optional.of(VALID_TRUSTSTORE_NAME));
+ when(envsForTls.getTruststorePassword()).thenReturn(Optional.of(VALID_TRUSTSTORE_PASSWORD));
+ SslContextFactory sslContextFactory = new SslContextFactory(envsForTls);
+
+ // When, Then
+ assertThrows(
+ TlsConfigurationException.class, sslContextFactory::create
+ );
+ }
+
+ @Test
+ public void shouldThrowExceptionWhenTruststoreIsMissing() {
+ // Given
+ String keystorePath = getResourcePath(VALID_KEYSTORE_NAME);
+ when(envsForTls.getKeystorePath()).thenReturn(Optional.of(keystorePath));
+ when(envsForTls.getKeystorePassword()).thenReturn(Optional.of(VALID_KEYSTORE_PASSWORD));
+ when(envsForTls.getTruststorePath()).thenReturn(Optional.of(INVALID_TRUSTSTORE_PATH));
+ when(envsForTls.getTruststorePassword()).thenReturn(Optional.of(VALID_TRUSTSTORE_PASSWORD));
+ SslContextFactory sslContextFactory = new SslContextFactory(envsForTls);
+
+ // When, Then
+ assertThrows(
+ TlsConfigurationException.class, sslContextFactory::create
+ );
+ }
+
+ @Test
+ public void shouldThrowExceptionWhenTruststorePasswordIsWrong() {
+ // Given
+ String keystorePath = getResourcePath(VALID_KEYSTORE_NAME);
+ String truststorePath = getResourcePath(VALID_TRUSTSTORE_NAME);
+ when(envsForTls.getKeystorePath()).thenReturn(Optional.of(keystorePath));
+ when(envsForTls.getKeystorePassword()).thenReturn(Optional.of(VALID_KEYSTORE_PASSWORD));
+ when(envsForTls.getTruststorePath()).thenReturn(Optional.of(truststorePath));
+ when(envsForTls.getTruststorePassword()).thenReturn(Optional.of(INVALID_TRUSTSTORE_PASSWORD));
+ SslContextFactory sslContextFactory = new SslContextFactory(envsForTls);
+
+ // When, Then
+ assertThrows(
+ TlsConfigurationException.class, sslContextFactory::create
+ );
+ }
+
+ @Test
+ public void shouldReturnSSLContext() throws TlsConfigurationException {
+ // Given
+ String keystorePath = getResourcePath(VALID_KEYSTORE_NAME);
+ String truststorePath = getResourcePath(VALID_TRUSTSTORE_NAME);
+ when(envsForTls.getKeystorePath()).thenReturn(Optional.of(keystorePath));
+ when(envsForTls.getKeystorePassword()).thenReturn(Optional.of(VALID_KEYSTORE_PASSWORD));
+ when(envsForTls.getTruststorePath()).thenReturn(Optional.of(truststorePath));
+ when(envsForTls.getTruststorePassword()).thenReturn(Optional.of(VALID_TRUSTSTORE_PASSWORD));
+ SslContextFactory sslContextFactory = new SslContextFactory(envsForTls);
+
+ // When
+ SSLContext sslContext = sslContextFactory.create();
+
+ // Then
+ assertNotNull(sslContext);
+ }
+
+ private String getResourcePath(String resource) {
+ return getClass().getClassLoader().getResource(resource).getFile();
+ }
+}
+
diff --git a/certServiceClient/src/test/java/org/onap/aaf/certservice/client/configuration/model/ClientConfigurationFactoryTest.java b/certServiceClient/src/test/java/org/onap/aaf/certservice/client/configuration/model/ClientConfigurationFactoryTest.java
index c936ef52..f4f92495 100644
--- a/certServiceClient/src/test/java/org/onap/aaf/certservice/client/configuration/model/ClientConfigurationFactoryTest.java
+++ b/certServiceClient/src/test/java/org/onap/aaf/certservice/client/configuration/model/ClientConfigurationFactoryTest.java
@@ -38,8 +38,8 @@ public class ClientConfigurationFactoryTest {
private final String CA_NAME_VALID = "caaaftest2";
private final String TIME_OUT_VALID = "30000";
private final String OUTPUT_PATH_VALID = "/opt/app/osaaf";
- private final String URL_TO_CERT_SERVICE_VALID = "http://cert-service:8080/v1/certificate/";
- private final String URL_TO_CERT_SERVICE_DEFAULT = "http://aaf-cert-service-service:8080/v1/certificate/";
+ private final String URL_TO_CERT_SERVICE_VALID = "https://cert-service:8443/v1/certificate/";
+ private final String URL_TO_CERT_SERVICE_DEFAULT = "https://aaf-cert-service:8443/v1/certificate/";
private final String CA_NAME_INVALID = "caaaftest2#$";
private final String OUTPUT_PATH_INVALID = "/opt//app/osaaf";
diff --git a/certServiceClient/src/test/java/org/onap/aaf/certservice/client/httpclient/HttpClientTest.java b/certServiceClient/src/test/java/org/onap/aaf/certservice/client/httpclient/HttpClientTest.java
index 2a539414..60c2e93d 100644
--- a/certServiceClient/src/test/java/org/onap/aaf/certservice/client/httpclient/HttpClientTest.java
+++ b/certServiceClient/src/test/java/org/onap/aaf/certservice/client/httpclient/HttpClientTest.java
@@ -66,7 +66,7 @@ class HttpClientTest {
statusLine = mock(StatusLine.class);
httpResponse = mock(CloseableHttpResponse.class);
- CloseableHttpClientProvider httpClientProvider = mock(CloseableHttpClientProvider.class);
+ CloseableHttpsClientProvider httpClientProvider = mock(CloseableHttpsClientProvider.class);
when(httpClientProvider.getClient()).thenReturn(closeableHttpClient);
String testCertServiceAddress = "";
diff --git a/certServiceClient/src/test/resources/keystore.jks b/certServiceClient/src/test/resources/keystore.jks
new file mode 100644
index 00000000..0de9a18d
--- /dev/null
+++ b/certServiceClient/src/test/resources/keystore.jks
Binary files differ
diff --git a/certServiceClient/src/test/resources/truststore.jks b/certServiceClient/src/test/resources/truststore.jks
new file mode 100644
index 00000000..2686690e
--- /dev/null
+++ b/certServiceClient/src/test/resources/truststore.jks
Binary files differ