diff options
author | Tait,Trevor(rt0435) <rtait@amdocs.com> | 2018-10-30 13:22:36 -0400 |
---|---|---|
committer | Tait,Trevor(rt0435) <rtait@amdocs.com> | 2018-11-02 14:12:49 -0400 |
commit | 23b36e3c69f25d8322afb79d5e6bace519db7cd3 (patch) | |
tree | 5223fe7c12d0b81877759e0c19653c6249c8cf29 /src/main/java/org/onap/pomba/contextbuilder/sdnc/model/Vnf.java | |
parent | a088960969f4d54e39cd83c8e24565301b6c7d67 (diff) |
Address Bugs and Vulnerabilities in Sonar Report
Addressing Bugs and Vulnerabilities in Sonar Report.
https://sonar.onap.org/dashboard?id=org.onap.logging-analytics.pomba%3Apomba-sdnc-context-builder
Issue-ID: LOG-791
Change-Id: I11b984cac77c8a5674103672fa0e1332ed0aa4f7
Signed-off-by: Tait,Trevor(rt0435) <rtait@amdocs.com>
Diffstat (limited to 'src/main/java/org/onap/pomba/contextbuilder/sdnc/model/Vnf.java')
-rw-r--r-- | src/main/java/org/onap/pomba/contextbuilder/sdnc/model/Vnf.java | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/src/main/java/org/onap/pomba/contextbuilder/sdnc/model/Vnf.java b/src/main/java/org/onap/pomba/contextbuilder/sdnc/model/Vnf.java index 36842a3..54b0f1f 100644 --- a/src/main/java/org/onap/pomba/contextbuilder/sdnc/model/Vnf.java +++ b/src/main/java/org/onap/pomba/contextbuilder/sdnc/model/Vnf.java @@ -33,6 +33,7 @@ public class Vnf { @Expose private ServiceData serviceData; + private final static String NULL_STR = "<null>"; /** * No args constructor for use in serialization @@ -84,15 +85,15 @@ public class Vnf { sb.append(Vnf.class.getName()).append('@').append(Integer.toHexString(System.identityHashCode(this))).append('['); sb.append("vnfId"); sb.append('='); - sb.append(((this.vnfId == null)?"<null>":this.vnfId)); + sb.append(((this.vnfId == null)?NULL_STR:this.vnfId)); sb.append(','); sb.append("serviceStatus"); sb.append('='); - sb.append(((this.serviceStatus == null)?"<null>":this.serviceStatus)); + sb.append(((this.serviceStatus == null)?NULL_STR:this.serviceStatus)); sb.append(','); sb.append("serviceData"); sb.append('='); - sb.append(((this.serviceData == null)?"<null>":this.serviceData)); + sb.append(((this.serviceData == null)?NULL_STR:this.serviceData)); sb.append(','); if (sb.charAt((sb.length()- 1)) == ',') { sb.setCharAt((sb.length()- 1), ']'); @@ -116,7 +117,7 @@ public class Vnf { if (other == this) { return true; } - if ((other instanceof Vnf) == false) { + if (!(other instanceof Vnf)) { return false; } Vnf rhs = ((Vnf) other); |