1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
|
package ports_test
import (
"strconv"
. "github.com/onsi/ginkgo"
. "github.com/onsi/gomega"
v1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
. "onap.local/sslendpoints/ports"
)
var _ = Describe("Ports", func() {
const (
notNodePort = 0
nodePortO = 30200
nodePortN = 30201
nodePortA = 30202
nodePortP = 30203
serviceR = "serviceR"
serviceL = "serviceL"
serviceZ = "serviceZ"
notParsablePort1 = "3p1c"
notParsablePort2 = "0n4p"
notParsablePort3 = "5GxD"
externalIpControl = "1.2.3.4"
internalIpControl = "192.168.121.100"
internalIpWorker = "192.168.121.200"
hostnameControl = "onap-control-1"
hostnameWorker = "onap-worker-1"
)
var (
csvSomeUnparsable [][]string
csvAllUnparsable [][]string
servicesEmpty *v1.ServiceList
servicesSingleWithNodePort *v1.ServiceList
servicesSingleWithMultipleNodePorts *v1.ServiceList
servicesManyWithoutNodePorts *v1.ServiceList
servicesManyWithNodePort *v1.ServiceList
servicesManyWithMultipleNodePorts *v1.ServiceList
servicesManyMixedNodePorts *v1.ServiceList
nodesEmpty *v1.NodeList
nodesSingleWithIP *v1.NodeList
nodesSingleWithBothIPs *v1.NodeList
nodesManyWithHostnames *v1.NodeList
nodesManyWithMixedIPs *v1.NodeList
)
BeforeEach(func() {
csvSomeUnparsable = [][]string{
{serviceR, strconv.Itoa(nodePortO)},
{serviceL, strconv.Itoa(nodePortN)},
{serviceZ, notParsablePort1},
}
csvAllUnparsable = [][]string{
{serviceR, notParsablePort1},
{serviceL, notParsablePort2},
{serviceZ, notParsablePort3},
}
servicesEmpty = &v1.ServiceList{}
servicesSingleWithNodePort = &v1.ServiceList{
Items: []v1.Service{
{
ObjectMeta: metav1.ObjectMeta{Name: serviceR},
Spec: v1.ServiceSpec{
Ports: []v1.ServicePort{
{NodePort: nodePortO},
},
},
},
},
}
servicesSingleWithMultipleNodePorts = &v1.ServiceList{
Items: []v1.Service{
{
ObjectMeta: metav1.ObjectMeta{Name: serviceR},
Spec: v1.ServiceSpec{
Ports: []v1.ServicePort{
{NodePort: nodePortO},
{NodePort: nodePortN},
},
},
},
},
}
servicesManyWithoutNodePorts = &v1.ServiceList{
Items: []v1.Service{
{
Spec: v1.ServiceSpec{
Ports: []v1.ServicePort{
{NodePort: notNodePort},
},
},
},
{
Spec: v1.ServiceSpec{
Ports: []v1.ServicePort{
{NodePort: notNodePort},
},
},
},
},
}
servicesManyWithNodePort = &v1.ServiceList{
Items: []v1.Service{
{
ObjectMeta: metav1.ObjectMeta{Name: serviceR},
Spec: v1.ServiceSpec{
Ports: []v1.ServicePort{
{NodePort: nodePortO},
},
},
},
{
ObjectMeta: metav1.ObjectMeta{Name: serviceL},
Spec: v1.ServiceSpec{
Ports: []v1.ServicePort{
{NodePort: nodePortN},
},
},
},
},
}
servicesManyWithMultipleNodePorts = &v1.ServiceList{
Items: []v1.Service{
{
ObjectMeta: metav1.ObjectMeta{Name: serviceR},
Spec: v1.ServiceSpec{
Ports: []v1.ServicePort{
{NodePort: nodePortO},
{NodePort: nodePortN},
},
},
},
{
ObjectMeta: metav1.ObjectMeta{Name: serviceL},
Spec: v1.ServiceSpec{
Ports: []v1.ServicePort{
{NodePort: nodePortA},
{NodePort: nodePortP},
},
},
},
},
}
servicesManyMixedNodePorts = &v1.ServiceList{
Items: []v1.Service{
{
ObjectMeta: metav1.ObjectMeta{Name: serviceR},
Spec: v1.ServiceSpec{
Ports: []v1.ServicePort{
{NodePort: notNodePort},
},
},
},
{
ObjectMeta: metav1.ObjectMeta{Name: serviceL},
Spec: v1.ServiceSpec{
Ports: []v1.ServicePort{
{NodePort: nodePortO},
},
},
},
{
ObjectMeta: metav1.ObjectMeta{Name: serviceZ},
Spec: v1.ServiceSpec{
Ports: []v1.ServicePort{
{NodePort: nodePortN},
{NodePort: nodePortA},
},
},
},
},
}
nodesEmpty = &v1.NodeList{}
nodesSingleWithIP = &v1.NodeList{
Items: []v1.Node{
{
Status: v1.NodeStatus{
Addresses: []v1.NodeAddress{
{Type: "InternalIP", Address: internalIpControl},
{Type: "Hostname", Address: hostnameControl},
},
},
},
},
}
nodesSingleWithBothIPs = &v1.NodeList{
Items: []v1.Node{
{
Status: v1.NodeStatus{
Addresses: []v1.NodeAddress{
{Type: "ExternalIP", Address: externalIpControl},
{Type: "InternalIP", Address: internalIpControl},
{Type: "Hostname", Address: hostnameControl},
},
},
},
},
}
nodesManyWithHostnames = &v1.NodeList{
Items: []v1.Node{
{
Status: v1.NodeStatus{
Addresses: []v1.NodeAddress{
{Type: "Hostname", Address: hostnameControl},
},
},
},
{
Status: v1.NodeStatus{
Addresses: []v1.NodeAddress{
{Type: "Hostname", Address: hostnameWorker},
},
},
},
},
}
nodesManyWithMixedIPs = &v1.NodeList{
Items: []v1.Node{
{
Status: v1.NodeStatus{
Addresses: []v1.NodeAddress{
{Type: "ExternalIP", Address: externalIpControl},
{Type: "InternalIP", Address: internalIpControl},
{Type: "Hostname", Address: hostnameControl},
},
},
},
{
Status: v1.NodeStatus{
Addresses: []v1.NodeAddress{
{Type: "InternalIP", Address: internalIpWorker},
{Type: "Hostname", Address: hostnameWorker},
},
},
},
},
}
})
Describe("CSV data to NodePorts conversion", func() {
Context("With no data", func() {
It("should return an empty map", func() {
cnp, ok := ConvertNodePorts([][]string{})
Expect(ok).To(BeFalse())
Expect(cnp).To(BeEmpty())
})
})
Context("With some ports unparsable", func() {
It("should return only parsable records", func() {
expected := map[uint16]string{nodePortO: serviceR, nodePortN: serviceL}
cnp, ok := ConvertNodePorts(csvSomeUnparsable)
Expect(ok).To(BeTrue())
Expect(cnp).To(Equal(expected))
})
})
Context("With all ports unparsable", func() {
It("should return an empty map", func() {
cnp, ok := ConvertNodePorts(csvAllUnparsable)
Expect(ok).To(BeFalse())
Expect(cnp).To(BeEmpty())
})
})
})
Describe("NodePorts expected to fail filtering", func() {
Context("With no data", func() {
It("should leave nodeports unchanged", func() {
nodeports := map[uint16]string{nodePortO: serviceR}
expected := make(map[uint16]string)
for k, v := range nodeports {
expected[k] = v
}
FilterXFailNodePorts(map[uint16]string{}, nodeports)
Expect(nodeports).To(Equal(expected))
})
})
Context("With port absent in NodePorts", func() {
It("should leave nodeports unchanged", func() {
xfail := map[uint16]string{nodePortP: serviceZ}
nodeports := map[uint16]string{nodePortO: serviceR}
expected := make(map[uint16]string)
for k, v := range nodeports {
expected[k] = v
}
FilterXFailNodePorts(xfail, nodeports)
Expect(nodeports).To(Equal(expected))
})
})
Context("With other service than in NodePorts", func() {
It("should leave nodeports unchanged", func() {
xfail := map[uint16]string{nodePortO: serviceZ}
nodeports := map[uint16]string{nodePortO: serviceR}
expected := make(map[uint16]string)
for k, v := range nodeports {
expected[k] = v
}
FilterXFailNodePorts(xfail, nodeports)
Expect(nodeports).To(Equal(expected))
})
})
Context("With all NodePorts expected to fail", func() {
It("should leave no nodeports", func() {
xfail := map[uint16]string{nodePortO: serviceR, nodePortN: serviceL}
nodeports := map[uint16]string{nodePortO: serviceR, nodePortN: serviceL}
FilterXFailNodePorts(xfail, nodeports)
Expect(nodeports).To(BeEmpty())
})
})
})
Describe("NodePorts extraction", func() {
Context("With empty service list", func() {
It("should report no NodePorts", func() {
nodeports, ok := FilterNodePorts(servicesEmpty)
Expect(ok).To(BeFalse())
Expect(nodeports).To(BeEmpty())
})
})
Context("With service using single NodePort", func() {
It("should report single NodePort", func() {
expected := map[uint16]string{nodePortO: serviceR}
nodeports, ok := FilterNodePorts(servicesSingleWithNodePort)
Expect(ok).To(BeTrue())
Expect(nodeports).To(Equal(expected))
})
})
Context("With service using multiple NodePorts", func() {
It("should report all NodePorts", func() {
expected := map[uint16]string{nodePortO: serviceR, nodePortN: serviceR}
nodeports, ok := FilterNodePorts(servicesSingleWithMultipleNodePorts)
Expect(ok).To(BeTrue())
Expect(nodeports).To(Equal(expected))
})
})
Context("With many services using no NodePorts", func() {
It("should report no NodePorts", func() {
nodeports, ok := FilterNodePorts(servicesManyWithoutNodePorts)
Expect(ok).To(BeFalse())
Expect(nodeports).To(BeEmpty())
})
})
Context("With services using single NodePort", func() {
It("should report all NodePorts", func() {
expected := map[uint16]string{nodePortO: serviceR, nodePortN: serviceL}
nodeports, ok := FilterNodePorts(servicesManyWithNodePort)
Expect(ok).To(BeTrue())
Expect(nodeports).To(Equal(expected))
})
})
Context("With services using multiple NodePorts", func() {
It("should report all NodePorts", func() {
expected := map[uint16]string{
nodePortO: serviceR, nodePortN: serviceR,
nodePortA: serviceL, nodePortP: serviceL,
}
nodeports, ok := FilterNodePorts(servicesManyWithMultipleNodePorts)
Expect(ok).To(BeTrue())
Expect(nodeports).To(Equal(expected))
})
})
Context("With mixed services", func() {
It("should report all NodePorts", func() {
expected := map[uint16]string{
nodePortO: serviceL, nodePortN: serviceZ, nodePortA: serviceZ,
}
nodeports, ok := FilterNodePorts(servicesManyMixedNodePorts)
Expect(ok).To(BeTrue())
Expect(nodeports).To(Equal(expected))
})
})
})
Describe("IP addresses extraction", func() {
Context("With empty node list", func() {
It("should report no IP addresses", func() {
addresses, ok := FilterIPAddresses(nodesEmpty)
Expect(ok).To(BeFalse())
Expect(addresses).To(BeEmpty())
})
})
Context("With nodes using only hostnames", func() {
It("should report no IP addresses", func() {
addresses, ok := FilterIPAddresses(nodesManyWithHostnames)
Expect(ok).To(BeFalse())
Expect(addresses).To(BeEmpty())
})
})
Context("With node using only internal IP", func() {
It("should report internal IP", func() {
expected := []string{internalIpControl}
addresses, ok := FilterIPAddresses(nodesSingleWithIP)
Expect(ok).To(BeTrue())
Expect(addresses).To(Equal(expected))
})
})
Context("With node in the cloud", func() {
It("should report all IPs in correct order", func() {
expected := []string{externalIpControl, internalIpControl}
addresses, ok := FilterIPAddresses(nodesSingleWithBothIPs)
Expect(ok).To(BeTrue())
Expect(addresses).To(Equal(expected))
})
})
Context("With nodes in the mixed cloud", func() {
It("should report external IP as the first one", func() {
addresses, ok := FilterIPAddresses(nodesManyWithMixedIPs)
Expect(ok).To(BeTrue())
Expect(addresses[0]).To(Equal(externalIpControl))
})
})
})
})
|
