Refactor bulk class

Find failing requests and retry bulk without them

Issue-ID: TEST-404
Change-Id: Ia60f7761bcee99bcb6d0af0381db267d259e77a2
Signed-off-by: Michal Jagiello <michal.jagiello@t-mobile.pl>

1 files changed, 162 insertions, 3 deletions

diff --git a/tests/test_aai_bulk.py b/tests/test_aai_bulk.py
index 0567055..880cc5c 100644
--- a/tests/test_aai_bulk.py
+++ b/tests/test_aai_bulk.py
@@ -12,8 +12,10 @@
 #   See the License for the specific language governing permissions and
 #   limitations under the License.
 from unittest import mock
+from pytest import raises
 
 from onapsdk.aai.bulk import AaiBulk, AaiBulkRequest, AaiBulkResponse
+from onapsdk.exceptions import APIError
 
 
 BULK_RESPONSES = {
@@ -38,7 +40,7 @@ BULK_RESPONSES = {
 def test_aai_bulk(mock_send_message_json):
     assert AaiBulk().url.endswith("bulk")
     mock_send_message_json.return_value = BULK_RESPONSES
-    responses = list(AaiBulk.single_transaction(
+    responses = list(AaiBulk().single_transaction(
         [
             AaiBulkRequest(
                 action="post",
@@ -65,7 +67,7 @@ def test_aai_bulk(mock_send_message_json):
 
     # Check if requests was splitted into chunks for generator
     mock_send_message_json.reset_mock()
-    responses = list(AaiBulk.single_transaction(
+    responses = list(AaiBulk().single_transaction(
         (
             AaiBulkRequest(
                 action="post",
@@ -78,7 +80,7 @@ def test_aai_bulk(mock_send_message_json):
 
     # Check if requests was splitted into chunks for list
     mock_send_message_json.reset_mock()
-    responses = list(AaiBulk.single_transaction(
+    responses = list(AaiBulk().single_transaction(
         [
             AaiBulkRequest(
                 action="post",
@@ -88,3 +90,160 @@ def test_aai_bulk(mock_send_message_json):
         ]
     ))
     assert mock_send_message_json.call_count == 2
+
+    mock_send_message_json.reset_mock()
+    responses = list(AaiBulk().single_transaction([]))
+    assert mock_send_message_json.call_count == 0
+
+
+@mock.patch("onapsdk.aai.bulk.AaiBulk.send_message_json")
+def test_aai_bulk_retry_and_remove_first_which_is_failing(mock_send_message_json):
+    mock_send_message_json.side_effect = [APIError(response_text="Error with operation 0"), BULK_RESPONSES]
+    aai_bulk = AaiBulk()
+    assert len(aai_bulk.failed_requests) == 0
+    list(aai_bulk.single_transaction([
+            AaiBulkRequest(
+                action="post",
+                uri="test-uri",
+                body={"blabla: blabla"}
+            ),
+            AaiBulkRequest(
+                action="get",
+                uri="test-uri",
+                body={}
+            )]))
+    assert mock_send_message_json.call_count == 2
+    assert len(aai_bulk.failed_requests) == 1
+    assert aai_bulk.failed_requests[0].action == "post"
+    assert aai_bulk.failed_requests[0].uri == "test-uri"
+    assert aai_bulk.failed_requests[0].body == {"blabla: blabla"}
+
+
+@mock.patch("onapsdk.aai.bulk.AaiBulk.send_message_json")
+def test_aai_bulk_retry_and_remove_second_which_is_failing(mock_send_message_json):
+    mock_send_message_json.side_effect = [APIError(response_text="Error with operation 1"), BULK_RESPONSES]
+    aai_bulk = AaiBulk()
+    list(aai_bulk.single_transaction([
+            AaiBulkRequest(
+                action="post",
+                uri="test-uri",
+                body={"blabla: blabla"}
+            ),
+            AaiBulkRequest(
+                action="get",
+                uri="test-uri",
+                body={}
+            )]))
+    assert mock_send_message_json.call_count == 2
+    assert len(aai_bulk.failed_requests) == 1
+    assert aai_bulk.failed_requests[0].action == "get"
+    assert aai_bulk.failed_requests[0].uri == "test-uri"
+    assert aai_bulk.failed_requests[0].body == {}
+
+
+@mock.patch("onapsdk.aai.bulk.AaiBulk.send_message_json")
+def test_aai_bulk_retry_and_remove_both_which_are_failing_reverse_order(mock_send_message_json):
+    mock_send_message_json.side_effect = [APIError(response_text="Error with operation 1"), APIError(response_text="Error with operation 0")]
+    aai_bulk = AaiBulk()
+    list(aai_bulk.single_transaction([
+            AaiBulkRequest(
+                action="post",
+                uri="test-uri",
+                body={"blabla: blabla"}
+            ),
+            AaiBulkRequest(
+                action="get",
+                uri="test-uri",
+                body={}
+            )]))
+    assert mock_send_message_json.call_count == 2
+    assert len(aai_bulk.failed_requests) == 2
+    assert aai_bulk.failed_requests[0].action == "get"
+    assert aai_bulk.failed_requests[0].uri == "test-uri"
+    assert aai_bulk.failed_requests[0].body == {}
+    assert aai_bulk.failed_requests[1].action == "post"
+    assert aai_bulk.failed_requests[1].uri == "test-uri"
+    assert aai_bulk.failed_requests[1].body == {"blabla: blabla"}
+
+
+@mock.patch("onapsdk.aai.bulk.AaiBulk.send_message_json")
+def test_aai_bulk_retry_and_remove_both_which_are_failing_in_order(mock_send_message_json):
+    mock_send_message_json.side_effect = [APIError(response_text="Error with operation 0"), APIError(response_text="Error with operation 0")]
+    aai_bulk = AaiBulk()
+    list(aai_bulk.single_transaction([
+            AaiBulkRequest(
+                action="post",
+                uri="test-uri",
+                body={"blabla: blabla"}
+            ),
+            AaiBulkRequest(
+                action="get",
+                uri="test-uri",
+                body={}
+            )]))
+    assert mock_send_message_json.call_count == 2
+    assert len(aai_bulk.failed_requests) == 2
+    assert aai_bulk.failed_requests[0].action == "post"
+    assert aai_bulk.failed_requests[0].uri == "test-uri"
+    assert aai_bulk.failed_requests[0].body == {"blabla: blabla"}
+    assert aai_bulk.failed_requests[1].action == "get"
+    assert aai_bulk.failed_requests[1].uri == "test-uri"
+    assert aai_bulk.failed_requests[1].body == {}
+
+
+@mock.patch("onapsdk.aai.bulk.AaiBulk.send_message_json")
+def test_aai_bulk_parse_invalid_response_text(mock_send_message_json):
+    mock_send_message_json.side_effect = [APIError(response_text="Invalid response text")]
+    aai_bulk = AaiBulk()
+    with raises(APIError):
+        list(aai_bulk.single_transaction([
+                AaiBulkRequest(
+                    action="post",
+                    uri="test-uri",
+                    body={"blabla: blabla"}
+                ),
+                AaiBulkRequest(
+                    action="get",
+                    uri="test-uri",
+                    body={}
+                )]))
+
+
+@mock.patch("onapsdk.aai.bulk.AaiBulk.send_message_json")
+def test_aai_bulk_do_not_retry(mock_send_message_json):
+    mock_send_message_json.side_effect = [APIError(response_text="Error with operation 0")]
+    aai_bulk = AaiBulk()
+    with raises(APIError):
+        list(aai_bulk.single_transaction([
+                AaiBulkRequest(
+                    action="post",
+                    uri="test-uri",
+                    body={"blabla: blabla"}
+                ),
+                AaiBulkRequest(
+                    action="get",
+                    uri="test-uri",
+                    body={}
+                )], remove_failed_operation_on_failure=False))
+    assert len(aai_bulk.failed_requests) == 0
+    assert mock_send_message_json.call_count == 1
+
+
+def test_get_failed_operation_index():
+    aai_bulk = AaiBulk()
+    def get_formatted_response_error_with_operation(index: int) -> str:
+        return ('{"requestError":{"serviceException":{"messageId":"SVC3000","text":"Invalid input performing %1 on %2 (msg=%3)'
+                f' (ec=%4)","variables":["POST","v27/bulk/single-transaction","Invalid input performing %1 on %2:Error with operation {index}: '
+                'Missing required property: physical-location-type,Missing required property: street1,Missing required property: city,'
+                'Missing required property: postal-code,Missing required property: country,Missing required property: region","ERR.5.2.3000"]}}}')
+    def get_formatted_response_not_found(index: int) -> str:
+        return ('{"requestError":{"serviceException":{"messageId":"SVC3000","text":"Invalid input performing %1 on %2 (msg=%3) '
+                f'(ec=%4)","variables":["POST","v27/bulk/single-transaction","Invalid input performing %1 on %2:Operation {index} with action '
+                '(DELETE) on uri (/cloud-infrastructure/complexes/complex/test-parse-bulk-response) failed with status code (404), error code '
+                '(ERR.5.4.6114) and msg (Node Not Found:No Node of type complex found at: /cloud-infrastructure/complexes/complex/test-parse-bulk-response)","ERR.5.2.3000"]}}}')
+    assert aai_bulk._get_failed_operation_index(None) == -1
+    assert aai_bulk._get_failed_operation_index("Something on what there is no index") == -1
+    assert aai_bulk._get_failed_operation_index("There is an index: 0 but it's not a valid string") == -1
+    for i in [pow(10, x) for x in range(6)]:
+        assert aai_bulk._get_failed_operation_index(get_formatted_response_error_with_operation(i)) == i
+        assert aai_bulk._get_failed_operation_index(get_formatted_response_not_found(i)) == i