diff options
author | Michal Jagiello <michal.jagiello@t-mobile.pl> | 2023-10-27 13:26:12 +0200 |
---|---|---|
committer | Michal Jagiello <michal.jagiello@t-mobile.pl> | 2023-10-27 13:26:12 +0200 |
commit | 4bdb9d7a9e6b0087332a61125d544a95e695cb8b (patch) | |
tree | 6e511ab58181713c3aa10d465110def7197e9a54 /src/onapsdk/sdnc | |
parent | f2b1b5ed7fb348eb7c7f065840afaffc8cbec557 (diff) |
Use latest pylint and make fixes for it
Do not be sticked into one version of pylint, but use the latest
Issue-ID: INT-404
Signed-off-by: Michal Jagiello <michal.jagiello@t-mobile.pl>
Change-Id: Ib2c0a2ebe680968ae9d69958a564733a76990367
Diffstat (limited to 'src/onapsdk/sdnc')
-rw-r--r-- | src/onapsdk/sdnc/topology.py | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/src/onapsdk/sdnc/topology.py b/src/onapsdk/sdnc/topology.py index f618c2c..2b79ec9 100644 --- a/src/onapsdk/sdnc/topology.py +++ b/src/onapsdk/sdnc/topology.py @@ -12,7 +12,7 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. -from typing import List, Dict, Iterable +from typing import List, Dict, Iterable, Optional from onapsdk.utils.headers_creator import headers_sdnc_creator from onapsdk.utils.jinja import jinja_env @@ -219,7 +219,7 @@ class Topology(SdncElement): except KeyError: return Topology(topology_id=topology_id) - def get_node(self, node_id) -> "Node": + def get_node(self, node_id) -> Optional["Node"]: """Get the node with a specific node_id form the specific topology at SDNC via NETCONF-API. Returns: @@ -240,7 +240,8 @@ class Topology(SdncElement): password=node["netconf-node-topology:password"], topology_id=self.topology_id) except KeyError: - print(f"Error. Node creation skipped.") + self._logger.error("Error. Node creation skipped.") + return None def get_all_nodes(self) -> Iterable["Node"]: """Get all nodes of the specific topology from SDNC using NETCONF-API. @@ -264,4 +265,4 @@ class Topology(SdncElement): password=node["netconf-node-topology:password"], topology_id=self.topology_id) except KeyError: - print(f"Error. Node creation skipped. KeyError") + self._logger.error("Error. Node creation skipped. KeyError") |