aboutsummaryrefslogtreecommitdiffstats
path: root/test
AgeCommit message (Collapse)AuthorFilesLines
2020-04-16Add test to verify bad API prefix handling by the serviceBartek Grzybowski2-0/+33
Functional test for verifying that the service handles bad API prefix in URI string properly and returns appropriate response to the client. Change-Id: I5e5e8a9dcd6fe05bd2b4536790d16e825aa21679 Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-16Add test to verify bad MOI handling by the serviceBartek Grzybowski2-0/+30
Functional test for verifying that the service handles bad MOI class in URI string properly and returns appropriate response to the client. Change-Id: I606aaba5c400f81e8142a34f250bc249251feaf7 Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-16Add test to verify unauthorized requestsBartek Grzybowski3-1/+27
Functional test for verifying that the service forbids API access with proper http code and message should the client provide wrong auth credentials. Change-Id: I78d5f050e99c23fd7116468ff007078b3cd56987 Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-16Fix invalid prefix check handlingBartek Grzybowski1-20/+28
Should the URI prefix length in the request be incorrect and not contain two "/" the service would fail with "empty response" on client side due to unhandled "list index out of range" in the server process while trying to get the idName from pathlist[4] which throws IndexError. Prefix validation, id and class variable assignment are wrapped up in try-except clause to evaluate the prefix check correctly, catch the exception and return appropriate response to the client. Change-Id: If6333228fbdd3a8075ade55436c3ca9bb8a97caa Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-16Return http 404 for wrong prefix, not 401Bartek Grzybowski1-4/+8
The correct http code for wrong REST API url should be http "404 Not Found", not "401 Unauthorized". Change-Id: I78710fcd4c43926dbba3227c4099bf6239095f19 Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-15Move tests to their own directoryBartek Grzybowski9-24/+30
File layout was also restructured for better readability. Change-Id: Id1cba755127319c45ec50b08d12daa543c8c9ae5 Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-15Add tox runner for pytest in prov-mns-providerBartek Grzybowski2-0/+12
Pytest setup as entrypoint to gating job in CI. Change-Id: If052af0f7c8272844f644cb3789dbc3a8451c629 Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-15Extend unit tests for provisioning management serviceBartek Grzybowski1-0/+25
This adds additional unit tests for the service provider for PATCH and DELETE request methods. Change-Id: If0cce9c713f2999c859910661308c24ac68f04d6 Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-15Add unit tests for provisioning management serviceBartek Grzybowski1-0/+49
This adds pytest based unit tests for the service provider. Testing PUT and GET requests is covered within this patch. Change-Id: Id9bcb870b032c6fce64985a5fd501bbd44031f50 Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-15netconf-pnp-simulator: enable NETCONF send/recv message loggingebo20-77/+717
to aid troubleshooting integration with OpenDaylight - Add more integration tests - Defaults to generic subscriber Issue-ID: INT-1516 Change-Id: Ib5bbf4cdbba6cdfee901f6c07dfa195a21cd8bbb Signed-off-by: ebo <eliezio.oliveira@est.tech>
2020-04-15Upgrade netconf-pnp-simulator image tag to 2.8.2Bartek Grzybowski4-4/+4
Change-Id: I430b3c8743d103f5e4bb6396a151495cc31843d6 Issue-ID: INT-1508 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-14Fix integration markdown errors for lintermrichomme11-297/+336
Issue-ID: INT-1523 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I2be0865395b12e1f277834b0c096f5d183cb5056 Signed-off-by: mrichomme <morgan.richomme@orange.com>
2020-04-14netconf-pnp-simulator: normalized image referenceebo2-4/+2
Required change for the forthcoming fix on tox execution in ci-management/jjb/integration/integration-docker.yaml Issue-ID: INT-1124 Change-Id: I70c3351e5cf691a9eaeb7b49ec276d825016e0fa Signed-off-by: ebo <eliezio.oliveira@est.tech>
2020-04-14netconf-pnp-simulator: fix invalid ref to libssh v0.8.8ebo2-6/+5
This version was upgraded to 0.8.9 on 2020-04-09. Fortunately the new 0.9.4 fixes the bug that was forcing us to use the old 0.8.x Issue-ID: INT-1124 Change-Id: I6dacac8925af047d2e5342a76da6eb221074ddd9 Signed-off-by: ebo <eliezio.oliveira@est.tech>
2020-04-10remove CLI from https xfail listmrichomme1-2/+0
Even if CLI got a NO GO for frankfurt, docker update is planned to fix security issues for frankfurt As a consequence, CLI must be removed from the xfail list Issue-ID: INT-1480 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I78dccd2bdabe05515ff8ab64d30e9e5d6f97e74b
2020-04-10Update pnf-sw-upgrade module to latest engine v2.8.1ebo4-12/+13
- Using loguru to follow new recommend standard - Renamed Yang model filename to comply with https://tools.ietf.org/html/rfc6020#section-5.2 - Renamed initialization data to reflect the target datastore Issue-ID: INT-1516 Signed-off-by: ebo <eliezio.oliveira@est.tech> Change-Id: Ifde9e832b6a308dc918e3a84e03bfd43ad0f9b63
2020-04-09Remove old PNF simulatorBartosz Gardziejewski238-16902/+0
Issue-ID: INT-1517 Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com> Change-Id: I235b0fdf12b265a256c371126e218826e74a9133
2020-04-08netconf-pnp-simulator: convenient TLS and SSH configurationebo25-485/+936
- Simple SSH and TLS configuration. Instead of specific Netopeer2 XML configuration files, the user only needs to provide: For SSH: id_XXX.pub For TLS: server_key.pem, server_cert.pem, and ca.pem - SSH and TLS can be reconfigured at runtime by running /opt/bin/reconfigure-ssh.sh and /opt/bin/reconfigure-tls.sh respectively - Improved log readability by using zlog (on C applications) and loguru for Python See the updated documentation under ../docs for more information. Issue-ID: INT-1516 Change-Id: I21052d2524f0610c6197875a544113cce1a02787 Signed-off-by: ebo <eliezio.oliveira@est.tech>
2020-04-06Remove deprecated options from virtualenv invocationBartek Grzybowski2-3/+3
--no-site-packages and --distribute are marked DEPRECATED and retained only for backward compatibility so removing. Change-Id: I3cc66b5c09363d5b982537cc28b8f66609743121 Issue-ID: INT-1508 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-02Upgrade netconf-pnp-simulator tag to 2.6.2 for netconf-pnp-pmshBartek Grzybowski1-1/+1
Tag 2.6.1 is no longer available. Change-Id: I5a2cb51d21b4c6d75aff387e87976ede184a92b2 Issue-ID: INT-1508 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-01Upgrade netconf-pnp-simulator tag to 2.6.2 for ems-netconf-swmBartek Grzybowski1-1/+1
Tag 2.6.1 is no longer available. Change-Id: Ia2ce3f2d1d25e5f941cd2b49ed213445960e8a04 Issue-ID: INT-1508 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-03-31Grant a waiver for SO 30277Krzysztof Opasiak1-0/+2
As discussed during SECCOM call on 31.03.2020 SO team pushed hard to finialize AAF integration in F but failed due to AAF issues. Per TSC decision they should be granted a waiver as a project which has been impacted by AAF Issue-ID: OJSI-138 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com> Change-Id: I46028f2d3de80f5ca7dc274cf6af26000b766f32
2020-03-25Add 'build' target for 'sslendpoints' projectBartek Grzybowski1-0/+5
To follow a common protocol of testing Golang based applications in CI we need a 'build' target for doing a local (non-docker) build to verify 'go build' routine. It's however not added to "all" target as that one already references docker based build by default. Change-Id: I2e380ef09a1ae18456d7288f853d085617149338 Issue-ID: SECCOM-261 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-03-25Reduce cyclomatic complexityPawel Wieczorek3-17/+132
Moving CSV data conversion and "expected failure" filtering away from main function made testing these features easier. Utility behaviour remained unchanged. Issue-ID: SECCOM-261 Change-Id: I4cabfc7b352434c84a613c02f44af3c9630be970 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-25Add "expected failure" support to non-SSL NodePort scannerPawel Wieczorek2-3/+61
This patch makes scanner compatible with its shell predecessor. The same "expected failure" list format is used i.e. # Comment line; will be ignored SERVICE1 NODEPORT1 SERVICE2 NODEPORT2 Single space character is used as a field separator. Issue-ID: SECCOM-261 Change-Id: Ieedd4e98a83ffe242c695133fdf7342e17efa9a2 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-25Run port scanPawel Wieczorek4-2/+78
Issue-ID: SECCOM-261 Change-Id: I465282a8793191c45d288284a127e80e1fecf513 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-25Add IP addresses filteringPawel Wieczorek3-0/+148
Each node might be described with 3 types of addresses [1]. Some providers also use node annotations [2] for assigned addresses. This patch filters out all IP addresses from nodes list. External IPs take precedence over internal ones. The first address on the extracted slice will be later used to run the scan on. This behaviour could be later modified to e.g. loop over all extracted IP addresses (if scan fails). [1] https://kubernetes.io/docs/concepts/architecture/nodes/#addresses [2] https://github.com/rancher/rke/blob/master/k8s/node.go#L18 Issue-ID: SECCOM-261 Change-Id: Ifd094447f778da378dfe1aee765f552b6ebd669f Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-25Add temporary "make" target for automated testing compatibilityPawel Wieczorek1-0/+4
Utility "sslendpoints" and related packages make use of idiomatic Go testing commands, i.e. go test [./...]. Thanks to Go Modules [1] nothing else is needed to run internal tests for this tool. Unfortunately it's not the case for all Go-based Integration tools. In order to use a single automated verification script in CI additional "make" target is required. It will provide temporary compatibility layer with utilities setting up test environment on their own with "make test" target. This patch should be reverted upon removal of such cases (currently: after dropping "../k8s/check" tool in favour of Aquasec solution). [1] https://blog.golang.org/using-go-modules (see "Adding a dependency" test execution explanation) Issue-ID: INT-1498 Change-Id: I14c83f7f193c7688590366db988ff02c13c036a4 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-25Add NodePorts filtering with development environment basisPawel Wieczorek11-5/+592
This patch has not made "sslendpoints" fully compatible with "check_for_nonssl_endpoints.sh" script yet. It sets up basic development environment for Golang-based checkers, though. Tool output will be added to the README after reaching full compatibility with previous (script) version. Development environment brought by this patch is heavily based on: https://github.com/SamsungSLAV/boruta Issue-ID: SECCOM-261 Change-Id: I8f035b63bea13785c40971ede5fdbbc9b6810168 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-25Increase verifiability of security checksPawel Wieczorek2-0/+45
This patch introduces a series of patches that will provide tools which will succeed current security check scripts. Its two main reasons are: * increasing tools verifiability by providing internal tests, * improving "expected failure" support by suppressing carefully selected set of special cases. Each tool will use following directory structure (generated with "tree -a --charset=ascii" command): . `-- check_module |-- Dockerfile |-- .dockerignore |-- .gitignore |-- go.mod |-- main.go |-- Makefile |-- README |-- README.rst -> README `-- submodule |-- submodule.go `-- submodule_test.go This will allow using Go Modules mechanism within its limitations [1] for "non-go-get-able modules" [2][3][4] - also in case of separating code into several modules used by multiple "check modules", e.g. . |-- common | |-- common.go | |-- common_test.go | `-- go.mod `-- check_module |-- go.mod `-- ... It would require migration from separate Dockerfiles to a single one (multi-stage), though. Provided Makefiles are intended to simplify local development (Docker-less building) and container images preparation. READMEs clarify utility requirements and usage - file without extension is for VCS reference, symlink for proper syntax rendering. [1] https://github.com/golang/go/wiki/Modules#is-it-possible-to-add-a-module-to-a-multi-module-repository [2] https://github.com/golang/go/wiki/Modules#can-i-work-entirely-outside-of-vcs-on-my-local-filesystem [3] https://github.com/golang/go/issues/26645#issuecomment-408572701 [4] https://www.dim13.org/go-get-cgit Issue-ID: SECCOM-261 Change-Id: I48eeeda66bd5570d249e96e101e431e6bab75cb3 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-24Add the provisioning management service provider for 5G NRM CMHuang Cheng9-0/+392
Issue-ID: INT-1387 Signed-off-by: Huang Cheng <duke.huangcheng@huawei.com> Change-Id: I23bda3ec2a31569d4857b2f16b9a607c64abd9f0
2020-03-23Add script and patch to build CBA file to support PNF SW upgradeEnbo Wang9-0/+530
Change-Id: I8b0155a0a6022d7b6d172c1b46d1b7d189fcbe8a Issue-ID: INT-1210 Signed-off-by: Enbo Wang <wangenbo@huawei.com>
2020-03-20Set of fixes for pnfsimulator startupTomasz Golabek3-1/+4
* v0.7.7 of netopeer used * SSLAuthenticationHelper marked as primary bean to avoid duplicated-bean exception * spring props properly mounted into container Change-Id: Ib6bb32f32a7f60786901ffbf592b1a26b5cb1cbf Issue-ID: INT-1320 Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
2020-03-19Add services with waiver to expected failures list for non-SSL endpoints testsPawel Wieczorek1-0/+6
Issue-ID: INT-1480 Change-Id: Iabd7932e0eb8f8981d064aee0f4d8c44df65a379 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-19Filter out only open non-SSL portsPawel Wieczorek1-1/+1
This patch ignores closed and filtered ports from scan results. It is intended to keep "expected failure" list minimal. Issue-ID: INT-1480 Change-Id: Idb93cf4e19284bc121aa45ea950d28405c29e222 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-14EMS simulator extension to support netconf interaction with CDSYaoguang Wang7-0/+364
Issue-ID: INT-1211 Signed-off-by: Yaoguang Wang <sunshine.wang@huawei.com> Change-Id: I5a7724e6cbfab81eeb3299c88f995c3cf9ea71ec
2020-03-12Fix regex for http xfail listmrichomme1-1/+1
in CI we got an error sed: unsupported command o due to space management in the sed command Issue-ID: INT-1480 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I44c6ecd7c47ec02b76c7932bb86de0a58726d93d
2020-03-12Unify expected failures lists naming conventionPawel Wieczorek1-1/+1
List of expected failures for non-SSL services test has not been renamed together with corresponding check script and might have been confusing. Issue-ID: INT-1480 Change-Id: I4f88a09ddb90a14500498892f1fda99e1c3febf0 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-12Add upstream services to expected failures list for non-SSL endpoints testsPawel Wieczorek1-0/+4
Issue-ID: INT-1480 Change-Id: I755a3e65897f94e3f42f27bbf798c9bcd9c2868f Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-12Added python3 and Updated netopeer imagerajendrajaiswal4-5/+10
Change-Id: Ib7c21353cff267b847a4d1d7fdcb322e22772062 Issue-ID: INT-1312 Signed-off-by: rajendrajaiswal <rajendra.jaiswal@ericsson.com>
2020-03-11netconf-pnp-simulator: make PYTHONPATH always globally definedebo12-4/+359
Add IT using ncclient and tox Issue-ID: INT-1124 Change-Id: I560d4fd2468ac93f8ead36062b2e316821af8d07 Signed-off-by: ebo <eliezio.oliveira@est.tech>
2020-03-11Rename white list to xfail list to clarify the role of the listmrichomme1-1/+1
to be consistent with xfail lists introduced in security tests by Pawel Wieczorek [1] Issue-ID: INT-1435 [1]: https://gerrit.onap.org/r/c/integration/+/103444 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I5345607931e443f3335f34823c5cd80290425a45 Signed-off-by: mrichomme <morgan.richomme@orange.com>
2020-03-10Drop filtering out services recognized as HTTPPawel Wieczorek1-9/+9
This patch extends tool used to detect plain HTTP ports to report all non-SSL endpoints. Previously it omitted services not recognized as HTTP. Naming changes were made to reflect purpose of this tool better. Issue-ID: INT-1480 Change-Id: I58a152022d48121bf4b9c6180ddc820dd4a79805 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-10Add expected failures list for HTTP endpoints testsPawel Wieczorek2-11/+55
This patch is heavily based on previous work by Morgan Richomme <morgan.richomme@orange.com> (Change-Id: Ibaed4c5c0e5ae179af0ae317e543c1efdc9ddef2) It is intended to suppress failure reports on known plain HTTP endpoints. Introduced list of "expected failures" (or "xfail" for short) will be shrunk after resolving tickets related to INT-1480 and this patch will be eventually reverted. Issue-ID: INT-1480 Change-Id: I4edbf3efaf66bfa2dbe2f265983eb0a27048ed4e Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-10Add a white list for jdwp testsmrichomme2-42/+95
The port scanned can be the default redis port. A white list must be included to avoid false positive. Open quesiton, should this list be passed as argument? It is relatively static so for the moment, I created a list to exclude through grep -V the false positive Issue-ID: INT-1435 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: Ibaed4c5c0e5ae179af0ae317e543c1efdc9ddef2 Signed-off-by: mrichomme <morgan.richomme@orange.com>
2020-03-06Fix linter issues in soutils.py vcp librabryBartek Grzybowski1-10/+10
Change-Id: I6adaa992fe9c2411025eb28edafef83b506bac29 Issue-ID: INT-1427 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-03-06Fix Python linting issues in Python scriptsBartek Grzybowski4-50/+46
Fixed pylint issues for categories trailing-whitespace, trailing-newlines, syntax-error, unused-import. Change-Id: Iccbdb0c9538a6b8299c0517bafa1ec1be30f07cd Issue-ID: INT-1427 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-03-05Fix Python linting issues in Python scriptsBartek Grzybowski8-17/+16
Fixed pylint issues for categories len-as-condition, using-constant-test, undefined-variable and reimported. Change-Id: Idad710958c3ca0ac6da78fb4709da03e5f079b34 Issue-ID: INT-1427 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-03-05Fix linting issues in check_for_ingress_and_nodeports.pyBartek Grzybowski1-6/+6
Change-Id: Ic0d2a32a964a4cf5ff1580ffd06103c450a0e8b0 Issue-ID: INT-1427 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-03-05Supress pylint warnings for undefined variablesBartek Grzybowski5-8/+8
'cmp', 'file' and 'unicode' functions are Python 2 specific. Change-Id: I30fa091ef157453a328ab40e4186c30e5ed1b3a1 Issue-ID: INT-1427 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>