aboutsummaryrefslogtreecommitdiffstats
path: root/test/security
AgeCommit message (Collapse)AuthorFilesLines
2023-04-24[Secrity] Add missing templates files into packageMichal Jagiello2-1/+4
After migration to use pyproject.toml I forget to add templates into package. There is also change needed to use new package name on jinja env loading Issue-ID: TEST-394 Signed-off-by: Michal Jagiello <michal.jagiello@t-mobile.pl> Change-Id: Ia9f2a26f00f83f92a9a6d01f25e663bddf1fa098
2023-04-21Fix security test case scriptMichal Jagiello1-1/+1
After change of script I didn't change the test case execution (sadly) Issue-ID: TEST-394 Signed-off-by: Michal Jagiello <michal.jagiello@t-mobile.pl> Change-Id: Iec8118e06ccc51e17107e8965eec8464e334d06f
2023-04-19Fix security versions scriptMichal Jagiello19-310/+815
That script was usused on security versions tests, so I updated it with the latest changes from repo which was really used, created needed files and after we merge it we could use that on security tests. Issue-ID: TEST-394 Signed-off-by: Michal Jagiello <michal.jagiello@t-mobile.pl> Change-Id: I8e5daa7d43e2723bbe3308cf85b1cae2b2f587ad
2023-04-18Pin tox.ini basepython to 3.8Marek Szwałkiewicz2-2/+2
Issue-ID: INT-2222 Change-Id: Id4577f676d914b1925949586771880fde1fa32e1 Signed-off-by: Marek Szwałkiewicz <marek.szwalkiewicz@external.t-mobile.pl>
2023-04-17Changes on security versions scriptMichal Jagiello1-3/+47
Limit namespace to ONAP Disable istio sidecars check by default Issue-ID: INT-2193 Signed-off-by: Michal Jagiello <michal.jagiello@t-mobile.pl> Change-Id: Ie307ecca1eb88a80582172ce292113217944c9ff
2022-03-29[STRIMZI_CA] Add strimzi ca to cert checkefiacor1-1/+2
Signed-off-by: efiacor <fiachra.corcoran@est.tech> Change-Id: I246820e8d101834cbee43300a818c68dc03b2f14 Issue-ID: INT-2097
2022-02-02[CERT] Update check_certificate testmrichomme1-1/+1
The test was not working since the update of the kubernetes version nobody remarked it.. In fact Ingress have been promoted and the kubernetes client API changed accordinggly Issue-ID: TEST-381 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I3a4691be7c9ffbf385e851d905181e4b5ec1f2f8
2021-09-03[SECURITY] Fix waiver management of check_for_nonssl_ports testmrichomme1-2/+2
There was a nit in the bash script preventing the cfail list to be taken into account Issue-ID: TEST-360 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: Id8aec2b091cd00eee1c018dc529e1b38bb050275
2021-03-02[TESTS] Fix versionsmorganrol1-6/+10
an exception is no more caught and triggers an error when running versions Issue-ID: TEST-312 Signed-off-by: morganrol <morgan.richomme@orange.com> Change-Id: Ib787e6bf6359abc6df2732c27ebd7ac7ab9389af Signed-off-by: morganrol <morgan.richomme@orange.com>
2021-01-18Fix version test in CImrichomme1-7/+11
Issue-ID: INT-1834 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I032ad1234036c5671722456995d1059a8a493cfb
2021-01-04Adapt kube config retrieval for certificate checkmrichomme1-1/+4
In case of test from inside the cluster, the k8s credentials must be retrieved using the k8s python client method load_incluster_config Issue-ID: INT-1818* Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: If3eb2de2099f88443ae4e36a404423b2e57769b8
2020-11-25Make initial cluster setup more robustPawel Wieczorek1-1/+2
Action "reset" triggers cluster shutdown attempt which will cause failure of subsequent calls for cluster status. Issue-ID: INT-1571 Change-Id: I4e607358fbeb910a250ac038cfc43682fb94bdea Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-11-25Unify variable initializationPawel Wieczorek1-1/+1
It is not possible to know "expected fails" list length upfront, hence there is no need to call "make" on "xfails" map - there are no optimization profits. Issue-ID: INT-1582 Change-Id: I0e21d83098359359d17661e6265760d7e95739b9 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-11-25Add namespace filtering to SSL endpoints checkPawel Wieczorek1-1/+8
Utility "sslendpoints" now supports scanning only selected Kubernetes cluster namespace. To do so, add "-namespace" flag with namespace of your choice as its argument to the executed command. Default behavior remained unchanged, i.e. scan covers all namespaces. Issue-ID: INT-1582 Change-Id: If5534b76bca94248a5003d735c25328648e478a1 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-11-25Remove build directory nestingPawel Wieczorek1-3/+2
This patch also removes unnecessary directory creation. Command: 'go build -o "${BINARIES}"' creates required file tree on its own. Issue-ID: SECCOM-261 Change-Id: I6b492a2d5f61ce6e139bfe718256357c9d343a6b Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-11-25Simplify composite literalsPawel Wieczorek1-50/+50
Utility "gopls" used to analyse Go source did not support code simplifications as of writing "sslendpoints" tool [1]. Simplifying composite literals is now supported [2]. [1] https://github.com/golang/go/issues/37221 [2] https://github.com/golang/tools/commit/e428a8eca3e395a1b415fd3aee1610aabb61b8b5 Issue-ID: SECCOM-261 Change-Id: I757ff8aefed4c7653f3992f9c1b7b0f3e6c10ea3 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-11-05Display waiver content for the security testsVirginie2-2/+2
Issue-ID: INT-1764 Signed-off-by: Virginie <virginie.lefilleul@orange.com> Change-Id: I2afc3cca2bde4ff8d7b9337c548f7b48af813fc0 Signed-off-by: Virginie <virginie.lefilleul@orange.com>
2020-11-04Display waiver content for the security testsVirginie2-0/+16
Issue-ID: INT-1764 Signed-off-by: Virginie <virginie.lefilleul@orange.com> Change-Id: I0efaa815112b30ad5c9faeeeafecaf7109a9162a Signed-off-by: Virginie <virginie.lefilleul@orange.com>
2020-09-14Add timeout on SSL internal cert retrievalmrichomme2-0/+135
In case of SSL issues, the socket timeout is set to 600s by default as we are scanning a liitle bit stupdidly - we try on all the internal ports..it may take a long time if we cumulate the different timeouts. Moreover a new error may occur socker.gaiaerror on internal scans Issue-ID: INT-1570 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: Ia0e1c7bb133565d6179afa155f6c299a5e012764 Signed-off-by: mrichomme <morgan.richomme@orange.com>
2020-09-07Remove old SECCOM waiver lists sourcePawel Wieczorek4-28/+0
SECCOM waivers are now located in "integration/seccom" repository. Issue-ID: INT-1710 Change-Id: I2598c3d848338a4527c5c49b38b7c9f150d45abe Depends-On: I5f0f11307dd259d2a66a2916ac4ac01e27177b29 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-09-02check_certificates: create result dir if neededmrichomme1-0/+4
an arg allows to specify the results dir but if the dir path is not valid, we got an error try to create the dir before running the test Issue-ID: INT-1570 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I32363af1f066dc5e5a0adf45619fb4e1a9052a7d Signed-off-by: mrichomme <morgan.richomme@orange.com>
2020-08-31Add support for detecting Java 8Pawel Wieczorek1-2/+4
For Java 11 there are four ways of checking Java binary version: * -version print product version to the error stream and exit * -showversion print product version to the error stream and continue * --version print product version to the output stream and exit * --show-version print product version to the output stream and continue For Java 8 only error stream options are available. There is no support for output stream (double-hyphenated) options. This patch extends list of executed commands for binary version detection. Java 8 presence will now be shown in results instead of being reported as an error. Issue-ID: INT-1601 Change-Id: I1b538bc1f0826f6000fedb08860d12c15fe2fc14 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-08-26Add MANIFEST.in to include j2 file in the python packagemrichomme3-6/+4
Not sure it is the best way, maybe it can be done with setup.cfg.. it seems to be OK Issue-ID: INT-1570 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I7a1ddefba0ec0bbe35a5a51baebdf4a715a4f131 Signed-off-by: mrichomme <morgan.richomme@orange.com>
2020-08-20Reset security xfail list for Guilinmrichomme1-14/+16
Issue-ID: INT-1695 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I6885cdbd4354add533999af6b43de267b888a59a
2020-08-10Drop using symlinks for documentation markup renderingPawel Wieczorek4-182/+180
Keeping only symlinks as the markup indicator does not trigger CI on relevant patches changing documentation contents (there's no change in symlink). This can be resolved by dropping symlinks usage entirely. Sphinx and RTD aren't going anywhere anytime soon. To make sure all symlinks were replaced following one-liner was used: $ find . -type l -name "*.rst" -exec readlink -e {} \; \ | xargs -I% git mv -f %{,.rst} which finds all the symlinks in the repo with "*.rst" suffix, then reads which file they link to and finally replaces given symlink with that file. This solution was suggested by: Bartek Grzybowski <b.grzybowski@partner.samsung.com> Issue-ID: INT-1672 Change-Id: I120e216b0b48032bb7b80c23cad799cd6f7cca53 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-07-28Import upstream component version inspection toolPawel Wieczorek16-0/+1360
This patch adds utility to check versions of binaries available in Docker containers run on Kubernetes cluster. It has been contributed by: kkkk-k <kkkk.k@samsung.com> Several minor changes were made to comply with ONAP CI linter rules. Issue-ID: INT-1571 Change-Id: Id0e4b557212dec1bf8d2bac580968d69e2cf5595 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-07-09Update release notes for Frankfurt Maintenance releasemrichomme1-1/+17
update testsuite 1.6.4 fix foc links (submodules lead to broken links) Issue-ID: INT-1652 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: Id83b1b589216317cd755f9d2eb844c6dfb1029c9
2020-07-06Fix check certification python pakagingmrichomme2-0/+2
- include jinja2 tempalte (__init.py) - include xfail list (scripts in setup.cfg) Issue-ID: INT-1570 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I08d1229c939b64aa8e920f75ea05a8aa0404a4c5
2020-07-03Initiate check certificate validity testmrichomme9-0/+686
Issue-ID: INT-1570 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I9794ec17a254ac21e87e3a251b6cad849a763742 Signed-off-by: mrichomme <morgan.richomme@orange.com>
2020-07-02Create runtime setup for the scriptBartek Grzybowski4-5/+44
Change-Id: I1a1207173b065c3b88b4b62e134c2fda33e0e6ec Issue-ID: INT-1642 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-07-02Fix --conf option validationBartek Grzybowski1-7/+9
Native Argparse library facility is used to validate the --conf option value. In case of invalid value error msg is printed together with usage info. Change-Id: I43aee892699c8238176b19a5148d217b3d16102c Issue-ID: INT-1643 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-07-02Add compare NodePort and Ingress scanLucjan Bryndza1-6/+75
Add compare NodePort and Ingress scan to the ONAP port scanner. Extra option --scan-and-compare scan cluster using NodePort and Ingress and finally compare the results of both scans. Change-Id: Ie480f068c2bda530c8be76c3d8d70d92f7c5b392 Issue-ID: OOM-2437 Signed-off-by: Lucjan Bryndza <l.bryndza@samsung.com>
2020-07-01Fix ingress default http and https portsLucjan Bryndza1-2/+4
Change ingress http and https port in the ingress controller default port configuration. Signed-off-by: Lucjan Bryndza <l.bryndza@samsung.com> Issue-ID: OOM-2434 Change-Id: Ic354510006d9f2d5d56f377d8f628e55a1a4b869 Signed-off-by: Lucjan Bryndza <l.bryndza@samsung.com>
2020-05-08Add missing dependency for port scanningPawel Wieczorek1-0/+7
Issue-ID: SECCOM-261 Change-Id: Id4d14cf0997310b7e039fe3f5e18ea72a4f3d71c Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-05-08Use correct nmap filtersPawel Wieczorek1-1/+11
Both closed and filtered ports should be droppped from scan results to maintain compatibility with "check_for_nonssl_endpoints.sh" script. Issue-ID: SECCOM-261 Change-Id: Ic422bebf6e46bcc42a3e5198e7702bb8b901287f Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-04-27Exclude VFC-redis from xfail listmrichomme1-0/+1
Issue-ID: INT-1564 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I32d9e25e4d4d0bfab7fdfa5979db266a0826604c Signed-off-by: mrichomme <morgan.richomme@orange.com>
2020-04-10remove CLI from https xfail listmrichomme1-2/+0
Even if CLI got a NO GO for frankfurt, docker update is planned to fix security issues for frankfurt As a consequence, CLI must be removed from the xfail list Issue-ID: INT-1480 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I78dccd2bdabe05515ff8ab64d30e9e5d6f97e74b
2020-03-31Grant a waiver for SO 30277Krzysztof Opasiak1-0/+2
As discussed during SECCOM call on 31.03.2020 SO team pushed hard to finialize AAF integration in F but failed due to AAF issues. Per TSC decision they should be granted a waiver as a project which has been impacted by AAF Issue-ID: OJSI-138 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com> Change-Id: I46028f2d3de80f5ca7dc274cf6af26000b766f32
2020-03-25Add 'build' target for 'sslendpoints' projectBartek Grzybowski1-0/+5
To follow a common protocol of testing Golang based applications in CI we need a 'build' target for doing a local (non-docker) build to verify 'go build' routine. It's however not added to "all" target as that one already references docker based build by default. Change-Id: I2e380ef09a1ae18456d7288f853d085617149338 Issue-ID: SECCOM-261 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-03-25Reduce cyclomatic complexityPawel Wieczorek3-17/+132
Moving CSV data conversion and "expected failure" filtering away from main function made testing these features easier. Utility behaviour remained unchanged. Issue-ID: SECCOM-261 Change-Id: I4cabfc7b352434c84a613c02f44af3c9630be970 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-25Add "expected failure" support to non-SSL NodePort scannerPawel Wieczorek2-3/+61
This patch makes scanner compatible with its shell predecessor. The same "expected failure" list format is used i.e. # Comment line; will be ignored SERVICE1 NODEPORT1 SERVICE2 NODEPORT2 Single space character is used as a field separator. Issue-ID: SECCOM-261 Change-Id: Ieedd4e98a83ffe242c695133fdf7342e17efa9a2 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-25Run port scanPawel Wieczorek4-2/+78
Issue-ID: SECCOM-261 Change-Id: I465282a8793191c45d288284a127e80e1fecf513 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-25Add IP addresses filteringPawel Wieczorek3-0/+148
Each node might be described with 3 types of addresses [1]. Some providers also use node annotations [2] for assigned addresses. This patch filters out all IP addresses from nodes list. External IPs take precedence over internal ones. The first address on the extracted slice will be later used to run the scan on. This behaviour could be later modified to e.g. loop over all extracted IP addresses (if scan fails). [1] https://kubernetes.io/docs/concepts/architecture/nodes/#addresses [2] https://github.com/rancher/rke/blob/master/k8s/node.go#L18 Issue-ID: SECCOM-261 Change-Id: Ifd094447f778da378dfe1aee765f552b6ebd669f Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-25Add temporary "make" target for automated testing compatibilityPawel Wieczorek1-0/+4
Utility "sslendpoints" and related packages make use of idiomatic Go testing commands, i.e. go test [./...]. Thanks to Go Modules [1] nothing else is needed to run internal tests for this tool. Unfortunately it's not the case for all Go-based Integration tools. In order to use a single automated verification script in CI additional "make" target is required. It will provide temporary compatibility layer with utilities setting up test environment on their own with "make test" target. This patch should be reverted upon removal of such cases (currently: after dropping "../k8s/check" tool in favour of Aquasec solution). [1] https://blog.golang.org/using-go-modules (see "Adding a dependency" test execution explanation) Issue-ID: INT-1498 Change-Id: I14c83f7f193c7688590366db988ff02c13c036a4 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-25Add NodePorts filtering with development environment basisPawel Wieczorek11-5/+592
This patch has not made "sslendpoints" fully compatible with "check_for_nonssl_endpoints.sh" script yet. It sets up basic development environment for Golang-based checkers, though. Tool output will be added to the README after reaching full compatibility with previous (script) version. Development environment brought by this patch is heavily based on: https://github.com/SamsungSLAV/boruta Issue-ID: SECCOM-261 Change-Id: I8f035b63bea13785c40971ede5fdbbc9b6810168 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-25Increase verifiability of security checksPawel Wieczorek2-0/+45
This patch introduces a series of patches that will provide tools which will succeed current security check scripts. Its two main reasons are: * increasing tools verifiability by providing internal tests, * improving "expected failure" support by suppressing carefully selected set of special cases. Each tool will use following directory structure (generated with "tree -a --charset=ascii" command): . `-- check_module |-- Dockerfile |-- .dockerignore |-- .gitignore |-- go.mod |-- main.go |-- Makefile |-- README |-- README.rst -> README `-- submodule |-- submodule.go `-- submodule_test.go This will allow using Go Modules mechanism within its limitations [1] for "non-go-get-able modules" [2][3][4] - also in case of separating code into several modules used by multiple "check modules", e.g. . |-- common | |-- common.go | |-- common_test.go | `-- go.mod `-- check_module |-- go.mod `-- ... It would require migration from separate Dockerfiles to a single one (multi-stage), though. Provided Makefiles are intended to simplify local development (Docker-less building) and container images preparation. READMEs clarify utility requirements and usage - file without extension is for VCS reference, symlink for proper syntax rendering. [1] https://github.com/golang/go/wiki/Modules#is-it-possible-to-add-a-module-to-a-multi-module-repository [2] https://github.com/golang/go/wiki/Modules#can-i-work-entirely-outside-of-vcs-on-my-local-filesystem [3] https://github.com/golang/go/issues/26645#issuecomment-408572701 [4] https://www.dim13.org/go-get-cgit Issue-ID: SECCOM-261 Change-Id: I48eeeda66bd5570d249e96e101e431e6bab75cb3 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-19Add services with waiver to expected failures list for non-SSL endpoints testsPawel Wieczorek1-0/+6
Issue-ID: INT-1480 Change-Id: Iabd7932e0eb8f8981d064aee0f4d8c44df65a379 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-19Filter out only open non-SSL portsPawel Wieczorek1-1/+1
This patch ignores closed and filtered ports from scan results. It is intended to keep "expected failure" list minimal. Issue-ID: INT-1480 Change-Id: Idb93cf4e19284bc121aa45ea950d28405c29e222 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-03-12Fix regex for http xfail listmrichomme1-1/+1
in CI we got an error sed: unsupported command o due to space management in the sed command Issue-ID: INT-1480 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I44c6ecd7c47ec02b76c7932bb86de0a58726d93d
2020-03-12Unify expected failures lists naming conventionPawel Wieczorek1-1/+1
List of expected failures for non-SSL services test has not been renamed together with corresponding check script and might have been confusing. Issue-ID: INT-1480 Change-Id: I4f88a09ddb90a14500498892f1fda99e1c3febf0 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>