summaryrefslogtreecommitdiffstats
path: root/version-manifest
diff options
context:
space:
mode:
authorGary Wu <gary.i.wu@huawei.com>2017-09-06 13:12:40 -0700
committerGary Wu <gary.i.wu@huawei.com>2017-09-06 13:12:40 -0700
commit6fd61b5fa717862fa554fa4c4a076f56be3aaac1 (patch)
treecb4d625cc8ea71c251c7b97c20a7014585d6e1c5 /version-manifest
parent06f07c4d7d34e707127c082ffb0a6c62c21c5929 (diff)
Don't warn on artifacts with same groupId
Modify version-manifest to skip warnings on artifacts that are in the same groupId as the project being checked. Change-Id: I14afdfbba4b175e0158cdf91a1aac7d1dbc34da9 Issue-id: INT-124 Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
Diffstat (limited to 'version-manifest')
-rw-r--r--version-manifest/src/main/java/org/onap/integration/versionmanifest/VersionCheckMojo.java27
1 files changed, 18 insertions, 9 deletions
diff --git a/version-manifest/src/main/java/org/onap/integration/versionmanifest/VersionCheckMojo.java b/version-manifest/src/main/java/org/onap/integration/versionmanifest/VersionCheckMojo.java
index 325ca5811..5909c74f5 100644
--- a/version-manifest/src/main/java/org/onap/integration/versionmanifest/VersionCheckMojo.java
+++ b/version-manifest/src/main/java/org/onap/integration/versionmanifest/VersionCheckMojo.java
@@ -69,8 +69,8 @@ public class VersionCheckMojo extends AbstractMojo {
throw new MojoExecutionException(e.getMessage());
}
- log.info("Manifest version: " + gitProps.getProperty("git.remote.origin.url") + " "
- + gitProps.getProperty("git.commit.id") + " " + gitProps.getProperty("git.build.time"));
+ log.info("Manifest version: " + gitProps.getProperty("git.build.time") + " "
+ + gitProps.getProperty("git.commit.id") + " " + gitProps.getProperty("git.remote.origin.url"));
log.info("");
@@ -100,21 +100,28 @@ public class VersionCheckMojo extends AbstractMojo {
final MavenProject parent = project.getParent();
if (parent != null) {
log.debug("Parent: " + parent);
- actualVersions.put(parent.getGroupId() + ":" + parent.getArtifactId(), parent.getVersion());
+ // don't warn within the same groupId
+ if (!project.getGroupId().equals(parent.getGroupId())) {
+ actualVersions.put(parent.getGroupId() + ":" + parent.getArtifactId(), parent.getVersion());
+ }
} else {
log.debug("No parent");
}
for (Dependency dep : project.getDependencies()) {
log.debug("Dependency: " + dep.toString());
- actualVersions.put(dep.getGroupId() + ":" + dep.getArtifactId(), dep.getVersion());
+ // don't warn within the same groupId
+ if (!project.getGroupId().equals(dep.getGroupId())) {
+ actualVersions.put(dep.getGroupId() + ":" + dep.getArtifactId(), dep.getVersion());
+ }
}
final Set<String> mismatches = new TreeSet<>();
final Set<String> missingArtifacts = new TreeSet<>();
- for (Entry<String, String> actualVersion : actualVersions.entrySet()) {
- String artifact = actualVersion.getKey();
+ for (Entry<String, String> actualVersionEntry : actualVersions.entrySet()) {
+ String artifact = actualVersionEntry.getKey();
+ String actualVersion = actualVersionEntry.getValue();
String expectedVersion = expectedVersions.get(artifact);
if (expectedVersion == null) {
if (groupIdPrefixes.stream().anyMatch(prefix -> artifact.startsWith(prefix))) {
@@ -144,17 +151,19 @@ public class VersionCheckMojo extends AbstractMojo {
log.warn(String.format(format, artifact, actualVersion, expectedVersion));
}
}
+ log.warn("");
}
- log.info("");
- if (!missingArtifacts.isEmpty()) {
+ if (missingArtifacts.isEmpty()) {
+ log.debug("No artifacts found missing in the version manifest");
+ } else {
log.warn("The following dependencies are missing in the version manifest:");
for (String artifact : missingArtifacts) {
String actualVersion = actualVersions.get(artifact);
log.warn(String.format(format, artifact, actualVersion, "?"));
}
+ log.warn("");
}
- log.info("");
}
}