Reduce cyclomatic complexity

Moving CSV data conversion and "expected failure" filtering away from
main function made testing these features easier. Utility behaviour
remained unchanged.

Issue-ID: SECCOM-261
Change-Id: I4cabfc7b352434c84a613c02f44af3c9630be970
Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>

1 files changed, 31 insertions, 0 deletions

diff --git a/test/security/sslendpoints/ports/ports.go b/test/security/sslendpoints/ports/ports.go
index a80fb782c..dae7dbec7 100644
--- a/test/security/sslendpoints/ports/ports.go
+++ b/test/security/sslendpoints/ports/ports.go
@@ -1,9 +1,40 @@
 package ports
 
 import (
+	"log"
+	"strconv"
+
 	v1 "k8s.io/api/core/v1"
 )
 
+// ConvertNodePorts converts CSV data to NodePorts map.
+func ConvertNodePorts(data [][]string) (map[uint16]string, bool) {
+	result := make(map[uint16]string)
+	for _, record := range data {
+		port, err := strconv.Atoi(record[1])
+		if err != nil {
+			log.Printf("Unable to parse port field: %v", err)
+			continue
+		}
+		result[uint16(port)] = record[0]
+	}
+	return result, len(result) > 0
+}
+
+// FilterXFailNodePorts removes NodePorts expected to fail from map.
+func FilterXFailNodePorts(xfails, nodeports map[uint16]string) {
+	for port, xfailService := range xfails {
+		service, ok := nodeports[port]
+		if !ok {
+			continue
+		}
+		if service != xfailService {
+			continue
+		}
+		delete(nodeports, port)
+	}
+}
+
 // FilterNodePorts extracts NodePorts from ServiceList.
 func FilterNodePorts(services *v1.ServiceList) (map[uint16]string, bool) {
 	nodeports := make(map[uint16]string)