diff options
| author |   Sumapriya Sarvepalli <ss00493505@techmahindra.com> | 2018-09-10 12:55:19 +0530 |
|---|---|---|
| committer | Sumapriya Sarvepalli <ss00493505@techmahindra.com> | 2018-09-10 12:55:19 +0530 |
| commit | cbab66dbbaf971cfb82f3671f175433c69cf2138 (patch) | |
| tree | b7b8685d60fb6ada09c48fd3efec47b2088c3692 /src/main/java/com | |
| parent | 0744faefd619e7eddf0aa66ff84aadb205325bf6 (diff) | |
Sonar major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WgpwGn37JfbyHt0&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/security/DMaaPAAFAuthenticatorImpl.java
Line No:L49 L60 L73
Change-Id: Ie1b5bfe9d8741140757355fa92525dd92d677d75
Issue-ID: DMAAP-756
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Diffstat (limited to 'src/main/java/com')
| -rw-r--r-- | src/main/java/com/att/dmf/mr/security/DMaaPAAFAuthenticatorImpl.java | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/src/main/java/com/att/dmf/mr/security/DMaaPAAFAuthenticatorImpl.java b/src/main/java/com/att/dmf/mr/security/DMaaPAAFAuthenticatorImpl.java index b550373..ed0893d 100644 --- a/src/main/java/com/att/dmf/mr/security/DMaaPAAFAuthenticatorImpl.java +++ b/src/main/java/com/att/dmf/mr/security/DMaaPAAFAuthenticatorImpl.java @@ -46,7 +46,7 @@ public class DMaaPAAFAuthenticatorImpl implements DMaaPAAFAuthenticator { auth = true; } - //System.out.println("role " +role +" user: "+ req.getRemoteUser() +" : auth="+auth); + return auth; } @@ -57,7 +57,7 @@ public class DMaaPAAFAuthenticatorImpl implements DMaaPAAFAuthenticator { String permission = ""; String nameSpace =""; if(topicName.contains(".") && topicName.contains("com.att")) { - //String topic = topicName.substring(topicName.lastIndexOf(".")+1); + nameSpace = topicName.substring(0,topicName.lastIndexOf(".")); } else { @@ -67,12 +67,7 @@ public class DMaaPAAFAuthenticatorImpl implements DMaaPAAFAuthenticator { if(null==nameSpace)nameSpace="com.att.dmaap.mr.ueb"; - /*ErrorResponse errRes = new ErrorResponse(HttpStatus.SC_FORBIDDEN, - DMaaPResponseCode.TOPIC_NOT_IN_AAF.getResponseCode(), "Topic does not exist in AAF" - , null, Utils.getFormattedDate(new Date()), topicName, - null, null, null, null); - - throw new CambriaApiException(errRes);*/ + } permission = nameSpace+".mr.topic|:topic."+topicName+"|"+action; |