4.3.0/6.1.0 deploy-handler - policyVersion as str4.3.0

- external version 4.3.0
- internal version 6.1.0 for code change - no API change

- deployment-handler now expects the policyVersion as semver
  or any string to support for DMaaP MR update notification
  from the new PDP
- changed Dockerfile to use the alpine base image
  to reduce the footprint
- brought the latest packages except zip lib
- added package-lock.json to freeze the dependencies
- latest log4js - change of configuration file format
- fixed call to cloudify API /node-instances
  added &_sort=id to make the pagination consistent
- changed uuid/v4 to uuid.v4() to avoid the deprecation warning
- unit test
  = coverage by nyc now
  = on policy API - assert all expected nock calls are done
- integration testing with the latest policy-handler (DCAEGEN2-1851)
  and the new policy-engine is requested

unit test coverage summary
Statements   : 83.78% ( 1023/1221 )
Branches     : 62.95% ( 333/529 )
Functions    : 84.35% ( 194/230 )
Lines        : 84.18% ( 1011/1201 )

Change-Id: I174aa0b8804af0378755de86be833b0b763ddc1d
Signed-off-by: Alex Shatov <alexs@att.com>
Issue-ID: DCAEGEN2-2085

1 files changed, 4 insertions, 4 deletions

diff --git a/lib/policy.js b/lib/policy.js
index 098a4a4..4d56096 100644
--- a/lib/policy.js
+++ b/lib/policy.js
@@ -1,5 +1,5 @@
 /*
-Copyright(c) 2017-2018 AT&T Intellectual Property. All rights reserved.
+Copyright(c) 2017-2020 AT&T Intellectual Property. All rights reserved.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
@@ -172,7 +172,7 @@ function update_policies(req, res) {
 
                 const latest_policy = policy_update.latest_policies[policy_id];
                 if (!latest_policy || !latest_policy.policy_body
-                || isNaN(latest_policy.policy_body.policyVersion)) {return;}
+                || latest_policy.policy_body.policyVersion == null) {return;}
 
                 if (!deployment.is_deployment_busy && latest_policy.policy_body.policyVersion
                 === (deployed_policy.policy_body && deployed_policy.policy_body.policyVersion)) {return;}
@@ -189,7 +189,7 @@ function update_policies(req, res) {
 
                     const latest_policy = policy_update.latest_policies[policy_id];
                     const policy_body = latest_policy && latest_policy.policy_body;
-                    if (!policy_body || isNaN(policy_body.policyVersion)) {return;}
+                    if (!policy_body || policy_body.policyVersion == null) {return;}
 
                     have_policies = true;
                     deployment.added_policies[policy_filter_id] = deployment.added_policies[policy_filter_id] || {
@@ -241,7 +241,7 @@ function get_policies_from_cloudify(req, res, next) {
                         "policy_versions": {}
                     };
                     const policy = node_instance.runtime_properties.policies[policy_id];
-                    if (policy.policy_body && policy.policy_body.policyVersion) {
+                    if (policy.policy_body && policy.policy_body.policyVersion != null) {
                         deployed_policy.policy_versions[policy.policy_body.policyVersion] = true;
                     }
                     deployed_policy.pending_update = deployed_policy.pending_update || pending_update;