Fix sonar issues

- Use Map instead of LinkedHashMap when possible
- Rename some constants
- Remove some commented lines
- Add logger
- Other minor improvements and refactor

Issue-ID: DCAEGEN2-2636
Signed-off-by: Joanna Jeremicz <joanna.jeremicz@nokia.com>
Change-Id: I7a03cee453b3d254c4ff0fdf51c60a0ae4a61c42

1 files changed, 3 insertions, 3 deletions

diff --git a/mod/bpgenerator/onap/src/test/java/org/onap/blueprintgenerator/service/common/StreamServiceTest.java b/mod/bpgenerator/onap/src/test/java/org/onap/blueprintgenerator/service/common/StreamServiceTest.java
index fe93f5f..d2936da 100644
--- a/mod/bpgenerator/onap/src/test/java/org/onap/blueprintgenerator/service/common/StreamServiceTest.java
+++ b/mod/bpgenerator/onap/src/test/java/org/onap/blueprintgenerator/service/common/StreamServiceTest.java
@@ -279,11 +279,11 @@ class StreamServiceTest {
         return subscribes;
     }
 
-    private Map<String, LinkedHashMap<String, Object>> createInputs() {
-        LinkedHashMap<String, Object> map = new LinkedHashMap<>();
+    private Map<String, Map<String, Object>> createInputs() {
+        Map<String, Object> map = new LinkedHashMap<>();
         map.put("key-1", "obj-1");
 
-        Map<String, LinkedHashMap<String, Object>> mapsMap = new HashMap<>();
+        Map<String, Map<String, Object>> mapsMap = new HashMap<>();
         mapsMap.put("inputs", map);
         return mapsMap;
     }