Fixing sonar and javadoc issues.

minor code refactoring.

Issue-Id:DCAEGEN2-92

Change-Id: I260c16ac8131a2fd3e31221b124a939c757de2d7
Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>

1 files changed, 148 insertions, 146 deletions

diff --git a/src/main/java/org/onap/dcae/commonFunction/EventProcessor.java b/src/main/java/org/onap/dcae/commonFunction/EventProcessor.java
index 1b912cf4..64af1cb8 100644
--- a/src/main/java/org/onap/dcae/commonFunction/EventProcessor.java
+++ b/src/main/java/org/onap/dcae/commonFunction/EventProcessor.java
@@ -20,107 +20,108 @@
 
 package org.onap.dcae.commonFunction;
 
-import java.io.FileReader;
-import java.lang.reflect.Constructor;
-import java.lang.reflect.Method;
-import java.text.SimpleDateFormat;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import com.att.nsa.clock.SaClock;
 import com.att.nsa.logging.LoggingContext;
 import com.att.nsa.logging.log4j.EcompFields;
 import com.google.gson.JsonArray;
 import com.google.gson.JsonParser;
+import org.json.JSONArray;
+import org.json.JSONObject;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
+import java.io.FileReader;
+import java.lang.reflect.Constructor;
+import java.lang.reflect.Method;
+import java.text.SimpleDateFormat;
 import java.util.Arrays;
 import java.util.Date;
 import java.util.HashMap;
 import java.util.TimeZone;
-import java.util.UUID;
-
-import org.json.JSONArray;
-import org.json.JSONObject;
 
 public class EventProcessor implements Runnable {
-	private static final Logger log = LoggerFactory.getLogger(EventProcessor.class);
-
-	private static HashMap<String, String[]> streamid_hash = new HashMap<String, String[]>();
-	private JSONObject event = null;
-
-	public EventProcessor() {
-		log.debug("EventProcessor: Default Constructor");
-		
-		String list[] = CommonStartup.streamid.split("\\|");
-		for (int i = 0; i < list.length; i++) {
-			String domain = list[i].split("=")[0];
-			//String streamIdList[] = list[i].split("=")[1].split(",");
-			String streamIdList[] = list[i].substring(list[i].indexOf("=") +1).split(",");
-			
-			log.debug("Domain: " + domain + " streamIdList:" + Arrays.toString(streamIdList));
-			streamid_hash.put(domain, streamIdList);
-		}
-		
-	}
-
-	@Override
-	public void run() {
-
-		try {
-			
-			event = CommonStartup.fProcessingInputQueue.take();
-			log.info("EventProcessor\tRemoving element: " + event);
-			
-			//EventPublisher Ep=new EventPublisher();
-			while (event != null) {
-				// As long as the producer is running we remove elements from the queue.
-
-				//UUID uuid = UUID.fromString(event.get("VESuniqueId").toString());
-				String uuid = event.get("VESuniqueId").toString();
-				LoggingContext localLC = VESLogger.getLoggingContextForThread(uuid.toString());
-				localLC .put ( EcompFields.kBeginTimestampMs, SaClock.now () );
-				
-				log.debug("event.VESuniqueId" + event.get("VESuniqueId") + "event.commonEventHeader.domain:" + event.getJSONObject("event").getJSONObject("commonEventHeader").getString("domain"));
-				String streamIdList[]=streamid_hash.get(event.getJSONObject("event").getJSONObject("commonEventHeader").getString("domain"));
-				log.debug("streamIdList:" + streamIdList);
-				
-				if (streamIdList.length == 0)		{
-					log.error("No StreamID defined for publish - Message dropped" + event.toString());
-				} 
-				
-				else {
-					for (int i=0; i < streamIdList.length; i++)
-					{
-						log.info("Invoking publisher for streamId:" + streamIdList[i]);
-						this.overrideEvent();
-						EventPublisher.getInstance(streamIdList[i]).sendEvent(event);
-						
-					}
-				}
-				log.debug("Message published" + event.toString());
-				event = CommonStartup.fProcessingInputQueue.take();
-				// log.info("EventProcessor\tRemoving element: " + this.queue.remove());
-			}
-		} catch (InterruptedException e) {
-			log.error("EventProcessor InterruptedException" + e.getMessage());
-		}
-
-	}
-
-	
-	@SuppressWarnings({ "unchecked", "rawtypes" })
-	public void overrideEvent()
-	{
-		//Set collector timestamp in event payload before publish
-		final Date currentTime = new Date();
-		final SimpleDateFormat sdf =   new SimpleDateFormat("EEE, MM dd yyyy hh:mm:ss z"); 
-		sdf.setTimeZone(TimeZone.getTimeZone("GMT"));
-		
+
+    private static final Logger log = LoggerFactory.getLogger(EventProcessor.class);
+    private static final String EVENT_LITERAL = "event";
+    private static final String COMMON_EVENT_HEADER = "commonEventHeader";
+
+    private static HashMap<String, String[]> streamid_hash = new HashMap<String, String[]>();
+    private JSONObject event;
+
+    public EventProcessor() {
+        log.debug("EventProcessor: Default Constructor");
+
+        String[] list = CommonStartup.streamid.split("\\|");
+        for (String aList : list) {
+            String domain = aList.split("=")[0];
+            //String streamIdList[] = list[i].split("=")[1].split(",");
+            String[] streamIdList = aList.substring(aList.indexOf('=') + 1).split(",");
+
+            log.debug(String.format("Domain: %s streamIdList:%s", domain,
+                Arrays.toString(streamIdList)));
+            streamid_hash.put(domain, streamIdList);
+        }
+
+    }
+
+    @Override
+    public void run() {
+
+        try {
+
+            event = CommonStartup.fProcessingInputQueue.take();
+            log.info("EventProcessor\tRemoving element: " + event);
+
+            //EventPublisher Ep=new EventPublisher();
+            while (event != null) {
+                // As long as the producer is running we remove elements from the queue.
+
+                //UUID uuid = UUID.fromString(event.get("VESuniqueId").toString());
+                String uuid = event.get("VESuniqueId").toString();
+                LoggingContext localLC = VESLogger.getLoggingContextForThread(uuid);
+                localLC.put(EcompFields.kBeginTimestampMs, SaClock.now());
+
+                log.debug("event.VESuniqueId" + event.get("VESuniqueId")
+                    + "event.commonEventHeader.domain:" + event.getJSONObject(EVENT_LITERAL)
+                    .getJSONObject(COMMON_EVENT_HEADER).getString("domain"));
+                String[] streamIdList = streamid_hash.get(
+                    event.getJSONObject(EVENT_LITERAL).getJSONObject(COMMON_EVENT_HEADER)
+                        .getString("domain"));
+                log.debug("streamIdList:" + streamIdList);
+
+                if (streamIdList.length == 0) {
+                    log.error("No StreamID defined for publish - Message dropped" + event);
+                } else {
+                    for (String aStreamIdList : streamIdList) {
+                        log.info("Invoking publisher for streamId:" + aStreamIdList);
+                        this.overrideEvent();
+                        EventPublisher.getInstance(aStreamIdList).sendEvent(event);
+
+                    }
+                }
+                log.debug("Message published" + event);
+                event = CommonStartup.fProcessingInputQueue.take();
+                // log.info("EventProcessor\tRemoving element: " + this.queue.remove());
+            }
+        } catch (InterruptedException e) {
+            log.error("EventProcessor InterruptedException" + e.getMessage());
+        }
+
+    }
+
+
+    @SuppressWarnings({"unchecked", "rawtypes"})
+    public void overrideEvent() {
+        //Set collector timestamp in event payload before publish
+        final Date currentTime = new Date();
+        final SimpleDateFormat sdf = new SimpleDateFormat("EEE, MM dd yyyy hh:mm:ss z");
+        sdf.setTimeZone(TimeZone.getTimeZone("GMT"));
+
 		/*JSONArray additionalParametersarray = new JSONArray().put(new JSONObject().put("collectorTimeStamp", sdf.format(currentTime)));
-		JSONObject additionalParameter = new JSONObject().put("additionalParameters",additionalParametersarray );
+        JSONObject additionalParameter = new JSONObject().put("additionalParameters",additionalParametersarray );
 		JSONObject commonEventHeaderkey = event.getJSONObject("event").getJSONObject("commonEventHeader");
 		commonEventHeaderkey.put("internalHeaderFields", additionalParameter);*/
-		
+
 
 /*		  "event": {
             "commonEventHeader": {
@@ -128,64 +129,65 @@ public class EventProcessor implements Runnable {
                                             "collectorTimeStamp": "Fri, 04 21 2017 04:11:52 GMT"
                             },
 */
-		
-		//JSONArray additionalParametersarray = new JSONArray().put(new JSONObject().put("collectorTimeStamp", sdf.format(currentTime)));
-		JSONObject collectorTimeStamp = new JSONObject().put("collectorTimeStamp",sdf.format(currentTime) );
-		JSONObject commonEventHeaderkey = event.getJSONObject("event").getJSONObject("commonEventHeader");
-		commonEventHeaderkey.put("internalHeaderFields", collectorTimeStamp);
-		event.getJSONObject("event").put("commonEventHeader",commonEventHeaderkey);	
-		
-		if (CommonStartup.eventTransformFlag == 1)
-		{
-				// read the mapping json file
-				final JsonParser parser = new JsonParser();
-				try {
-					final JsonArray jo =  (JsonArray) parser.parse ( new FileReader ( "./etc/eventTransform.json" ) );
-					log.info("parse eventTransform.json");
-					// now convert to org.json
-					final String jsonText = jo.toString ();
-					final JSONArray topLevel = new JSONArray ( jsonText );
-					//log.info("topLevel == " + topLevel);
-					
-					Class[] paramJSONObject = new Class[1];
-					paramJSONObject[0] = JSONObject.class;
-					//load VESProcessors class at runtime
-					Class cls = Class.forName("org.onap.dcae.commonFunction.ConfigProcessors");
-					Constructor constr = cls.getConstructor(paramJSONObject);
-					Object obj = constr.newInstance(event);
-						
-					for (int j=0; j<topLevel.length(); j++)
-					{
-						JSONObject filterObj = topLevel.getJSONObject(j).getJSONObject("filter");
-						Method method = cls.getDeclaredMethod("isFilterMet", paramJSONObject);
-						boolean filterMet = (boolean) method.invoke (obj, filterObj );
-						if (filterMet)
-						{
-							final JSONArray processors = (JSONArray)topLevel.getJSONObject(j).getJSONArray("processors");
-						
-							//call the processor method
-							for (int i=0; i < processors.length(); i++)
-							{
-								final JSONObject processorList = processors.getJSONObject(i);
-								final String functionName = processorList.getString("functionName");
-								final JSONObject args = processorList.getJSONObject("args");
-								//final JSONObject filter = processorList.getJSONObject("filter");
-							
-								log.info("functionName==" + functionName + " | args==" + args);
-								//reflect method call
-								method = cls.getDeclaredMethod(functionName, paramJSONObject);
-								method.invoke(obj, args);
-							}
-						}
-					}
-					
-				} catch (Exception e) {
-					
-					log.error("EventProcessor Exception" + e.getMessage() + e);
-					log.error("EventProcessor Exception" + e.getCause());
-				} 
-		}	
-		log.debug("Modified event:" + event);
-		
-	}
+
+        //JSONArray additionalParametersarray = new JSONArray().put(new JSONObject().put("collectorTimeStamp", sdf.format(currentTime)));
+        JSONObject collectorTimeStamp = new JSONObject()
+            .put("collectorTimeStamp", sdf.format(currentTime));
+        JSONObject commonEventHeaderkey = event.getJSONObject(EVENT_LITERAL)
+            .getJSONObject(COMMON_EVENT_HEADER);
+        commonEventHeaderkey.put("internalHeaderFields", collectorTimeStamp);
+        event.getJSONObject(EVENT_LITERAL).put(COMMON_EVENT_HEADER, commonEventHeaderkey);
+
+        if (CommonStartup.eventTransformFlag == 1) {
+            // read the mapping json file
+            final JsonParser parser = new JsonParser();
+            try {
+                final JsonArray jo = (JsonArray) parser
+                    .parse(new FileReader("./etc/eventTransform.json"));
+                log.info("parse eventTransform.json");
+                // now convert to org.json
+                final String jsonText = jo.toString();
+                final JSONArray topLevel = new JSONArray(jsonText);
+                //log.info("topLevel == " + topLevel);
+
+                Class[] paramJSONObject = new Class[1];
+                paramJSONObject[0] = JSONObject.class;
+                //load VESProcessors class at runtime
+                Class cls = Class.forName("org.onap.dcae.commonFunction.ConfigProcessors");
+                Constructor constr = cls.getConstructor(paramJSONObject);
+                Object obj = constr.newInstance(event);
+
+                for (int j = 0; j < topLevel.length(); j++) {
+                    JSONObject filterObj = topLevel.getJSONObject(j).getJSONObject("filter");
+                    Method method = cls.getDeclaredMethod("isFilterMet", paramJSONObject);
+                    boolean filterMet = (boolean) method.invoke(obj, filterObj);
+                    if (filterMet) {
+                        final JSONArray processors = topLevel.getJSONObject(j)
+                            .getJSONArray("processors");
+
+                        //call the processor method
+                        for (int i = 0; i < processors.length(); i++) {
+                            final JSONObject processorList = processors.getJSONObject(i);
+                            final String functionName = processorList.getString("functionName");
+                            final JSONObject args = processorList.getJSONObject("args");
+                            //final JSONObject filter = processorList.getJSONObject("filter");
+
+                            log.info(String.format("functionName==%s | args==%s", functionName,
+                                args));
+                            //reflect method call
+                            method = cls.getDeclaredMethod(functionName, paramJSONObject);
+                            method.invoke(obj, args);
+                        }
+                    }
+                }
+
+            } catch (Exception e) {
+
+                log.error("EventProcessor Exception" + e.getMessage() + e);
+                log.error("EventProcessor Exception" + e.getCause());
+            }
+        }
+        log.debug("Modified event:" + event);
+
+    }
 }