summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorToineSiebelink <toine.siebelink@est.tech>2023-04-19 16:52:14 +0100
committerToineSiebelink <toine.siebelink@est.tech>2023-04-20 12:05:18 +0100
commit17c24efd4babc61a818fef26ce56954b703fbfb7 (patch)
tree4a214a413593edd22a2cc7c99c47e5eb0f0fbae0 /src
parent3c6ab2322d81d98a26e697cecdb5c4d6da548e81 (diff)
Align dependencies with CPS/NCMP
- Updated several generic dependecies - Changed OpenAPI to use core.v3 version - Order of parameters in generated controlelr code changed - Some maven plugins can uses 'latest' version (affected OpenApi code gen) - set some lib versions for csit test - removed spotbug exclusion file (it alwasy used CPS version of this file anyway) - removed @Valid annotaions in affect file (as agrred long time back) Issue-ID: CPS-1627 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: Ib355382df68ed440618737067590631c7c3a1c8b
Diffstat (limited to 'src')
-rw-r--r--src/main/java/org/onap/cps/ncmp/dmi/rest/controller/DmiRestController.java19
-rw-r--r--src/main/resources/spotbugs-exclude.xml54
2 files changed, 9 insertions, 64 deletions
diff --git a/src/main/java/org/onap/cps/ncmp/dmi/rest/controller/DmiRestController.java b/src/main/java/org/onap/cps/ncmp/dmi/rest/controller/DmiRestController.java
index f952e224..e7ce0520 100644
--- a/src/main/java/org/onap/cps/ncmp/dmi/rest/controller/DmiRestController.java
+++ b/src/main/java/org/onap/cps/ncmp/dmi/rest/controller/DmiRestController.java
@@ -28,7 +28,6 @@ import com.fasterxml.jackson.databind.ObjectMapper;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
-import javax.validation.Valid;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.onap.cps.ncmp.dmi.model.CmHandles;
@@ -74,7 +73,7 @@ public class DmiRestController implements DmiPluginApi, DmiPluginInternalApi {
@Override
public ResponseEntity<ModuleSet> getModuleReferences(final String cmHandle,
- final @Valid ModuleReferencesRequest body) {
+ final ModuleReferencesRequest body) {
// For onap-dmi-plugin we don't need cmHandleProperties, so DataAccessReadRequest is not used.
final ModuleSet moduleSet = dmiService.getModulesForCmHandle(cmHandle);
return ResponseEntity.ok(moduleSet);
@@ -82,8 +81,8 @@ public class DmiRestController implements DmiPluginApi, DmiPluginInternalApi {
@Override
public ResponseEntity<YangResources> retrieveModuleResources(
- final @Valid ModuleResourcesReadRequest moduleResourcesReadRequest,
- final String cmHandle) {
+ final String cmHandle,
+ final ModuleResourcesReadRequest moduleResourcesReadRequest) {
final List<ModuleReference> moduleReferences = convertRestObjectToJavaApiObject(moduleResourcesReadRequest);
final YangResources yangResources = dmiService.getModuleResources(cmHandle, moduleReferences);
return new ResponseEntity<>(yangResources, HttpStatus.OK);
@@ -95,7 +94,7 @@ public class DmiRestController implements DmiPluginApi, DmiPluginInternalApi {
* @param cmHandles list of cm-handles
* @return (@ code ResponseEntity) response entity
*/
- public ResponseEntity<String> registerCmHandles(final @Valid CmHandles cmHandles) {
+ public ResponseEntity<String> registerCmHandles(final CmHandles cmHandles) {
final List<String> cmHandlesList = cmHandles.getCmHandles();
if (cmHandlesList.isEmpty()) {
return new ResponseEntity<>("Need at least one cmHandle to process.", HttpStatus.BAD_REQUEST);
@@ -110,20 +109,20 @@ public class DmiRestController implements DmiPluginApi, DmiPluginInternalApi {
* supports both read and write operation whereas passthrough operational does not support write operations.
*
* @param resourceIdentifier resource identifier to fetch data
- * @param datastoreName name of the datastore
+ * @param datastoreName name of the datastore
* @param cmHandle cm handle identifier
- * @param dataAccessRequest data Access Request
* @param optionsParamInQuery options query parameter
* @param topicParamInQuery topic name for (triggering) async responses
+ * @param dataAccessRequest data Access Request
* @return {@code ResponseEntity} response entity
*/
@Override
public ResponseEntity<Object> dataAccessPassthrough(final String resourceIdentifier,
final String datastoreName,
final String cmHandle,
- final DataAccessRequest dataAccessRequest,
final String optionsParamInQuery,
- final String topicParamInQuery) {
+ final String topicParamInQuery,
+ final DataAccessRequest dataAccessRequest) {
if (DatastoreType.PASSTHROUGH_OPERATIONAL == DatastoreType.fromDatastoreName(datastoreName)) {
return dataAccessPassthroughOperational(resourceIdentifier, cmHandle, dataAccessRequest,
optionsParamInQuery, topicParamInQuery);
@@ -188,7 +187,7 @@ public class DmiRestController implements DmiPluginApi, DmiPluginInternalApi {
dataAccessRequest.getDataType(), dataAccessRequest.getData());
}
- private boolean isReadOperation(final @Valid DataAccessRequest dataAccessRequest) {
+ private boolean isReadOperation(final DataAccessRequest dataAccessRequest) {
return dataAccessRequest.getOperation() == null
|| dataAccessRequest.getOperation().equals(DataAccessRequest.OperationEnum.READ);
}
diff --git a/src/main/resources/spotbugs-exclude.xml b/src/main/resources/spotbugs-exclude.xml
deleted file mode 100644
index e8a1f6e2..00000000
--- a/src/main/resources/spotbugs-exclude.xml
+++ /dev/null
@@ -1,54 +0,0 @@
-<!--
- ============LICENSE_START=======================================================
- Copyright (C) 2021 Nordix Foundation.
- ================================================================================
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
- ============LICENSE_END=========================================================
--->
-
-<FindBugsFilter>
- <Match>
- <!-- Ignore generated code -->
- <Source name="~.*generated-sources.*.java"/>
- </Match>
- <Match>
- <Or>
- <!-- Anonymous inner classes are very common. -->
- <Bug pattern="SIC_INNER_SHOULD_BE_STATIC_ANON" />
-
- <!-- We use static slf4j Logger (this rule is from KengoTODA/findbugs-slf4j jp.skypencil.findbugs.slf4:bug-pattern) -->
- <Bug pattern="SLF4J_LOGGER_SHOULD_BE_NON_STATIC" />
-
- <!-- Guava 25.1+ uses the Checker Framework's @Nullable which SpotBugs doesn't handle correctly, even though it's
- supposed to; see https://github.com/spotbugs/spotbugs/issues/743 -->
- <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
- <Bug pattern="NP_NULL_PARAM_DEREF" />
- <Bug pattern="NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE" />
- <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE" />
-
- <!-- https://stackoverflow.com/a/34674776. Doesn't detect Lombok All Args Constructor variables being used with map get key and value, which can lead to spotbugs being detected
- on used fields -->
- <Bug pattern="URF_UNREAD_FIELD"/>
-
- <!-- https://github.com/spotbugs/spotbugs/issues/511. Strict reading of Object.equals() contract means that
- evenever equals() behaviour is defined, all implementations need to adhere to it. The only reason
- to override the method (assuming correct API design, of course) is to provide a more efficient
- implementation. This rule would be forcing a @SuppressFBWarnings on perfectly compliant classes. -->
- <Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
-
- <!-- https://github.com/spotbugs/spotbugs/issues/756. spotbugs does not grok Java 11's try-with-resources -->
- <Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
- </Or>
- </Match>
-
-</FindBugsFilter>