summaryrefslogtreecommitdiffstats
path: root/src/main
diff options
context:
space:
mode:
authoremaclee <lee.anjella.macabuhay@est.tech>2022-06-08 11:41:59 +0100
committeremaclee <lee.anjella.macabuhay@est.tech>2022-06-10 10:31:44 +0100
commite883b97dd85a37b16c1c981e907799a304e0a23d (patch)
tree9ad8b777dc83482c1710d3910da2f3a11fc81db1 /src/main
parent2cd8b98223bd49975fcca0ec7f1d4673a4163074 (diff)
Fix sonar code smells
- Remove this unused method parameter "operation" (https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=onap_cps-ncmp-dmi-plugin&open=AYEgIe-wVOe7T_lfxJBt) - Change method to private Issue-ID: CPS-475 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech> Change-Id: I07e9b8150da935387f2a63c5b0e622d5157412de
Diffstat (limited to 'src/main')
-rw-r--r--src/main/java/org/onap/cps/ncmp/dmi/notifications/async/AsyncTaskExecutor.java5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/main/java/org/onap/cps/ncmp/dmi/notifications/async/AsyncTaskExecutor.java b/src/main/java/org/onap/cps/ncmp/dmi/notifications/async/AsyncTaskExecutor.java
index 7189f6c9..6a1c6d1d 100644
--- a/src/main/java/org/onap/cps/ncmp/dmi/notifications/async/AsyncTaskExecutor.java
+++ b/src/main/java/org/onap/cps/ncmp/dmi/notifications/async/AsyncTaskExecutor.java
@@ -78,7 +78,7 @@ public class AsyncTaskExecutor {
publishAsyncEvent(topicName, requestId, resourceDataAsJson, status, code);
} else {
log.error("Error occurred with async request {}", throwable.getMessage());
- publishAsyncFailureEvent(topicName, requestId, operation, throwable);
+ publishAsyncFailureEvent(topicName, requestId, throwable);
}
});
log.info("Async task completed.");
@@ -95,9 +95,8 @@ public class AsyncTaskExecutor {
dmiAsyncRequestResponseEventProducer.sendMessage(requestId, cpsAsyncRequestResponseEvent);
}
- protected void publishAsyncFailureEvent(final String topicName,
+ private void publishAsyncFailureEvent(final String topicName,
final String requestId,
- final DataAccessRequest.OperationEnum operation,
final Throwable throwable) {
HttpStatus httpStatus = HttpStatus.INTERNAL_SERVER_ERROR;