aboutsummaryrefslogtreecommitdiffstats
path: root/cps-ncmp-service
AgeCommit message (Collapse)AuthorFilesLines
2025-03-05Omit decendents when resolving AlternateIdseanbeirne5-19/+25
Issue-ID: CPS-2652 Change-Id: Ifcaa62d251ab0e4c926f13180acde90a02778c74 Signed-off-by: seanbeirne <sean.beirne@est.tech>
2025-03-05Merge "Use attribute-axis in NCMP [#2]"Daniel Hanrahan2-28/+23
2025-03-05Merge "Add conditionalProperty for DeviceTrustLevelMessageConsumer"Daniel Hanrahan1-0/+2
2025-03-04Use attribute-axis in NCMP [#2]emaclee2-28/+23
- uses queryleaf API on the methods queryCmHandleAnyProperties Issue-ID: CPS-2665 Change-Id: Ibad5888ae8ec8f23348d90d7c99871b075479e03 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2025-03-04Merge "Improved unit test related to cm handle reference lookup"Lee Anjella Macabuhay1-15/+17
2025-03-04Improved unit test related to cm handle reference lookupToineSiebelink1-15/+17
Issue-ID: CPS-2605 Change-Id: Iac36b4838f640fa0bb4bf6bcc41f8a72e8c3bd8e Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2025-03-04Merge "Use attribute-axis in NCMP [#1]"Daniel Hanrahan5-119/+102
2025-03-03Bump CPS to 3.6.2-SNAPSHOTegernug1-1/+1
Issue-ID: CPS-2670 Change-Id: Ida5b74651cca38749c43bd21f410ba539539d914 Signed-off-by: egernug <gerard.nugent@est.tech>
2025-03-03Add conditionalProperty for DeviceTrustLevelMessageConsumeremaclee1-0/+2
Issue-ID: CPS-2556 Change-Id: Id3be9bccdf40065794654cc414ae75a2184aebb8 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2025-02-28Merge "Change order of CM Handle Reference lookup depending on special ↵Sourabh Sourabh4-61/+45
character"
2025-02-27Change order of CM Handle Reference lookup depending on special characterseanbeirne4-61/+45
- implemented new algorithm using validator to rule out standard id / prefer alternate id - moved validator imp to cps-service (not in RI) TBC!!! - changed order of characters tested in validator to fail fast (on '=') - added Boolean variation validator method to reduce overhead and prevent logic based on exceptions - improved integration test to cover all scenarios - add performance test for alternate id look up (report only) - ensured all performance test use alternate ids it '=' - added small groovy tests to restore cps-ri code coverage to 0.31 Issue-ID: CPS-2605 Change-Id: Id9c22bb69904b7f5d376b7f8319332428435333e Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Signed-off-by: seanbeirne <sean.beirne@est.tech>
2025-02-27Use attribute-axis in NCMP [#1]emaclee5-119/+102
- uses queryleaf API on the methods getCmHandleReferencesByTrustLevel, getCmHandleReferencesByDmiPluginIdentifier Issue-ID: CPS-2663 Change-Id: Ib9ff3ceb58b14664660f2a92b02e0bacf00bebda Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2025-02-25Event data schemas for NCMPmpriyank8-65/+97
- Updated the schema id as NCMP has a master copy of all the schemas that are used - Introduced an enum to keep track of the dataschemas at a single place. - Refactored NcmpEvent builder class to take type and dataschema as a parameter - Cleaned up dependencies - Refactored testware to prove the changes - Changes are according to the decisions recorded here https://lf-onap.atlassian.net/wiki/spaces/DW/pages/16554840/CPS-2425+Event+Schemas+in+ONAP#Agreed-Event-Schema-Names Issue-ID: CPS-2425 Change-Id: Icbda1aa20e3c4b0f2b6797d25b59e52cf9237c92 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2025-02-12Merge "Change Datajob Status return value"Priyank Maheshwari2-9/+7
2025-02-12Change Datajob Status return valueegernug2-9/+7
- Change to return entire JSON object instead of status string Issue-ID: CPS-2613 Change-Id: I63d8a9d078f003fc06e301bf9921f7942b3603ab Signed-off-by: egernug <gerard.nugent@est.tech>
2025-02-07Fix for intermittent failures of module sync testsdanielhanrahan2-3/+3
- Removed PollingConditions as ModuleSyncWatchdog is now synchronous - Use Hazelcast IMap::delete instead of IMap::removeAsync to fix root cause of test failures: removeAsync may not be finished when module sync is re-run during tests. Issue-ID: CPS-2615 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I1786a1303606132218dc8e4e91fb58e6f6cc0bcb
2025-02-06Merge "Fix duplicated yang resource references V2"Daniel Hanrahan1-7/+7
2025-02-06Fix duplicated yang resource references V2ToineSiebelink1-7/+7
- Store Yang module references using SchemaSetEntity instead of SQL - Added integration test to check number of references - Update dispatcher for integration test to only return yang resources requested modules - refactor schema set create & upgrade methods for better re-uses and readability - consistent naming in related methods like(new)yangResourceContentPerName (the name can be filename, module name or schema set name) depending on the context - replaced 'var' with actual class names in affected classes Issue-ID: CPS-2605 Change-Id: I8870c70832ac533bd17ce8af409a071f659e4acf Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2025-02-05Merge "Remove multithreading from module sync watchdog"Toine Siebelink8-274/+21
2025-02-05Merge "Change event topic name for trust level"Daniel Hanrahan2-12/+12
2025-02-04Remove multithreading from module sync watchdogdanielhanrahan8-274/+21
After introduction of module set tag improvements, there is no need to multithreading in module sync. Performance impact is minimal. Issue-ID: CPS-2165 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I1557fc8348d39da3654a1b92944c6ad49fa8670d
2025-01-30Fix deprecation issue related to KafkaContainermpriyank1-4/+3
- Replaced KafkaContainer with ConfluentKafkaContainer to fix the deprecation issue - Bumped the version of cp-kafka and cp-zookeeper to 7.8.0 - Removing reference of registry.nordix as the NCMP internal pipeline is no longer used Issue-ID: CPS-2608 Change-Id: Ic1f3edbc06d63c5f00c1ecb901e07a6bc17ae6eb Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2025-01-30Remove deprecated Rest endpoints for hazelcast healthmpriyank2-27/+2
- removing the hazelcast cluster rest health check endpoints Issue-ID: CPS-2612 Change-Id: I01ad0e4b4d8ad99ce7a6e4e4dc0f0a8272d39227 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2025-01-29Bump CPS-NCMP to 3.6.1-SNAPSHOTmpriyank1-1/+1
Issue-ID: CPS-2610 Change-Id: I289fcbdc2df1de6d369cc6e01bdad26ec174b08f Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2025-01-29Merge "Add "dataProducerId" and "dmiServiceName" values to ↵Lee Anjella Macabuhay2-5/+9
SubJobWriteResponse in sendRequestsToDmi method"
2025-01-29Add "dataProducerId" and "dmiServiceName" values to SubJobWriteResponse in ↵egernug2-5/+9
sendRequestsToDmi method - DMI call only returns subJobId - SubJobWriteResponse created using DMI response and request values Issue-ID: CPS-2497 Change-Id: Ib38132f2337de6a12b0b05bc6eebeed99f8d435d Signed-off-by: egernug <gerard.nugent@est.tech>
2025-01-29Address sonar violations related to hazelcastmpriyank1-1/+5
- Supressing warning caused by deprecation of RestApiConfig in hazelcast 5.5 community version , which will be removed in 6.0 so created https://lf-onap.atlassian.net/browse/CPS-2599 to address the issues - Other sonar fixes Issue-ID: CPS-2594 Change-Id: I2e95cd851eae74d8bbb4535cfbaed1dc1ef89543 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2025-01-28Merge "Send new module set tag to DMI during model upgrade"Daniel Hanrahan5-62/+82
2025-01-28Merge "Moved CpsValidator under the utils package"Daniel Hanrahan4-4/+4
2025-01-28Send new module set tag to DMI during model upgradedanielhanrahan5-62/+82
Previously, DMI would receive old module set tag in the request body. The tag being upgrade to is the expected one. Issue-ID: CPS-2589 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I0554136f0d4c55d687b575313d932f6bcab15c92
2025-01-27Moved CpsValidator under the utils packageleventecsanyi4-4/+4
Issue-ID: CPS-2515 Change-Id: I57f6c10c8596281aed686552ad16e1dd6c15ff98 Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2025-01-27Change event topic name for trust levelemaclee2-12/+12
- Seperate inventory related topics to cm data event topic Issue-ID: CPS-2500 Change-Id: I41a2cda78568f9979fc9f030f076c295c8d6908b Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2025-01-24Less logging during registrationdanielhanrahan2-14/+7
During investigation of CPS-2576 bug, stack traces were added to log output (by logging the exception object). This produces massive log output during registration, since all CM-handles fail to sync and go to LOCKED state initially due to initial DMI delay. This patch logs exception details at warning level but not stacktrace Issue-ID: CPS-2576 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ibb55991e75c058e9f4983bd876285b48917ee28e
2025-01-24Merge "Fix for cm handles stuck in LOCKED during registration"Priyank Maheshwari3-10/+54
2025-01-24Merge "Incorrect Internal Error Code for duplicated registration"Daniel Hanrahan3-11/+9
2025-01-23Fix for cm handles stuck in LOCKED during registrationToineSiebelink3-10/+54
- Additional Error logging when cm handles fail module sync - Swallow already defined exception upon schema and/or anchor creation - Updated integration test to try to reproduce the problem (but couldn't) - Ignored integration tests that depend/affected by race conditions (they are useful for troubleshooting but not for pipeline checks) - Removed last remnants of springboot retry annotation option (incl dependencies) Issue-ID: CPS-2576 Change-Id: I910e802268332f955134c043bd1b46a7ec57233b Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2025-01-23Incorrect Internal Error Code for duplicated registrationseanbeirne3-11/+9
-Deprectated 111 Alternate-Id already exists error code -All dupication scenarios now return 109 Issue-ID: CPS-2563 Change-Id: Ic9b9df936eaf3795441f4dd1ec1cc73e39c9eae1 Signed-off-by: seanbeirne <sean.beirne@est.tech>
2025-01-22Merge "Moved builders under impl in CPS Service"Toine Siebelink3-3/+3
2025-01-21Remove retry mechanism for duplicate module(resource) errorsToineSiebelink2-22/+15
- CM Handle with problems will go into 'LOCKED' state and retried using existing business logic Issue-ID: CPS-2555 Change-Id: I563f6bc536d8fd8c6675891c62318ff2fb43fea6 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2025-01-20Moved builders under impl in CPS Serviceleventecsanyi3-3/+3
- moved builders and fixed the Arch test Issue-ID: CPS-2542 Change-Id: Iac9d47f20fff2e6fa415ada8bc17880b0b032591 Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2025-01-17Merge "Make Response Timeout Configurable in WebClient Configuration"Lee Anjella Macabuhay4-7/+10
2025-01-17Merge "One SchemaSet per moduleSetTag"Sourabh Sourabh13-430/+239
2025-01-16Make Response Timeout Configurable in WebClient Configurationsourabh_sourabh4-7/+10
- Added responseTimeoutInSeconds property in the ServiceConfig class to allow dynamic configuration of the timeout. - Updated WebClientConfiguration to read the responseTimeoutInSeconds from ServiceConfig and set it in the HttpClient. Issue-ID: CPS-2565 Change-Id: I096688319c55f0342b524511883ec0d33806b9b7 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2025-01-16Handle restart case for cps-ncmp gauge metricsemaclee7-27/+109
Issue-ID: CPS-2456 Change-Id: I9ac5d6774fcd745d8141551eeff8a1deb1938f57 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2025-01-16One SchemaSet per moduleSetTagToineSiebelink13-430/+239
- Registration: create and upgrade cases. - Handle moduleSetTag deletion (all orphans) for testware - Unit tests updated - additional logging of details for upgrade scenarios - Integration Tests updated - Remove cache for module sets being processed - Removed DbCleaner (startup) - Removed redundant methods in NCMP Inventory for deleting schema set(s) - Removed validation check for all schema set interactions - Updated some schema set tests to use special characters previously not allowed - Checked integration test scenarios for upgrades with and without tags: all scenarios covered! TODO - REST endpoint to remove orphaned schema set data, separate story: CPS-2554 - Investigate exception handling regarding DuplicateYangResourceException: CPS-2555 Issue-ID: CPS-2540 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: Iaa59cbdb86b7a4a8044624829bc002506ff40cc7
2025-01-15Merge "Move LockReasonCategory under api package"Lee Anjella Macabuhay36-75/+76
2025-01-13Move LockReasonCategory under api packageleventecsanyi36-75/+76
- reafctored package structure Issue-ID: CPS-2514 Change-Id: Id54cd652e147b585730caacbe550287ae2c329e1 Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2025-01-13Add conditionalProperty in subscription consumers and producersemaclee3-0/+6
Issue-ID: CPS-2556 Change-Id: Id6a70dbfabc9119727eb307f3c2928a13f3bf44a Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2025-01-07Merge "Add gauge metric for NCMP "cmhandle states""Daniel Hanrahan6-4/+305
2025-01-07Add gauge metric for NCMP "cmhandle states"emaclee6-4/+305
Issue-ID: CPS-2456 Change-Id: I1aebcc68dfdc9c48c230c74376742d67b05c0615 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>