Remove Hazelcast cache for prefix resolver (CPS-2417 #2)

This patch removes the AnchorDataCache from CPS, which is used for
prefix resolution in get/query operations.

As such, Hazelcast is no longer a dependency of CPS, only NCMP.

- Changed PrefixResolver to be more efficient.
- Removed AnchorDataCache and associated classes.
- Moved HazelcastCacheConfig to NCMP.
- Removed Hazelcast dependency from cps-service/pom.xml

This shows good performance improvements in some APIs such as v2 GET
which is nearly 2x faster (also 5x faster including base patch).

Issue-ID: CPS-2417
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I24768469f24e90b70f7a6187faa4f5b3d75777d2

5 files changed, 6 insertions, 263 deletions

diff --git a/cps-service/src/test/groovy/org/onap/cps/cache/AnchorDataCacheConfigSpec.groovy b/cps-service/src/test/groovy/org/onap/cps/cache/AnchorDataCacheConfigSpec.groovy
deleted file mode 100644
index 010308c42f..0000000000
--- a/cps-service/src/test/groovy/org/onap/cps/cache/AnchorDataCacheConfigSpec.groovy
+++ /dev/null
@@ -1,80 +0,0 @@
-/*
- *  ============LICENSE_START=======================================================
- *  Copyright (C) 2022-2023 Nordix Foundation
- *  ================================================================================
- *  Licensed under the Apache License, Version 2.0 (the "License");
- *  you may not use this file except in compliance with the License.
- *  You may obtain a copy of the License at
- *
- *        http://www.apache.org/licenses/LICENSE-2.0
- *
- *  Unless required by applicable law or agreed to in writing, software
- *  distributed under the License is distributed on an "AS IS" BASIS,
- *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- *  See the License for the specific language governing permissions and
- *  limitations under the License.
- *
- *  SPDX-License-Identifier: Apache-2.0
- *  ============LICENSE_END=========================================================
- */
-
-package org.onap.cps.cache
-
-import com.hazelcast.config.Config
-import com.hazelcast.core.Hazelcast
-import com.hazelcast.map.IMap
-import org.springframework.beans.factory.annotation.Autowired
-import org.springframework.boot.test.context.SpringBootTest
-import org.springframework.test.context.ContextConfiguration
-import spock.lang.Specification
-
-@SpringBootTest
-@ContextConfiguration(classes = [AnchorDataCacheConfig])
-class AnchorDataCacheConfigSpec extends Specification {
-
-    @Autowired
-    private IMap<String, AnchorDataCacheEntry> anchorDataCache
-
-    def 'Embedded (hazelcast) cache for Anchor Data.'() {
-        expect: 'system is able to create an instance of the Anchor data cache'
-            assert null != anchorDataCache
-        and: 'there is at least 1 instance'
-            assert Hazelcast.allHazelcastInstances.size() > 0
-        and: 'anchorDataCache is present'
-            assert Hazelcast.allHazelcastInstances.name.contains('hazelCastInstanceCpsCore')
-    }
-
-    def 'Verify configs for Distributed Caches'(){
-        given: 'the Anchor Data Cache config'
-            def anchorDataCacheConfig =  Hazelcast.getHazelcastInstanceByName('hazelCastInstanceCpsCore').config
-            def anchorDataCacheMapConfig =  anchorDataCacheConfig.mapConfigs.get('anchorDataCacheMapConfig')
-        expect: 'system created instance with correct config'
-            assert anchorDataCacheConfig.clusterName == 'cps-and-ncmp-test-caches'
-            assert anchorDataCacheMapConfig.backupCount == 1
-            assert anchorDataCacheMapConfig.asyncBackupCount == 0
-    }
-
-    def 'Verify deployment network configs for Distributed Caches'() {
-        given: 'the Anchor Data Cache config'
-            def anchorDataCacheNetworkConfig = Hazelcast.getHazelcastInstanceByName('hazelCastInstanceCpsCore').config.networkConfig
-        expect: 'system created instance with correct config'
-            assert anchorDataCacheNetworkConfig.join.autoDetectionConfig.enabled
-            assert !anchorDataCacheNetworkConfig.join.kubernetesConfig.enabled
-    }
-
-    def 'Verify network config'() {
-        given: 'Synchronization config object and test configuration'
-            def objectUnderTest = new AnchorDataCacheConfig()
-            def testConfig = new Config()
-        when: 'kubernetes properties are enabled'
-            objectUnderTest.cacheKubernetesEnabled = true
-            objectUnderTest.cacheKubernetesServiceName = 'test-service-name'
-        and: 'method called to update the discovery mode'
-            objectUnderTest.updateDiscoveryMode(testConfig)
-        then: 'applied properties are reflected'
-            assert testConfig.networkConfig.join.kubernetesConfig.enabled
-            assert testConfig.networkConfig.join.kubernetesConfig.properties.get('service-name') == 'test-service-name'
-
-    }
-
-}
diff --git a/cps-service/src/test/groovy/org/onap/cps/cache/AnchorDataCacheEntrySpec.groovy b/cps-service/src/test/groovy/org/onap/cps/cache/AnchorDataCacheEntrySpec.groovy
deleted file mode 100644
index f38b45d17c..0000000000
--- a/cps-service/src/test/groovy/org/onap/cps/cache/AnchorDataCacheEntrySpec.groovy
+++ /dev/null
@@ -1,40 +0,0 @@
-/*
- *  ============LICENSE_START=======================================================
- *  Copyright (C) 2022 Nordix Foundation
- *  ================================================================================
- *  Licensed under the Apache License, Version 2.0 (the "License");
- *  you may not use this file except in compliance with the License.
- *  You may obtain a copy of the License at
- *
- *        http://www.apache.org/licenses/LICENSE-2.0
- *
- *  Unless required by applicable law or agreed to in writing, software
- *  distributed under the License is distributed on an "AS IS" BASIS,
- *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- *  See the License for the specific language governing permissions and
- *  limitations under the License.
- *
- *  SPDX-License-Identifier: Apache-2.0
- *  ============LICENSE_END=========================================================
- */
-
-package org.onap.cps.cache
-
-
-import spock.lang.Specification
-
-class AnchorDataCacheEntrySpec extends Specification {
-
-    def objectUnderTest = new AnchorDataCacheEntry()
-
-    def 'Anchor Data Cache Properties Management.'() {
-        when: 'a property named "sample" is added to the cache'
-            objectUnderTest.setProperty('sample', 123)
-        then: 'the cache has that property'
-            assert objectUnderTest.hasProperty('sample')
-        and: 'the value is correct'
-            assert objectUnderTest.getProperty('sample') == 123
-        and: 'the cache does not have an an object called "something else"'
-            assert objectUnderTest.hasProperty('something else') == false
-    }
-}
diff --git a/cps-service/src/test/groovy/org/onap/cps/cache/HazelcastCacheConfigSpec.groovy b/cps-service/src/test/groovy/org/onap/cps/cache/HazelcastCacheConfigSpec.groovy
deleted file mode 100644
index 022cd74ea6..0000000000
--- a/cps-service/src/test/groovy/org/onap/cps/cache/HazelcastCacheConfigSpec.groovy
+++ /dev/null
@@ -1,76 +0,0 @@
-/*
- *  ============LICENSE_START=======================================================
- *  Copyright (C) 2023 Nordix Foundation
- *  ================================================================================
- *  Licensed under the Apache License, Version 2.0 (the "License");
- *  you may not use this file except in compliance with the License.
- *  You may obtain a copy of the License at
- *
- *        http://www.apache.org/licenses/LICENSE-2.0
- *
- *  Unless required by applicable law or agreed to in writing, software
- *  distributed under the License is distributed on an "AS IS" BASIS,
- *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- *  See the License for the specific language governing permissions and
- *  limitations under the License.
- *
- *  SPDX-License-Identifier: Apache-2.0
- *  ============LICENSE_END=========================================================
- */
-
-package org.onap.cps.cache
-
-import com.hazelcast.config.Config
-import com.hazelcast.config.RestEndpointGroup
-import spock.lang.Specification
-
-class HazelcastCacheConfigSpec extends Specification {
-
-    def objectUnderTest = new HazelcastCacheConfig()
-
-    def 'Create Hazelcast instance with a #scenario'() {
-        given: 'a cluster name'
-            objectUnderTest.clusterName = 'my cluster'
-        when: 'an hazelcast instance is created (name has to be unique)'
-            def result = objectUnderTest.createHazelcastInstance(scenario, config)
-        then: 'the instance is created and has the correct name'
-            assert result.name == scenario
-        and: 'if applicable it has a map config with the expected name'
-            if (expectMapConfig) {
-                assert result.config.mapConfigs.values()[0].name == 'my map config'
-            } else {
-                assert result.config.mapConfigs.isEmpty()
-            }
-        and: 'if applicable it has a queue config with the expected name'
-            if (expectQueueConfig) {
-                assert result.config.queueConfigs.values()[0].name == 'my queue config'
-            } else {
-                assert result.config.queueConfigs.isEmpty()
-            }
-        and: 'if applicable it has a set config with the expected name'
-            if (expectSetConfig) {
-                assert result.config.setConfigs.values()[0].name == 'my set config'
-            } else {
-                assert result.config.setConfigs.isEmpty()
-            }
-        where: 'the following configs are used'
-            scenario       | config                                                    || expectMapConfig | expectQueueConfig | expectSetConfig
-            'Map Config'   | HazelcastCacheConfig.createMapConfig('my map config')     || true            | false             | false
-            'Queue Config' | HazelcastCacheConfig.createQueueConfig('my queue config') || false           | true              | false
-            'Set Config'   | HazelcastCacheConfig.createSetConfig('my set config')     || false           | false             | true
-    }
-
-    def 'Verify Hazelcast Cluster Information'() {
-        given: 'a test configuration'
-            def testConfig = new Config()
-        when: 'cluster information is exposed'
-            objectUnderTest.exposeClusterInformation(testConfig)
-        then: 'REST api configs are enabled'
-            assert testConfig.networkConfig.restApiConfig.enabled
-        and: 'only health check and cluster read are enabled'
-            def enabledGroups = testConfig.networkConfig.restApiConfig.enabledGroups
-            assert enabledGroups.size() == 2
-            assert enabledGroups.containsAll([RestEndpointGroup.CLUSTER_READ, RestEndpointGroup.HEALTH_CHECK])
-    }
-
-}
diff --git a/cps-service/src/test/groovy/org/onap/cps/utils/PrefixResolverSpec.groovy b/cps-service/src/test/groovy/org/onap/cps/utils/PrefixResolverSpec.groovy
index 5ef584a0b8..13b042f1ae 100644
--- a/cps-service/src/test/groovy/org/onap/cps/utils/PrefixResolverSpec.groovy
+++ b/cps-service/src/test/groovy/org/onap/cps/utils/PrefixResolverSpec.groovy
@@ -1,6 +1,6 @@
 /*
  *  ============LICENSE_START=======================================================
- *  Copyright (C) 2021-2023 Nordix Foundation
+ *  Copyright (C) 2021-2024 Nordix Foundation
  *  Modifications Copyright (C) 2021 Pantheon.tech
  *  Modifications Copyright (C) 2021-2022 Bell Canada.
  *  ================================================================================
@@ -22,11 +22,8 @@
 
 package org.onap.cps.utils
 
-import com.hazelcast.map.IMap
 import org.onap.cps.TestUtils
-import org.onap.cps.api.CpsAnchorService
 import org.onap.cps.api.impl.YangTextSchemaSourceSetCache
-import org.onap.cps.cache.AnchorDataCacheEntry
 import org.onap.cps.spi.model.Anchor
 import org.onap.cps.yang.YangTextSchemaSourceSet
 import org.onap.cps.yang.YangTextSchemaSourceSetBuilder
@@ -34,13 +31,9 @@ import spock.lang.Specification
 
 class PrefixResolverSpec extends Specification {
 
-    def mockCpsAnchorService = Mock(CpsAnchorService)
-
     def mockYangTextSchemaSourceSetCache = Mock(YangTextSchemaSourceSetCache)
 
-    def mockAnchorDataCache = Mock(IMap<String, AnchorDataCacheEntry>)
-
-    def objectUnderTest = new PrefixResolver(mockCpsAnchorService, mockYangTextSchemaSourceSetCache, mockAnchorDataCache)
+    def objectUnderTest = new PrefixResolver(mockYangTextSchemaSourceSetCache)
 
     def mockYangTextSchemaSourceSet = Mock(YangTextSchemaSourceSet)
 
@@ -50,27 +43,14 @@ class PrefixResolverSpec extends Specification {
 
     def anchor = new Anchor(dataspaceName: 'testDataspace', name: 'testAnchor')
 
-    def setup() {
-        given: 'the system can get the anchor'
-            mockCpsAnchorService.getAnchor('testDataspace', 'testAnchor') >> anchor
-        and: 'the schema source cache contains the schema context for the test-tree module'
-            mockYangTextSchemaSourceSet.getSchemaContext() >> schemaContext
-    }
-
     def 'get xpath prefix using node schema context'() {
+        given: 'the schema source cache contains the schema context for the test-tree module'
+            mockYangTextSchemaSourceSet.getSchemaContext() >> schemaContext
+            mockYangTextSchemaSourceSetCache.get(*_) >> mockYangTextSchemaSourceSet
         when: 'the prefix of the yang module is retrieved'
             def result = objectUnderTest.getPrefix(anchor, xpath)
         then: 'the expected prefix is returned'
             result == expectedPrefix
-        and: 'the cache is updated for the given anchor with a map of prefixes per top level container (just one one this case)'
-            1 * mockAnchorDataCache.put('testAnchor',_ , _ ,_) >> { args -> {
-                def prefixPerContainerName = args[1].getProperty("prefixPerContainerName")
-                assert prefixPerContainerName.size() == 1
-                assert prefixPerContainerName.get('test-tree') == 'tree'
-                }
-            }
-        and: 'schema source cache is used (i.e. need to build schema context)'
-            1 * mockYangTextSchemaSourceSetCache.get(*_) >> mockYangTextSchemaSourceSet
         where: 'the following scenarios are applied'
             xpath                         || expectedPrefix
             '/test-tree'                  || 'tree'
@@ -82,37 +62,4 @@ class PrefixResolverSpec extends Specification {
             '/not-defined'                || ''
     }
 
-    def 'get prefix with populated anchor data cache with #scenario cache entry'() {
-        given: 'anchor data cache is populated for the anchor with a prefix for top level container named #cachedTopLevelContainerName'
-            def anchorDataCacheEntry = new AnchorDataCacheEntry()
-            def prefixPerContainerName = [(cachedTopLevelContainerName): 'cachedPrefix']
-            anchorDataCacheEntry.setProperty('prefixPerContainerName',prefixPerContainerName)
-            mockAnchorDataCache.containsKey('testAnchor') >> true
-            mockAnchorDataCache.get('testAnchor') >> anchorDataCacheEntry
-        when: 'the prefix of the yang module is retrieved'
-            def result = objectUnderTest.getPrefix(anchor, '/test-tree')
-        then: 'the expected prefix is returned'
-            result == expectedPrefix
-        and: 'schema source cache is not used (i.e. no need to build schema context)'
-            0 * mockYangTextSchemaSourceSetCache.get(*_)
-        where: 'the following scenarios are applied'
-            scenario       | cachedTopLevelContainerName || expectedPrefix
-            'matching'     | 'test-tree'                 || 'cachedPrefix'
-            'non-matching' | 'other'                     || ''
-    }
-
-    def 'get prefix with other (non relevant) data in anchor data cache'() {
-        given: 'anchor data cache is populated with non relevant other property'
-            def anchorDataCacheEntry = new AnchorDataCacheEntry()
-            anchorDataCacheEntry.setProperty('something else', 'does not matter')
-            mockAnchorDataCache.containsKey('testAnchor') >> true
-            mockAnchorDataCache.get('testAnchor') >> anchorDataCacheEntry
-        when: 'the prefix of the yang module is retrieved'
-            def result = objectUnderTest.getPrefix(anchor, '/test-tree')
-        then: 'the expected prefix is returned'
-            result == 'tree'
-        and: 'schema source cache is used (i.e. need to build schema context)'
-            1 * mockYangTextSchemaSourceSetCache.get(*_) >> mockYangTextSchemaSourceSet
-    }
-
 }
diff --git a/cps-service/src/test/resources/application.yml b/cps-service/src/test/resources/application.yml
index b666885f22..be71d37d2a 100644
--- a/cps-service/src/test/resources/application.yml
+++ b/cps-service/src/test/resources/application.yml
@@ -1,6 +1,6 @@
 #  ============LICENSE_START=======================================================
 #  Copyright (c) 2021 Bell Canada.
-#  Modification Copyright (C) 2022 Nordix Foundation.
+#  Modification Copyright (C) 2022-2024 Nordix Foundation.
 #  ================================================================================
 #  Licensed under the Apache License, Version 2.0 (the "License");
 #  you may not use this file except in compliance with the License.
@@ -41,11 +41,3 @@ spring:
 logging:
   level:
     org.apache.kafka: ERROR
-
-# Custom Hazelcast Config.
-hazelcast:
-  cluster-name: "cps-and-ncmp-test-caches"
-  mode:
-    kubernetes:
-      enabled: false
-      service-name: "cps-and-ncmp-service"