diff options
author | ToineSiebelink <toine.siebelink@est.tech> | 2024-06-25 14:40:40 +0100 |
---|---|---|
committer | ToineSiebelink <toine.siebelink@est.tech> | 2024-06-26 15:03:09 +0100 |
commit | e18239631ff2f2f56961c8534a0edf294ee15fdd (patch) | |
tree | 450362e84841abbf97935dcb31adb2f1dd160d03 /cps-application | |
parent | 37d82d5d54ede4c05862fe648911c383d253cec3 (diff) |
Move TrustLevel Feature
-Moved TrustLevel impl from Controller to Inventory Facade
-Applied new package name convention using impl\inventory\trustlevel for this (sub)feature
-Renamed some trustlevel related classes to better describe their role
-Disabled failing architecture test (agreed this is tech. debt and created CPS-2293)
-Refactored YangDataConverter method names and signatures (moved Spec to correct place)
-Cleaned up names and javadoc of class now called DeviceTrustLevelMessageConsumer
-Applied conventions to modified test methods
Issue-ID: CPS-2255
Change-Id: Iccd20541488e6b61444bb2c7406c90e61a34124d
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Diffstat (limited to 'cps-application')
-rw-r--r-- | cps-application/src/test/java/org/onap/cps/architecture/LayeredArchitectureTest.java | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/cps-application/src/test/java/org/onap/cps/architecture/LayeredArchitectureTest.java b/cps-application/src/test/java/org/onap/cps/architecture/LayeredArchitectureTest.java index c18a3ed10b..91452a7fc5 100644 --- a/cps-application/src/test/java/org/onap/cps/architecture/LayeredArchitectureTest.java +++ b/cps-application/src/test/java/org/onap/cps/architecture/LayeredArchitectureTest.java @@ -25,6 +25,7 @@ import static com.tngtech.archunit.library.freeze.FreezingArchRule.freeze; import com.tngtech.archunit.core.importer.ImportOption; import com.tngtech.archunit.junit.AnalyzeClasses; +import com.tngtech.archunit.junit.ArchIgnore; import com.tngtech.archunit.junit.ArchTest; import com.tngtech.archunit.lang.ArchRule; @@ -47,12 +48,15 @@ public class LayeredArchitectureTest { private static final String CPS_CACHE_PACKAGE = "org.onap.cps.cache.."; private static final String CPS_EVENTS_PACKAGE = "org.onap.cps.events.."; + //TODO We need to revisit these rules, the first one doesn't even make any sense: CPS-2293 + @ArchTest static final ArchRule restControllerShouldOnlyDependOnRestController = classes().that().resideInAPackage(REST_CONTROLLER_PACKAGE).should().onlyHaveDependentClassesThat() .resideInAPackage(REST_CONTROLLER_PACKAGE); @ArchTest + @ArchIgnore static final ArchRule apiOrSpiServiceShouldOnlyBeDependedOnByControllerAndServicesAndCommonUtilityPackages = freeze(classes().that().resideInAPackage(API_SERVICE_PACKAGE) .or().resideInAPackage(SPI_SERVICE_PACKAGE).should().onlyHaveDependentClassesThat() |