diff options
| author |   Parshad Patel <pars.patel@samsung.com> | 2018-07-24 19:15:27 +0900 |
|---|---|---|
| committer | Parshad Patel <pars.patel@samsung.com> | 2018-07-25 10:28:50 +0900 |
| commit | 47099b56dcecba622e574b37c0167a061d6f667b (patch) | |
| tree | fe2cc455332142d03ec1c2fcdb021b5df5d9788c /sli | |
| parent | cfabda23cb6dc6c98e3266228f3bd2f409591a2f (diff) | |
Fix sonar issues
Fix sonar issues in ccsdk/sli/core
Issue-ID: CCSDK-332
Change-Id: I2aee69cf410d8f9cb63f3a22aeb793a99e27d2c7
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Diffstat (limited to 'sli')
3 files changed, 9 insertions, 7 deletions
diff --git a/sli/common/src/main/java/org/onap/ccsdk/sli/core/sli/SvcLogicExpressionFactory.java b/sli/common/src/main/java/org/onap/ccsdk/sli/core/sli/SvcLogicExpressionFactory.java index c229cf59..d275e970 100644 --- a/sli/common/src/main/java/org/onap/ccsdk/sli/core/sli/SvcLogicExpressionFactory.java +++ b/sli/common/src/main/java/org/onap/ccsdk/sli/core/sli/SvcLogicExpressionFactory.java @@ -93,7 +93,7 @@ public class SvcLogicExpressionFactory { try { SvcLogicExpressionFactory.parse(sbuff.toString()); } catch (IOException e) { - e.printStackTrace(); + LOG.error("Exception in SvcLogicExpressionFactory.parse",e); } } } diff --git a/sli/provider/src/main/java/org/onap/ccsdk/sli/core/sli/provider/ForNodeExecutor.java b/sli/provider/src/main/java/org/onap/ccsdk/sli/core/sli/provider/ForNodeExecutor.java index 6c6b4ca2..a73fadcf 100644 --- a/sli/provider/src/main/java/org/onap/ccsdk/sli/core/sli/provider/ForNodeExecutor.java +++ b/sli/provider/src/main/java/org/onap/ccsdk/sli/core/sli/provider/ForNodeExecutor.java @@ -101,7 +101,7 @@ public class ForNodeExecutor extends SvcLogicNodeExecutor { } } } catch (BreakNodeException br) { - LOG.debug("ForNodeExecutor caught break"); + LOG.error("ForNodeExecutor caught break",br); } return (null); } diff --git a/sli/provider/src/main/java/org/onap/ccsdk/sli/core/sli/provider/MdsalHelper.java b/sli/provider/src/main/java/org/onap/ccsdk/sli/core/sli/provider/MdsalHelper.java index e50b9974..f7a229d5 100644 --- a/sli/provider/src/main/java/org/onap/ccsdk/sli/core/sli/provider/MdsalHelper.java +++ b/sli/provider/src/main/java/org/onap/ccsdk/sli/core/sli/provider/MdsalHelper.java @@ -1117,8 +1117,11 @@ public class MdsalHelper { Class returnClass = m.getReturnType(); String fieldName = toLowerHyphen(m.getName().substring(3)); - fieldName = fieldName.substring(0, 1).toLowerCase() + fieldName.substring(1); - + if(fieldName!=null) { + fieldName = fieldName.substring(0, 1).toLowerCase() + fieldName.substring(1); + }else { + fieldName=""; + } String propName = propNamePfx + "." + fieldName; // Is the return type a yang generated class? @@ -1182,11 +1185,10 @@ public class MdsalHelper { } public static boolean isYangGenerated(Class c) { - if (c == null) { - return (false); - } else { + if (c != null) { return (c.getName().startsWith("org.opendaylight.yang.gen.")); } + return false; } public static boolean isIpPrefix(Class c) { |