minor sli provider base changes

add more unit testing, use constants for success/failure and improve some logging calls

Issue-ID: CCSDK-2064
Signed-off-by: Smokowski, Kevin (ks6305) <kevin.smokowski@att.com>
Change-Id: I2c7039c706de1172bd506a20e96eb987cc86f211

2 files changed, 21 insertions, 1 deletions

diff --git a/sli/common/src/main/java/org/onap/ccsdk/sli/core/sli/SvcLogicConstants.java b/sli/common/src/main/java/org/onap/ccsdk/sli/core/sli/SvcLogicConstants.java
new file mode 100644
index 00000000..61bfe7c2
--- /dev/null
+++ b/sli/common/src/main/java/org/onap/ccsdk/sli/core/sli/SvcLogicConstants.java
@@ -0,0 +1,7 @@
+package org.onap.ccsdk.sli.core.sli;
+
+public class SvcLogicConstants {
+    public final static String SUCCESS = "success";
+    public final static String FAILURE = "failure";
+
+}
diff --git a/sli/common/src/main/java/org/onap/ccsdk/sli/core/sli/SvcLogicContext.java b/sli/common/src/main/java/org/onap/ccsdk/sli/core/sli/SvcLogicContext.java
index b592c15f..549e6364 100644
--- a/sli/common/src/main/java/org/onap/ccsdk/sli/core/sli/SvcLogicContext.java
+++ b/sli/common/src/main/java/org/onap/ccsdk/sli/core/sli/SvcLogicContext.java
@@ -40,7 +40,7 @@ public class SvcLogicContext {
 
 	private HashMap<String, String> attributes;
 
-	private String status = "success";
+    private String status = SvcLogicConstants.SUCCESS;
 
 	public SvcLogicContext()
 	{
@@ -91,15 +91,28 @@ public class SvcLogicContext {
 	{
 		return attributes.keySet();
 	}
+  public Boolean isSuccess() {
+        return status.equals(SvcLogicConstants.SUCCESS);
+  }
 
+    @Deprecated
 	public String getStatus() {
 		return status;
 	}
 
+    @Deprecated
 	public void setStatus(String status) {
 		this.status = status;
 	}
 
+    public void markFailed() {
+        this.status = SvcLogicConstants.FAILURE;
+    }
+
+    public void markSuccess() {
+        this.status = SvcLogicConstants.SUCCESS;
+    }
+
 	public Properties toProperties()
 	{
 		Properties props = new Properties();