aboutsummaryrefslogtreecommitdiffstats
path: root/dblib/provider/src/main/java/org/onap/ccsdk/sli/core/dblib/factory
diff options
context:
space:
mode:
authorBharat saraswal <bharat.saraswal@huawei.com>2017-09-21 11:17:57 +0530
committerBharat saraswal <bharat.saraswal@huawei.com>2017-09-21 05:52:02 +0000
commited6aaf35dabae4070dba5c41798e351c25e8ce4d (patch)
treedfae2d5855be345aa5279997ab0f35e87a1d96fe /dblib/provider/src/main/java/org/onap/ccsdk/sli/core/dblib/factory
parent630809c9b6b8f9ed1ff3f875d3c9849db52139e0 (diff)
Fix Sonar Issues in sli/core module
Few major issues *Remove unused variables To increase code readability *Replace the type specification with the diamond operator *Add the "@Override" annotation above this method signature To increase code readability" Issue-Id: CCSDK-87 Change-Id: I2f0c16a83ab10a0a3e39a2a1d4db3c195ec2bba8 Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
Diffstat (limited to 'dblib/provider/src/main/java/org/onap/ccsdk/sli/core/dblib/factory')
-rw-r--r--dblib/provider/src/main/java/org/onap/ccsdk/sli/core/dblib/factory/DBConfigFactory.java120
1 files changed, 62 insertions, 58 deletions
diff --git a/dblib/provider/src/main/java/org/onap/ccsdk/sli/core/dblib/factory/DBConfigFactory.java b/dblib/provider/src/main/java/org/onap/ccsdk/sli/core/dblib/factory/DBConfigFactory.java
index 3caa7767..c3503576 100644
--- a/dblib/provider/src/main/java/org/onap/ccsdk/sli/core/dblib/factory/DBConfigFactory.java
+++ b/dblib/provider/src/main/java/org/onap/ccsdk/sli/core/dblib/factory/DBConfigFactory.java
@@ -24,7 +24,6 @@ package org.onap.ccsdk.sli.core.dblib.factory;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.Properties;
-
import org.onap.ccsdk.sli.core.dblib.config.BaseDBConfiguration;
import org.onap.ccsdk.sli.core.dblib.config.DbConfigPool;
import org.onap.ccsdk.sli.core.dblib.config.JDBCConfiguration;
@@ -39,61 +38,66 @@ import org.slf4j.LoggerFactory;
*/
public class DBConfigFactory {
- public static DbConfigPool createConfig(Properties resource) {
- return getConfigparams(resource);
- }
-
- static DbConfigPool getConfigparams(Properties properties){
- DbConfigPool xmlConfig = new DbConfigPool(properties);
- ArrayList<Properties> propertySets = new ArrayList<Properties>();
-
- if("JDBC".equalsIgnoreCase(xmlConfig.getType())) {
- String hosts = properties.getProperty(BaseDBConfiguration.DATABASE_HOSTS);
- if(hosts == null || hosts.isEmpty()) {
- propertySets.add(properties);
- } else {
- String[] newhost = hosts.split(",");
- for(int i=0; i< newhost.length; i++) {
- Properties localset = new Properties();
- localset.putAll(properties);
- String url = localset.getProperty(BaseDBConfiguration.DATABASE_URL);
- if(url.contains("DBHOST"))
- url = url.replace("DBHOST", newhost[i]);
- if(url.contains("dbhost"))
- url = url.replace("dbhost", newhost[i]);
- localset.setProperty(BaseDBConfiguration.DATABASE_URL, url);
- localset.setProperty(BaseDBConfiguration.CONNECTION_NAME, newhost[i]);
- propertySets.add(localset);
- }
- }
- } else {
- propertySets.add(properties);
- }
- try {
- Iterator<Properties> it = propertySets.iterator();
- while(it.hasNext()) {
- BaseDBConfiguration config = parse(it.next());
- xmlConfig.addConfiguration(config);
- }
-
- } catch (Exception e) {
- LoggerFactory.getLogger(DBConfigFactory.class).warn("",e);
- }
-
- return xmlConfig;
- }
-
- public static BaseDBConfiguration parse(Properties props) throws Exception {
-
- String type = props.getProperty(BaseDBConfiguration.DATABASE_TYPE);
-
- BaseDBConfiguration config = null;
-
- if("JDBC".equalsIgnoreCase(type)) {
- config = new JDBCConfiguration(props);
- }
-
- return config;
-
- }
+ public static DbConfigPool createConfig(Properties resource) {
+ return getConfigparams(resource);
+ }
+
+ static DbConfigPool getConfigparams(Properties properties) {
+ DbConfigPool xmlConfig = new DbConfigPool(properties);
+ ArrayList<Properties> propertySets = new ArrayList<Properties>();
+
+ if ("JDBC".equalsIgnoreCase(xmlConfig.getType())) {
+ String hosts = properties.getProperty(BaseDBConfiguration.DATABASE_HOSTS);
+ if (hosts == null || hosts.isEmpty()) {
+ propertySets.add(properties);
+ } else {
+ setPropertyWhenHostsNonEmpty(hosts, properties, propertySets);
+ }
+ } else {
+ propertySets.add(properties);
+ }
+ try {
+ Iterator<Properties> it = propertySets.iterator();
+ while (it.hasNext()) {
+ BaseDBConfiguration config = parse(it.next());
+ xmlConfig.addConfiguration(config);
+ }
+ } catch (Exception e) {
+ LoggerFactory.getLogger(DBConfigFactory.class).warn("", e);
+ }
+
+ return xmlConfig;
+ }
+
+ private static void setPropertyWhenHostsNonEmpty(String hosts, Properties properties, ArrayList<Properties>
+ propertySets) {
+ String[] newhost = hosts.split(",");
+ for (String aNewhost : newhost) {
+ Properties localSet = new Properties();
+ localSet.putAll(properties);
+ String url = localSet.getProperty(BaseDBConfiguration.DATABASE_URL);
+ if (url.contains("DBHOST")) {
+ url = url.replace("DBHOST", aNewhost);
+ }
+ if (url.contains("dbhost")) {
+ url = url.replace("dbhost", aNewhost);
+ }
+ localSet.setProperty(BaseDBConfiguration.DATABASE_URL, url);
+ localSet.setProperty(BaseDBConfiguration.CONNECTION_NAME, aNewhost);
+ propertySets.add(localSet);
+ }
+ }
+
+ public static BaseDBConfiguration parse(Properties props) throws Exception {
+
+ String type = props.getProperty(BaseDBConfiguration.DATABASE_TYPE);
+
+ BaseDBConfiguration config = null;
+
+ if ("JDBC".equalsIgnoreCase(type)) {
+ config = new JDBCConfiguration(props);
+ }
+
+ return config;
+ }
}