Fix for provider rpc error

Change over to using blueprint for rpc registration

Tests cases will need to be modified and uncommented

Change-Id: I6535c2d9d141406ac29dc8bb2b769fea3bdbf53f
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1185

3 files changed, 59 insertions, 158 deletions

diff --git a/appc-provider/appc-provider-bundle/src/main/resources/OSGI-INF/blueprint/blueprint.xml b/appc-provider/appc-provider-bundle/src/main/resources/OSGI-INF/blueprint/blueprint.xml
deleted file mode 100644
index c47bac7ae..000000000
--- a/appc-provider/appc-provider-bundle/src/main/resources/OSGI-INF/blueprint/blueprint.xml
+++ /dev/null
@@ -1,38 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-  ============LICENSE_START=======================================================
-  ONAP : APPC
-  ================================================================================
-  Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved.
-  ================================================================================
-  Copyright (C) 2017 Amdocs
-  =============================================================================
-  Licensed under the Apache License, Version 2.0 (the "License");
-  you may not use this file except in compliance with the License.
-  You may obtain a copy of the License at
-  
-       http://www.apache.org/licenses/LICENSE-2.0
-  
-  Unless required by applicable law or agreed to in writing, software
-  distributed under the License is distributed on an "AS IS" BASIS,
-  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  See the License for the specific language governing permissions and
-  limitations under the License.
-  
-  ============LICENSE_END=========================================================
-  -->
-
-<!--
-    Starter Blueprint Camel Definition appc-aai-adapter-blueprint
--->
-<blueprint xmlns="http://www.osgi.org/xmlns/blueprint/v1.0.0"
-                       xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-                       xsi:schemaLocation="http://www.osgi.org/xmlns/blueprint/v1.0.0 http://www.osgi.org/xmlns/blueprint/v1.0.0/blueprint.xsd">
-<!--<bean id="requestDispatcher" class="org.onap.appc.requesthandler.impl.RequestHandlerImpl" scope="singleton" >
-</bean>
-
-<service id="requestDispatcherService" interface="org.onap.appc.requesthandler.RequestHandler" ref="requestDispatcher"/>
-
-<reference id="aaiAdapter" availability="mandatory" activation="eager" interface="org.onap.appc.adapter.aai.AAIAdapter"/>-->
-
-</blueprint>
diff --git a/appc-provider/appc-provider-bundle/src/main/resources/initial/appc-provider.xml b/appc-provider/appc-provider-bundle/src/main/resources/initial/appc-provider.xml
deleted file mode 100644
index b7de48c5a..000000000
--- a/appc-provider/appc-provider-bundle/src/main/resources/initial/appc-provider.xml
+++ /dev/null
@@ -1,120 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-  ============LICENSE_START=======================================================
-  ONAP : APPC
-  ================================================================================
-  Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved.
-  ================================================================================
-  Copyright (C) 2017 Amdocs
-  =============================================================================
-  Licensed under the Apache License, Version 2.0 (the "License");
-  you may not use this file except in compliance with the License.
-  You may obtain a copy of the License at
-  
-       http://www.apache.org/licenses/LICENSE-2.0
-  
-  Unless required by applicable law or agreed to in writing, software
-  distributed under the License is distributed on an "AS IS" BASIS,
-  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  See the License for the specific language governing permissions and
-  limitations under the License.
-  
-  ============LICENSE_END=========================================================
-  -->
-
-<!-- vi: set et smarttab sw=4 tabstop=4: -->
-<snapshot>
-	<configuration>
-		<data xmlns="urn:ietf:params:xml:ns:netconf:base:1.0">
-			<modules xmlns="urn:opendaylight:params:xml:ns:yang:controller:config">
-				<module>
-
-					<!-- This xmlns:prefix should match the namespace in the *-provider-impl.yang 
-						file The prefix: inside type should match the prefix of the yang file. -->
-					<type xmlns:prefix="org:onap:appc:provider:impl">
-						prefix:appc-provider-impl
-					</type>
-					<name>appc-provider-impl</name>
-
-					<!-- The following sections contain bindings to services defined in 
-						the *-provider-impl yang file. For example the rpc-registry is required because 
-						we have a dependency (or augmentation) named "rpc-registry" and which binds 
-						to the md-sa-binding-registry. If you remove those dependencies from the 
-						yang file then you can remove them from here. -->
-					<rpc-registry>
-						<type
-							xmlns:binding="urn:opendaylight:params:xml:ns:yang:controller:md:sal:binding">binding:binding-rpc-registry</type>
-						<name>binding-rpc-broker</name>
-					</rpc-registry>
-
-					<data-broker>
-						<type
-							xmlns:binding="urn:opendaylight:params:xml:ns:yang:controller:md:sal:binding">binding:binding-async-data-broker</type>
-						<name>binding-data-broker</name>
-					</data-broker>
-
-					<notification-service>
-						<type
-							xmlns:binding="urn:opendaylight:params:xml:ns:yang:controller:md:sal:binding">
-							binding:binding-notification-service
-						</type>
-						<name>binding-notification-broker</name>
-					</notification-service>
-				</module>
-
-				<module>
-
-					<!-- This xmlns:prefix should match the namespace in the *-provider-impl.yang
-						file The prefix: inside type should match the prefix of the yang file. -->
-					<type xmlns:prefix="org:onap:appc:provider:lcm:impl">
-						prefix:appc-provider-lcm-impl
-					</type>
-					<name>appc-provider-lcm-impl</name>
-
-					<!-- The following sections contain bindings to services defined in
-						the *-provider-impl yang file. For example the rpc-registry is required because
-						we have a dependency (or augmentation) named "rpc-registry" and which binds
-						to the md-sa-binding-registry. If you remove those dependencies from the
-						yang file then you can remove them from here. -->
-					<rpc-registry>
-						<type
-								xmlns:binding="urn:opendaylight:params:xml:ns:yang:controller:md:sal:binding">binding:binding-rpc-registry</type>
-						<name>binding-rpc-broker</name>
-					</rpc-registry>
-
-					<data-broker>
-						<type
-								xmlns:binding="urn:opendaylight:params:xml:ns:yang:controller:md:sal:binding">binding:binding-async-data-broker</type>
-						<name>binding-data-broker</name>
-					</data-broker>
-
-					<notification-service>
-						<type
-								xmlns:binding="urn:opendaylight:params:xml:ns:yang:controller:md:sal:binding">
-							binding:binding-notification-service
-						</type>
-						<name>binding-notification-broker</name>
-					</notification-service>
-				</module>
-
-
-			</modules>
-		</data>
-
-	</configuration>
-
-	<!-- Required capabilities are basically a listing of all modules that need 
-		to be imported before our service can be resolved. Capabilities for dependencies 
-		defined above are implied which is why we do not have define a required capability 
-		for the data broker, for example. -->
-	<!-- <required-capabilities> -->
-	<!-- <capability>appc:training:sample:provider:impl?module=sample-provider-impl&amp;revision=2014-05-23</capability> -->
-	<!-- </required-capabilities> -->
-	<required-capabilities>
-		<capability>org:onap:appc:provider:impl?module=appc-provider-impl&amp;revision=2014-05-23
-		</capability>
-		<capability>org:onap:appc:provider:lcm:impl?module=appc-provider-lcm-impl&amp;revision=2016-01-08
-		</capability>
-	</required-capabilities>
-
-</snapshot>
diff --git a/appc-provider/appc-provider-bundle/src/main/resources/org/opendaylight/blueprint/provider-blueprint.xml b/appc-provider/appc-provider-bundle/src/main/resources/org/opendaylight/blueprint/provider-blueprint.xml
new file mode 100644
index 000000000..0c03369bd
--- /dev/null
+++ b/appc-provider/appc-provider-bundle/src/main/resources/org/opendaylight/blueprint/provider-blueprint.xml
@@ -0,0 +1,59 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ============LICENSE_START=======================================================
+  ONAP : APPC
+  ================================================================================
+  Copyright (C) 2018 AT&T Intellectual Property. All rights reserved.
+  ================================================================================
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+  
+       http://www.apache.org/licenses/LICENSE-2.0
+  
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+  ============LICENSE_END=========================================================
+  -->
+<blueprint xmlns="http://www.osgi.org/xmlns/blueprint/v1.0.0"
+           xmlns:odl="http://opendaylight.org/xmlns/blueprint/v1.0.0"
+           odl:use-default-for-reference-types="true">
+
+    <reference id="svcLogicService"
+               interface="org.onap.ccsdk.sli.core.sli.provider.SvcLogicService" />
+
+    <bean id="client" class="org.onap.appc.provider.AppcProviderClient">
+        <argument ref="svcLogicService" />
+    </bean>
+
+    <reference id="dataBroker"
+               interface="org.opendaylight.controller.md.sal.binding.api.DataBroker"
+               odl:type="default" />
+
+    <reference id="notificationService"
+               interface="org.opendaylight.controller.md.sal.binding.api.NotificationPublishService"
+               odl:type="default" />
+
+    <reference id="rpcRegistry"
+               interface="org.opendaylight.controller.sal.binding.api.RpcProviderRegistry"
+               odl:type="default" />
+
+    <bean id="provider" class="org.onap.appc.provider.AppcProvider">
+        <argument ref="dataBroker" />
+        <argument ref="notificationService" />
+        <argument ref="rpcRegistry" />
+        <argument ref="client" />
+    </bean>
+    <bean id="provider-lcm" class="org.onap.appc.provider.AppcProviderLcm">
+        <argument ref="dataBroker" />
+        <argument ref="notificationService" />
+        <argument ref="rpcRegistry" />
+    </bean>
+
+    <odl:rpc-implementation ref="provider"/>
+    <odl:rpc-implementation ref="provider-lcm"/>
+
+</blueprint>
\ No newline at end of file