diff options
author | 2019-02-08 15:38:18 +0000 | |
---|---|---|
committer | 2019-02-08 21:23:37 +0000 | |
commit | 74cf8508ab0a778aec0a38e3786b1f17f1596385 (patch) | |
tree | f347cef89e90dc92c640a2ad6a8af106e413ce13 /appc-dispatcher/appc-workflow-management/appc-workflow-management-core/src/main | |
parent | 899c2f1520b1ec529bf6b4faef6623ea566634dd (diff) |
Test coverage in workflow-impl
Increased package coverage to 83%
Issue-ID: APPC-1408
Change-Id: I24b634ee7926bac2a196256cd20362d2f7b93b76
Signed-off-by: Joss Armstrong <joss.armstrong@ericsson.com>
Diffstat (limited to 'appc-dispatcher/appc-workflow-management/appc-workflow-management-core/src/main')
-rw-r--r-- | appc-dispatcher/appc-workflow-management/appc-workflow-management-core/src/main/java/org/onap/appc/workflow/impl/WorkFlowManagerImpl.java | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/appc-dispatcher/appc-workflow-management/appc-workflow-management-core/src/main/java/org/onap/appc/workflow/impl/WorkFlowManagerImpl.java b/appc-dispatcher/appc-workflow-management/appc-workflow-management-core/src/main/java/org/onap/appc/workflow/impl/WorkFlowManagerImpl.java index e6edc2657..000415c93 100644 --- a/appc-dispatcher/appc-workflow-management/appc-workflow-management-core/src/main/java/org/onap/appc/workflow/impl/WorkFlowManagerImpl.java +++ b/appc-dispatcher/appc-workflow-management/appc-workflow-management-core/src/main/java/org/onap/appc/workflow/impl/WorkFlowManagerImpl.java @@ -95,18 +95,18 @@ public class WorkFlowManagerImpl implements WorkFlowManager{ /* The following method call (populateDGContext) populates DG context with the request parameters to maintain backward compatibility with old DGs, - we are not altering the old way of passing (org.onap.appc.vnfId and so on..) + we are not altering the old way of passing (org.onap.appc.vnfId and so on..) This is still a temporary solution, the end solution should be agreed with all stakeholders and implemented. - */ - populateDGContext(workflowParams,workflowRequest); + */ + populateDGContext(workflowParams, workflowRequest); } else { actionProperty = configuration.getProperty("org.onap.appc.workflow.action", String.valueOf(Constants.ACTION)); requestIdProperty = configuration.getProperty("org.onap.appc.workflow.request.id", String.valueOf(Constants.REQUEST_ID)); vfIdProperty = configuration.getProperty("org.onap.appc.workflow.vfid", String.valueOf(Constants.VF_ID)); String vfTypeProperty = configuration.getProperty("org.onap.appc.workflow.vftype", String.valueOf(Constants.VF_TYPE)); String apiVerProperty = configuration.getProperty("org.onap.appc.workflow.apiVersion", String.valueOf(Constants.API_VERSION)); - String originatorIdProperty = configuration.getProperty("org.onap.appc.workflow.originatorId", Constants.ORIGINATOR_ID); + String originatorIdProperty = configuration.getProperty("org.onap.appc.workflow.originatorId", Constants.ORIGINATOR_ID); String subRequestId = configuration.getProperty("org.onap.appc.workflow.subRequestId", Constants.SUB_REQUEST_ID); workflowParams.put(actionProperty, workflowRequest.getRequestContext().getAction().name()); @@ -177,7 +177,7 @@ public class WorkFlowManagerImpl implements WorkFlowManager{ workflowParams.put("input.action-identifiers.vf-module-id",workflowRequest.getRequestContext().getActionIdentifiers().getVfModuleId() !=null ? workflowRequest.getRequestContext().getActionIdentifiers().getVfModuleId() : ""); final Map<String, String> additionalContext; - if ((additionalContext = workflowRequest.getRequestContext().getAdditionalContext())!=null) { + if ((additionalContext = workflowRequest.getRequestContext().getAdditionalContext()) != null) { for (Map.Entry<String, String> entry : additionalContext.entrySet()) { workflowParams.put("input." + entry.getKey(), null != entry.getValue() ? entry.getValue() : ""); } @@ -245,7 +245,7 @@ public class WorkFlowManagerImpl implements WorkFlowManager{ setWorkFlowResponseStatus(workflowResponse.getResponseContext(), "failure", "Unexpected SLI Adapter failure", 200); if (logger.isDebugEnabled()) { logger.debug("Error while executing DG " + e.getMessage() + e.getStackTrace()); - logger.error("Error in DG", e.getMessage()+ Arrays.toString(e.getStackTrace()),e); + logger.error("Error in DG", e.getMessage() + Arrays.toString(e.getStackTrace()), e); } } |