diff options
| author |   Rupinder <rupinsi1@in.ibm.com> | 2020-05-14 13:04:15 +0530 |
|---|---|---|
| committer |   Takamune Cho <takamune.cho@att.com> | 2020-05-15 20:28:40 +0000 |
| commit | fc616287f11ebe888cbbbf866d983cddbb193f1a (patch) | |
| tree | 89faaa5b335ce097a2e41cce48d726f25d83a2d9 | |
| parent | 14496b672e66416ef3915777059c7971176a3967 (diff) | |
worked on code smells
Removed some unused imports and reorder the modifiers to comply with
java language
Issue-ID: APPC-1859
Change-Id: Ieaf032f7d4466186b4813e6dcee5c475e4472d4d
Signed-off-by: Rupinder <rupinsi1@in.ibm.com>
2 files changed, 5 insertions, 9 deletions
diff --git a/appc-provider/appc-provider-bundle/src/main/java/org/onap/appc/provider/lcm/service/DistributeTrafficCheckService.java b/appc-provider/appc-provider-bundle/src/main/java/org/onap/appc/provider/lcm/service/DistributeTrafficCheckService.java index 893c058ae..85a01313f 100644 --- a/appc-provider/appc-provider-bundle/src/main/java/org/onap/appc/provider/lcm/service/DistributeTrafficCheckService.java +++ b/appc-provider/appc-provider-bundle/src/main/java/org/onap/appc/provider/lcm/service/DistributeTrafficCheckService.java @@ -23,14 +23,10 @@ package org.onap.appc.provider.lcm.service; import org.onap.appc.executor.objects.LCMCommandStatus; import org.onap.appc.requesthandler.objects.RequestHandlerInput; -import org.onap.appc.util.JsonUtil; import org.opendaylight.yang.gen.v1.org.onap.appc.lcm.rev160108.Action; import org.opendaylight.yang.gen.v1.org.onap.appc.lcm.rev160108.DistributeTrafficCheckInput; import org.opendaylight.yang.gen.v1.org.onap.appc.lcm.rev160108.DistributeTrafficCheckOutputBuilder; -import java.io.IOException; -import java.util.Map; - /** * Provide LCM command service to check conditions and the result of DistributeTraffic. diff --git a/appc-provider/appc-provider-bundle/src/main/java/org/onap/appc/provider/topology/TopologyService.java b/appc-provider/appc-provider-bundle/src/main/java/org/onap/appc/provider/topology/TopologyService.java index 1a95d24ab..f13a456ad 100644 --- a/appc-provider/appc-provider-bundle/src/main/java/org/onap/appc/provider/topology/TopologyService.java +++ b/appc-provider/appc-provider-bundle/src/main/java/org/onap/appc/provider/topology/TopologyService.java @@ -84,11 +84,11 @@ public class TopologyService { private final EELFLogger auditLogger = EELFManager.getInstance().getAuditLogger(); private final EELFLogger metricsLogger = EELFManager.getInstance().getMetricsLogger(); private final EELFLogger performanceLogger = EELFManager.getInstance().getPerformanceLogger(); - private final static String RESTART_INITIATED_STR = "Metrics Logger: App-C Restart initiated. Start Time: [%s]. Request ID: [%s]"; - private final static String TARGET_PARAM = "target"; - private final static String SUCCESS_PARAM = "SUCCESS"; - private final static String FAILURE_PARAM = "FAILURE"; - private final static String ERROR_STR = "An error occurred"; + private static final String RESTART_INITIATED_STR = "Metrics Logger: App-C Restart initiated. Start Time: [%s]. Request ID: [%s]"; + private static final String TARGET_PARAM = "target"; + private static final String SUCCESS_PARAM = "SUCCESS"; + private static final String FAILURE_PARAM = "FAILURE"; + private static final String ERROR_STR = "An error occurred"; /** * The provider we are servicing |