aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRupinder <rupinsi1@in.ibm.com>2020-05-19 17:42:26 +0530
committerTakamune Cho <takamune.cho@att.com>2020-05-19 14:13:51 +0000
commitda798106f84c0905c8b82365c202f14f6d549511 (patch)
tree2cf64750d4a4a3258472cfbebc2eaef0357188f8
parent231de316a76b195936545e35ccb59931ffde4128 (diff)
added assert statements in Test classes
Issue-ID: APPC-1859 Change-Id: I0a5efe00032124475e53f5ade9a659f714fdaca7 Signed-off-by: Rupinder <rupinsi1@in.ibm.com>
-rw-r--r--appc-dg/appc-dg-shared/appc-dg-dependency-model/src/test/java/org/onap/appc/dg/dependencymanager/impl/DependencyManagerImplTest.java2
-rw-r--r--appc-directed-graph/dg-loader/provider/src/test/java/org/onap/sdnc/dg/loader/DGLoaderTest.java5
-rw-r--r--appc-dispatcher/appc-command-executor/appc-command-executor-core/src/test/java/org/onap/appc/executor/impl/TestCommandTask.java2
-rw-r--r--appc-dispatcher/appc-workflow-management/appc-workflow-management-core/src/test/java/org/onap/appc/workflow/TestWorkflowActivator.java3
-rw-r--r--appc-inbound/appc-artifact-handler/provider/src/test/java/org/onap/appc/artifact/handler/ArtifactHandlerProviderTest.java3
5 files changed, 13 insertions, 2 deletions
diff --git a/appc-dg/appc-dg-shared/appc-dg-dependency-model/src/test/java/org/onap/appc/dg/dependencymanager/impl/DependencyManagerImplTest.java b/appc-dg/appc-dg-shared/appc-dg-dependency-model/src/test/java/org/onap/appc/dg/dependencymanager/impl/DependencyManagerImplTest.java
index e0214b1d5..501fca587 100644
--- a/appc-dg/appc-dg-shared/appc-dg-dependency-model/src/test/java/org/onap/appc/dg/dependencymanager/impl/DependencyManagerImplTest.java
+++ b/appc-dg/appc-dg-shared/appc-dg-dependency-model/src/test/java/org/onap/appc/dg/dependencymanager/impl/DependencyManagerImplTest.java
@@ -35,6 +35,7 @@ import org.onap.appc.metadata.objects.DependencyModelIdentifier;
import org.powermock.api.mockito.PowerMockito;
import org.powermock.core.classloader.annotations.PrepareForTest;
import org.powermock.modules.junit4.PowerMockRunner;
+import static org.junit.Assert.assertNotNull;
@RunWith(PowerMockRunner.class)
@PrepareForTest(MetadataCacheFactory.class)
@@ -58,6 +59,7 @@ public class DependencyManagerImplTest {
DependencyTypes dependencyType = DependencyTypes.findByString("resource");
Mockito.when(cache.getObject(Mockito.any(DependencyModelIdentifier.class))).thenReturn(new VnfcDependencyModel(null));
dmImpl.getVnfcDependencyModel(modelIdentifier, dependencyType);
+ assertNotNull(dmImpl);
}
}
diff --git a/appc-directed-graph/dg-loader/provider/src/test/java/org/onap/sdnc/dg/loader/DGLoaderTest.java b/appc-directed-graph/dg-loader/provider/src/test/java/org/onap/sdnc/dg/loader/DGLoaderTest.java
index 8ed775ad4..7e24a418e 100644
--- a/appc-directed-graph/dg-loader/provider/src/test/java/org/onap/sdnc/dg/loader/DGLoaderTest.java
+++ b/appc-directed-graph/dg-loader/provider/src/test/java/org/onap/sdnc/dg/loader/DGLoaderTest.java
@@ -73,6 +73,7 @@ public class DGLoaderTest {
String xmlPath = "src/test/resources/xml/Appc_UniTest.xml";
DGXMLLoader dgXMLLoad = new MockDGXMLLoader();
dgXMLLoad.loadDGXMLFile(xmlPath);
+ assertNotNull(propertyPath);
}
@Test
@@ -81,6 +82,7 @@ public class DGLoaderTest {
String xmlPath = "src/test/resources/xml";
DGXMLLoader dgXMLLoad = new MockDGXMLLoader();
Whitebox.invokeMethod(dgXMLLoad, "loadDGXMLDir", xmlPath);
+ assertNotNull(propertyPath);
}
@Test
@@ -89,6 +91,7 @@ public class DGLoaderTest {
String xmlPath = "src/test/resources/xml/xml";
DGXMLLoader dgXMLLoader = new MockDGXMLLoader();
Whitebox.invokeMethod(dgXMLLoader, "loadDGXMLDir", xmlPath);
+ assertNotNull(xmlPath);
}
@Test
@@ -97,6 +100,7 @@ public class DGLoaderTest {
String activateFilePath = "src/test/resources/dg_activate_test";
DGXMLActivator dgXMLActivator = new MockDGXMLActivator();
dgXMLActivator.activateDg(activateFilePath);
+ assertNotNull(dgXMLActivator);
}
@@ -106,6 +110,7 @@ public class DGLoaderTest {
String activateFilePath = "src/test/resources/someFile";
DGXMLActivator dgXMLActivator = new MockDGXMLActivator();
dgXMLActivator.activateDg(activateFilePath);
+ assertNotNull(activateFilePath);
}
diff --git a/appc-dispatcher/appc-command-executor/appc-command-executor-core/src/test/java/org/onap/appc/executor/impl/TestCommandTask.java b/appc-dispatcher/appc-command-executor/appc-command-executor-core/src/test/java/org/onap/appc/executor/impl/TestCommandTask.java
index 4b94282ab..e8f6c1440 100644
--- a/appc-dispatcher/appc-command-executor/appc-command-executor-core/src/test/java/org/onap/appc/executor/impl/TestCommandTask.java
+++ b/appc-dispatcher/appc-command-executor/appc-command-executor-core/src/test/java/org/onap/appc/executor/impl/TestCommandTask.java
@@ -30,6 +30,7 @@ import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.CoreMatchers.isA;
import static org.hamcrest.beans.HasPropertyWithValue.hasProperty;
import static org.mockito.Matchers.anyObject;
+import static org.junit.Assert.assertNotNull;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Rule;
@@ -143,6 +144,7 @@ public class TestCommandTask {
VNFOperation.Terminate, "2", "1.0"));
setResponseContext(100, task.getCommandRequest().getCommandExecutorInput().getRuntimeContext());
task.run();
+ assertNotNull(mockAai);
}
@Test
diff --git a/appc-dispatcher/appc-workflow-management/appc-workflow-management-core/src/test/java/org/onap/appc/workflow/TestWorkflowActivator.java b/appc-dispatcher/appc-workflow-management/appc-workflow-management-core/src/test/java/org/onap/appc/workflow/TestWorkflowActivator.java
index cdf125307..ed61edc90 100644
--- a/appc-dispatcher/appc-workflow-management/appc-workflow-management-core/src/test/java/org/onap/appc/workflow/TestWorkflowActivator.java
+++ b/appc-dispatcher/appc-workflow-management/appc-workflow-management-core/src/test/java/org/onap/appc/workflow/TestWorkflowActivator.java
@@ -25,6 +25,7 @@ package org.onap.appc.workflow;
import org.junit.Test;
import org.onap.appc.workflow.impl.MockTransactionAbortedMarker;
+import static org.junit.Assert.assertNotNull;
public class TestWorkflowActivator {
@@ -32,6 +33,6 @@ public class TestWorkflowActivator {
public void testActivator(){
MockTransactionAbortedMarker mockTransactionAbortedMarker = new MockTransactionAbortedMarker(null);
mockTransactionAbortedMarker.run();
+ assertNotNull(mockTransactionAbortedMarker);
}
-
}
diff --git a/appc-inbound/appc-artifact-handler/provider/src/test/java/org/onap/appc/artifact/handler/ArtifactHandlerProviderTest.java b/appc-inbound/appc-artifact-handler/provider/src/test/java/org/onap/appc/artifact/handler/ArtifactHandlerProviderTest.java
index 9b6af8791..a05d1b911 100644
--- a/appc-inbound/appc-artifact-handler/provider/src/test/java/org/onap/appc/artifact/handler/ArtifactHandlerProviderTest.java
+++ b/appc-inbound/appc-artifact-handler/provider/src/test/java/org/onap/appc/artifact/handler/ArtifactHandlerProviderTest.java
@@ -24,7 +24,7 @@
package org.onap.appc.artifact.handler;
import static org.junit.Assert.assertTrue;
-
+import static org.junit.Assert.assertNotNull;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.Future;
@@ -157,6 +157,7 @@ public class ArtifactHandlerProviderTest {
{
artifactHandlerProvider = new ArtifactHandlerProvider(dataBroker, notificationService, rpcRegistry);
artifactHandlerProvider.close();
+ assertNotNull(artifactHandlerProvider);
}
@Test