Age | Commit message (Collapse) | Author | Files | Lines |
|
wrote test case to test checkRefDataReqFields() funtion when action,
device-protocol and scope values are set to blank.
Issue-ID: APPC-1064
Change-Id: I405aca5092e631183e690bcd60b10439f1396568
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Unsubscribed from subscription in template-configuration component. This
will release any resources that the subscription holds when the
component is destroyed.
Issue-ID: APPC-1049
Change-Id: Icbf3575e034a693f7357782826690d079945faa7
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
wrote test case to test order-by-pipe to return proper value when
orderby parameter is not set.
Issue-ID: APPC-1064
Change-Id: I4496e9a3371b540ce0da63ef254a4d9bc4214710
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
wrote test case to test table-filter pipe to return proper value when no
query parameter is passed
Issue-ID: APPC-1064
Change-Id: I29826f3413fd8dfe7b86c6461f0d7a7a237520b4
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Wrote test cases to cover checkNotNull function in utility service.
Issue-ID: APPC-1064
Change-Id: Icb9dc8872634e8772349e1bbbb7f15f39d292aec
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
wrote test case to test checkRefDataReqFields() function to notify error
message when no valid template identifier is selected.
Issue-ID: APPC-1064
Change-Id: I083abfd29aac325938116c5acc604e737a0d09ae
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
wrote test case to test canActivate function to navigate user to login
page if the user is not logged in.
Issue-ID: APPC-1064
Change-Id: Icc5a137474f69b8f9a8c2bc386ecc2b784f64ebb
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
wrote unit test case to test openModel function of referenceDataForm
component.
Issue-ID: APPC-1064
Change-Id: I4dcd719876df1bd1ce4a30baa7131f081b9923b2
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
wrote test case to cover contains function of the directive
Issue-ID: APPC-1064
Change-Id: I510d121be6dff5c286a89db13bde5c9c46216e85
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
wrote test case to cover toggle function.
Issue-ID: APPC-1064
Change-Id: Ia10c602e385bb087114b16e58fed03ddc51b8d31
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
wrote test case to cover processApiSubscribe function on artifact upload
Issue-ID: APPC-1064
Change-Id: I9e01f6c9e9a099a5fff44924ed4158efeb56d467
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Moved few of the hardcoded values from reference-dataform component to
app-constants file as variables
Issue-ID: APPC-1054
Change-Id: Ib8afe569b7c669f50bf3eeec88deec27711c49a4
Signed-off-by: Arundathi patil <arundpil@in.ibm.com>
|
|
Added test case to cover canActivate method when referenceObject is not
defined.
Issue-ID: APPC-1064
Change-Id: I19d08cf1e0b6426e52d1db48be89ed8e76864560
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
added test case to cover fileChange() method in reference-data-form spec
file.
Issue-ID: APPC-1064
Change-Id: Id27e82a648e9bb578035bc90505e15b12a0c8654
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
removed fdescribe from auth-gurad-modal spec file which was accidentally checkedin in the previos checkin
Issue-ID: APPC-1064
Change-Id: I15856005e9ef7df13ec58e46287b6437d610917d
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Removed fdescribe from gcauth-guard spec file which was accidentally
checkdin in the previous change.
Issue-ID: APPC-1064
Change-Id: Iaefd0d3ed9d7909b0fb55b16a19070227ae6b86b
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
fixed test case 'should retrive PD from cache' that was failing with the
below error as it was expecting wrong value.
Error: Expected [ ] to be 'TEST PD INFORMATION'
In this test case, ngAfterViewInit() method is called which returns the
PD data. This PD data is stored into variable called
'displayParamObjects' and then this variable is returned to the calling
function.
The value for 'displayParamObjects' is set in getPDFromSession() method
which makes a async http call to get the PD data, so even before the
results of the async call are returned, ngAfterViewInit() method
returns the empty 'displayParamObject' variable.
Hence changed the expected value to the actual value returned by
ngAfterViewInit() method.
We can write a seperate test case to test the async call made by
getPDFromSession() method.
Issue-ID: APPC-1064
Change-Id: I0b8f38b6e52dc7478a4ab510ca3ff10ff81ae0ca
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Test case in param-name-value was failing as it was expecting wrong
value. Fixed this issue.
Issue-ID: APPC-1064
Change-Id: Iaee9cb29b40ee2e2e39632cd91ef81c91d9e8c1c
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Test cases in param-name-value.component.spec file failed with below
error,
Error: No Provider for Utility service
Fixed this error
Issue-ID: APPC-1064
Change-Id: Ie0e63be45b1cdde0bd2169168c562452babd6aa5
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Wrote test cases to cover gcauth guard service
Issue-ID: APPC-1064
Change-Id: Iaa01bc22b1fdb52f0cecb7b6c20502c8f6f05a14
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Wrote test case to cover auth-guard component
Issue-ID: APPC-1064
Change-Id: Id9da15a608fd7954c380cffac4d94044ae4fe1f5
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Test cases in test component spec file failed with below error,
Eroor: No provider for NgxSpinnerModule.
Fixed this error
Issue-ID: APPC-1064
Change-Id: I89db4044b3fbc62cae4656e93a6b4519fb5cd0aa
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Wrote test case to cover upload function in refernce-dataform.component
Issue-ID: APPC-1064
Change-Id: I44c62b944c14b9f66fc2117ad7d578b2388e973b
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Wrote test cases in uitilityService to cover processApiSubscribe
function
Issue-ID: APPC-1064
Change-Id: Id6852114581a761550f49fa59e749140d377f0fc
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Wrote test case to cover setValues method pf parameter-definitions
service
Issue-ID: APPC-1064
Change-Id: I5e43aba3c6af733cf20922036ef7ad09b86a7cdd
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Wrote test cases to cover updateAccessUpdatePages method in
build-artifacts component.
Issue-ID: APPC-1064
Change-Id: If654c89d1daf1d9639aa172c08f3270b6337ba0e
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Test case in aboutus component spec file failed with below error,
Error: this.http.get is not a function
Fixed this error
Issue-ID: APPC-1064
Change-Id: I59426d9a96ab67a7fbef6c540be26b7204a7ee7f
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Wrote test case to cover navigateToreference method of myVnfs component
Issue-ID: APPC-1064
Change-Id: Ie6417fb2e975164c9d5226d7e270ec4f7dbbdb1a
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Test case in userlogin form was expecting wrong values because of which
the test case failed. Changed the test case expecting values to proper
values.
Issue-ID: APPC-1064
Change-Id: I9b1aedc70a806b235c0b56d936370e8a1a62d2dd
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Test cases in userLogin-form spec file failed with below error,
Error: Cannot read property 'root' of undefined.
This error was because, activated route was not injected into the
testingbed. Fixed this error.
Issue-ID: APPC-1064
Change-Id: Ib9978b73be744204e8dd64b97abbc0959a4e5839
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Test cases in aboutus component spec file failed due to the changes made in ts
file. Fixed these issues
Issue-ID: APPC-1064
Change-Id: Ief9c517de5ecb57bac8787e064b2bec3f7c50f2c
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Removed ngbModal from imports and constructor as it was not used.
Issue-ID: APPC-1054
Change-Id: I92406941099384b1b17472d57c888041deb7e0a4
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Test cases in template-configuration spec file failed with the below
error,
Error: No provider for UtilityService.
Fixed this error.
Issue-ID: APPC-1064
Change-Id: Ibb580435a3f70024988434eba74b61be80423990
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
refactored payload in uploadArtifact method of reference dataform using
createPayloadForSave method of utlity service
Issue-ID: APPC-1100
Change-Id: I9f91725371da96e6d2384b2348e288ebc0af238d
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
added progress spinner for spreadsheet upload in test.component,ts
Issue-ID: APPC-1102
Change-Id: I9d030da990eae2e8efe5ae82cd1afd3c675aa286
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Moved the hard coded values from utility service file to app-contants
file as variables.
Issue-ID: APPC-1054
Change-Id: Iac62da47deeeb66402f413e90ee0ab50130ca185
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Test cases in parameter.component spec file failed with below error,
Error: No provider for NGXSpinnerService
Fixed this issue
Issue-ID: APPC-1064
Change-Id: I51d8e79888e182fef11d0c99936953ed0eabd380
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
refactored payload creation in retrieveNameValueFromAppc method of
param-name-value.component.ts by using the createPayloadForRetrieve
method in utility.service.ts
Issue-ID: APPC-1098
Change-Id: Ia5b4a7c259c9a27958b6df9c59869a79b03064ee
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Wrote test cases for loginGuardService
Issue-ID: APPC-1064
Change-Id: I9b742c860aa6a523b1c858380e8a025a621f01fd
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Wrote test cases for confirm modal component.
Issue-ID: APPC-1064
Change-Id: I6cac13f52730c31cd98e14fc8874012224b938f9
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Test cases in myvnfs component spec file failed with the below error,
Error: No provider for notification service
Fixed this issue
Issue-ID: APPC-1064
Change-Id: I39a451414e56b9db3eab7910c79d2d103b44380a
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
refactor payload creation in getPD parameter.ts using createPayloadForRetrieve
method in utility.service.ts
Issue-ID: APPC-1099
Change-Id: I976dfebfe60a123784853a7294125cf6075a653b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Test case was expecting wrong value from function in test.component.
fixed this issue.
Issue-ID: APPC-1064
Change-Id: I668778c0ae30f218204d652ed9efbd9bc0ace097
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
removed error messages that were hard coded in myvnfs component. Used
the variables from app-constants file for these errors.
Issue-ID: APPC-1064
Change-Id: I5acffb29e18cd0b135ee4bf206c507db26b9765c
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Wrote unit test cases for mapping-editor service. The covarage for this
file is now 75.96%
Issue-ID: APPC-1064
Change-Id: I4c413a076dd6194da9a19481c0fdc42f0ffe5789
Signed-off-by: Arundathi Patil<arundpil@in.ibm.com>
|
|
refactored payload creation for saving template and param artifacts to
APPC using createPayloadForSave method in utility.service.ts
Issue-ID: APPC-1105
Change-Id: I2dd446aebdbcbc1ffc070993ee53d09e25eeae6b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Test cases in param-name-value component spec file failed with the below
error,
Error: No provider for NgxSpinnerService
Fixed this error
Issue-ID: APPC-1064
Change-Id: Ib4e0b3276525973fb6a625d2366ed26cf3d94173
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Moved all the constant values in parameter component to app-Constants
file.
Issue-ID: APPC-1054
Change-Id: I507cc0a4aa8ddc8d6d42e97129b21a235b96b225
Signed-off-by: Arundathi Patil<arundpil@in.ibm.com>
|
|
This will remove all the duplicate code of ng-bootstrap popup.
Made following changes to the below files,
1. app.module.ts:
a. added the confirm modal component to declarations and entryComponents section because component will be created dynamically.
b. imported BootstrapModalModule from ng2-bootstrap-modal
2. vnfs.module.ts:
a. removed the confirm modal component from declarations and
entryComponents section as it is already declared as part of
app.module.ts.
3. confirm.component.ts:
a. added two more varibles 'cancelButtonText' and
'confirmButtonText' to ConfirmModel interface. these values will
be sent by the caller code and the button lables will be set
dynamically.
b. implemented cancel method that sets the modal result value to
false, this is called on click of close
button.
4. about.component.ts:
a. Made use of confirm.component.ts.
b. on click of 'view change log' buton we are calling open()
method which inturn opens the confirm modal component.
5. about.component.html:
a. Removed call to versionLogFile() method as this method is
called from open() method.
b. Removed the ng-template code of ng-bootstrap which is no more
required.
Issue-ID: APPC-1088
Change-Id: I9de545debed145ef35e31807acd1e9bd9cc2bad4
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
wrote test case to test selectedNavItem method in app component.
Issue-ID: APPC-1064
Change-Id: I8770fa19b024cbaa0f0bb86217ebe9255469f64b
Signed-off-by: Arundathi <arundpil@in.ibm.com>
|