Age | Commit message (Collapse) | Author | Files | Lines |
|
APPC CDT Should Support Multiple Templates For Configure and
ConfigModify for VNFs with VNFC level templates.
CDT would be used to create a single reference artifact for a VNF.
For the Configure related actions (Configure and ConfigModify)
vnfc-type to be shown at the top. The user would have a new link
below it, to be able to add each vnfc-type. For each vnfc-type,
the user would create the associated template and PD file as usual.
The fix required to modify several visual elements and variables
related to VNFC Types on MyVNFS page, ReferenceData page, Template
page and Parameters page. Also a number of supporting services were
modified. New Modal window type is now used for VNFC-related dialogs.
Change-Id: Ibbbb50e2ff6f96783c0aea89a6870d7c28021ba0
Issue-ID: APPC-1010
Signed-off-by: od7427 <od7427@att.com>
|
|
The HttpUtilService was injected into parameter-definition service, but
was never used. Hence removing it.
Issue-ID: APPC-1149
Change-Id: Iec30f6ab4a36920b46f9458b01be8cc58f964cc0
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Moved the hardcoded values from parameter-definition service to
app-contants as variables.
Issue-ID: APPC-1054
Change-Id: Ib61aea5eec6d9c87405179711a347a18e58b2c4a
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
5 of the test cases in template-configuration spec file failed as these
tets cases were trying to access the component instance which was only declared but not defined. Fixed this issue.
Issue-ID: APPC-1064
Change-Id: Iadbc3b7b66ed30089400e35cf5632a72f5a34991
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
wrote test case to cover processResponseKeys function
Issue-ID: APPC-1064
Change-Id: Id8ba082a07ef046485aafae6b9be1f6f80db4ef9
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
wrote test case to test checkRefDataReqFields() funtion when action,
device-protocol and scope values are set to blank.
Issue-ID: APPC-1064
Change-Id: I405aca5092e631183e690bcd60b10439f1396568
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Unsubscribed from subscription in template-configuration component. This
will release any resources that the subscription holds when the
component is destroyed.
Issue-ID: APPC-1049
Change-Id: Icbf3575e034a693f7357782826690d079945faa7
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
wrote test case to test checkRefDataReqFields() function to notify error
message when no valid template identifier is selected.
Issue-ID: APPC-1064
Change-Id: I083abfd29aac325938116c5acc604e737a0d09ae
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
wrote unit test case to test openModel function of referenceDataForm
component.
Issue-ID: APPC-1064
Change-Id: I4dcd719876df1bd1ce4a30baa7131f081b9923b2
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Moved few of the hardcoded values from reference-dataform component to
app-constants file as variables
Issue-ID: APPC-1054
Change-Id: Ib8afe569b7c669f50bf3eeec88deec27711c49a4
Signed-off-by: Arundathi patil <arundpil@in.ibm.com>
|
|
added test case to cover fileChange() method in reference-data-form spec
file.
Issue-ID: APPC-1064
Change-Id: Id27e82a648e9bb578035bc90505e15b12a0c8654
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
fixed test case 'should retrive PD from cache' that was failing with the
below error as it was expecting wrong value.
Error: Expected [ ] to be 'TEST PD INFORMATION'
In this test case, ngAfterViewInit() method is called which returns the
PD data. This PD data is stored into variable called
'displayParamObjects' and then this variable is returned to the calling
function.
The value for 'displayParamObjects' is set in getPDFromSession() method
which makes a async http call to get the PD data, so even before the
results of the async call are returned, ngAfterViewInit() method
returns the empty 'displayParamObject' variable.
Hence changed the expected value to the actual value returned by
ngAfterViewInit() method.
We can write a seperate test case to test the async call made by
getPDFromSession() method.
Issue-ID: APPC-1064
Change-Id: I0b8f38b6e52dc7478a4ab510ca3ff10ff81ae0ca
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Test case in param-name-value was failing as it was expecting wrong
value. Fixed this issue.
Issue-ID: APPC-1064
Change-Id: Iaee9cb29b40ee2e2e39632cd91ef81c91d9e8c1c
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Test cases in param-name-value.component.spec file failed with below
error,
Error: No Provider for Utility service
Fixed this error
Issue-ID: APPC-1064
Change-Id: Ie0e63be45b1cdde0bd2169168c562452babd6aa5
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Wrote test case to cover upload function in refernce-dataform.component
Issue-ID: APPC-1064
Change-Id: I44c62b944c14b9f66fc2117ad7d578b2388e973b
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Wrote test case to cover setValues method pf parameter-definitions
service
Issue-ID: APPC-1064
Change-Id: I5e43aba3c6af733cf20922036ef7ad09b86a7cdd
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Wrote test cases to cover updateAccessUpdatePages method in
build-artifacts component.
Issue-ID: APPC-1064
Change-Id: If654c89d1daf1d9639aa172c08f3270b6337ba0e
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Test cases in template-configuration spec file failed with the below
error,
Error: No provider for UtilityService.
Fixed this error.
Issue-ID: APPC-1064
Change-Id: Ibb580435a3f70024988434eba74b61be80423990
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
refactored payload in uploadArtifact method of reference dataform using
createPayloadForSave method of utlity service
Issue-ID: APPC-1100
Change-Id: I9f91725371da96e6d2384b2348e288ebc0af238d
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Test cases in parameter.component spec file failed with below error,
Error: No provider for NGXSpinnerService
Fixed this issue
Issue-ID: APPC-1064
Change-Id: I51d8e79888e182fef11d0c99936953ed0eabd380
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
refactored payload creation in retrieveNameValueFromAppc method of
param-name-value.component.ts by using the createPayloadForRetrieve
method in utility.service.ts
Issue-ID: APPC-1098
Change-Id: Ia5b4a7c259c9a27958b6df9c59869a79b03064ee
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
refactor payload creation in getPD parameter.ts using createPayloadForRetrieve
method in utility.service.ts
Issue-ID: APPC-1099
Change-Id: I976dfebfe60a123784853a7294125cf6075a653b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
refactored payload creation for saving template and param artifacts to
APPC using createPayloadForSave method in utility.service.ts
Issue-ID: APPC-1105
Change-Id: I2dd446aebdbcbc1ffc070993ee53d09e25eeae6b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Test cases in param-name-value component spec file failed with the below
error,
Error: No provider for NgxSpinnerService
Fixed this error
Issue-ID: APPC-1064
Change-Id: Ib4e0b3276525973fb6a625d2366ed26cf3d94173
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Moved all the constant values in parameter component to app-Constants
file.
Issue-ID: APPC-1054
Change-Id: I507cc0a4aa8ddc8d6d42e97129b21a235b96b225
Signed-off-by: Arundathi Patil<arundpil@in.ibm.com>
|
|
All the test cases in template-configuration spec file failed with the
below error.
Error: "No provider for NGXSpinnerService".
Fixed this error.
Issue-ID: APPC-1064
Change-Id: I9ea042519e0f6ba94344d17b9d0e457c4c4480cd
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Unsubscribed from observables in param-name-value component. This will
release any resources that the subscription holds.
Issue-ID: APPC-1049
Change-Id: Ie3aa18bfa9d5129a26abb2f33dd2f80e1cfc8bba
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
corrected commenting style in licence header of template configuration
html from "/*" to "<!--"
Issue-ID: APPC-1092
Change-Id: Ie3421a37db62e48495394f54ffd70b14ec2d053b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
added progress spinner while uplaoding param file for the user to have a visual representation of the upload
Issue-ID: APPC-1066
Change-Id: I411cca1677e924ee43050843401fd957a2aba3f9
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
added progress spinner in PD to show file upload progress
Issue-ID: APPC-1070
Change-Id: I28d237a3a69f68a9e9dbc6433c95dc53c4fbffbf
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
refactored payload creation process for template using utility service
createPayloadForRetrieve method
Issue-ID: APPC-1094
Change-Id: I1901a20c07f5d577ad5962b891f277771040b85f
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
refactored payload creation in getArtifacts method of
reference-dataform.component.ts. The payload is created now using
createPayloadForRetrieve method of utility.service.ts
Issue-ID: APPC-1095
Change-Id: I303a67d67b9764ada2d1d37adc9281442f44649e
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
added test case to param-name-value.spec.ts to increase code coverage
Issue-ID: APPC-1089
Change-Id: I2598eb2b3b7f7551f89f26e2ec6d8f820466cd42
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
added progress spinner while uploading template file so that the user can know visually that the file is being uploaded
Issue-ID: APPC-1069
Change-Id: I4d17a1f64a241dc3dc49154ec6c8abe7babb793a
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
added setTimeOut of 3.5 seconds in progress bar for retrieving PD data from APPC
Issue-ID: APPC-1073
Change-Id: I79432be9b3f74dfa84e7a37da6fb8d86c2a779f5
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Replaced the if else logic in decideExtension and populateExistinAction
method with switch case for better presentation of the code as part of
plan for reference dataform code refactor
Issue-ID: APPC-1085
Change-Id: I002e61d53585ba61b96e1e6cb0f12443498df6e9
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Fixed the failing test cases for build-artifacts component.
5 of the test cases in build-artifacts component spec were failing with
the below errors,
1. No Provider for Notification Service.
2. Cannot read property 'vnf-type' of undefined.
Fixed the above errors. The coverage for this component is now 84.78%.
Issue-ID: APPC-1064
Change-Id: Ifee45f86ce7093c9783d1f28a313869300bd8e39
Signed-off-by: Arundathi <arundpil@in.ibm.com>
|
|
Created a constant file called app-contants and moved the harded coded values in builArtifact component to app-constant
file
Issue-ID: APPC-1054
Change-Id: I2641579cdb6b20f2c51ce4f4d3ca2bd0667d2e81
Signed-off-by: Arundathi <arundpil@in.ibm.com>
|
|
Added unit test cases to cover ngOninit, selectedNavItem and showUpload
methods.
Issue-ID: APPC-1064
Change-Id: I38b885f905a13ca316ee31e5efa6b5bbb74d8506
Signed-off-by: Arundathi <arundpil@in.ibm.com>
|
|
Added missing braces at the end of the file.
Issue-ID: APPC-1051
Change-Id: I83db0d604bb50b2d7b8fd7fe3f8a61b0cd64ccd8
Signed-off-by: Arundathi <arundpil@in.ibm.com>
|
|
Change-Id: I9d5aaa07aeed62c83eea123f34de2735fb58ef02
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-886
|
|
Fixed parsing of retrieved data in case of openstack action and also
fixed browser hang while syncing large template
Issue-ID: APPC-867
Change-Id: I3058626cb5a21c01a9b261d470672db5d0f17926
Signed-off-by: sj108s <sj108s@us.att.com>
|
|
Issue-ID: APPC-862
Change-Id: I902f794cec5d69e2118f7a87f5c6fb867a1b2216
Signed-off-by: Gangarajula, Uday Bhasker (ug0221) <ug0221@att.com>
|
|
VM data retrieval and stopping user not to navigate to PD and template
if mandatory fields are missing in reference data.
Issue-ID: APPC-853
Change-Id: Id43500579c6d222a2c17a53db9213372afec565f
Signed-off-by: Mohamed Asgar Samiulla(ma926a) <ma926a@us.att.com>
|
|
Issue-ID: APPC-707
Change-Id: Ibdf18a021ea453842ddf4001f947f1f4de276997
Signed-off-by: Gangarajula, Uday Bhasker (ug0221) <ug0221@att.com>
|
|
Made changes in param name value component ts for setting correct
artifact name while saving and retrieving artifacts, in case of multiple
template ids.
Issue-ID: APPC-812
Change-Id: I973f7b763f4c2204425fceb77cdae33944ba3c8d
Signed-off-by: sj108s <sj108s@us.att.com>
|
|
Issue-ID: APPC-707
Change-Id: Ie618635618333da7d548ff5a0fe711cc34076f62
Signed-off-by: Gangarajula, Uday Bhasker (ug0221) <ug0221@att.com>
|
|
Removed license form package.json.
Issue-ID: APPC-750
Change-Id: If20087a24fc0cf42977e1b1149d6be0ff1387689
Signed-off-by: Mohamed Asgar Samiulla(ma926a) <ma926a@us.att.com>
|
|
The source name for INSTAR made configurable through a property file.
Issue-ID: APPC-750
Change-Id: I7e0d2ae657d4469f6fae54b5358ddb6f5476b211
Signed-off-by: Mohamed Asgar Samiulla(ma926a) <ma926a@us.att.com>
|
|
Added few more test cases to improve code coverage and changed trigger
command for modal in template page from Enter to ctrl-4
Issue-ID: APPC-697
Change-Id: I4a158ba687bad0bb2f808428333083200714f18a
Signed-off-by: sj108s <sj108s@us.att.com>
|