Age | Commit message (Collapse) | Author | Files | Lines |
|
Wrote test cases in uitilityService to cover processApiSubscribe
function
Issue-ID: APPC-1064
Change-Id: Id6852114581a761550f49fa59e749140d377f0fc
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Wrote test case to cover setValues method pf parameter-definitions
service
Issue-ID: APPC-1064
Change-Id: I5e43aba3c6af733cf20922036ef7ad09b86a7cdd
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Wrote test cases to cover updateAccessUpdatePages method in
build-artifacts component.
Issue-ID: APPC-1064
Change-Id: If654c89d1daf1d9639aa172c08f3270b6337ba0e
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Test case in aboutus component spec file failed with below error,
Error: this.http.get is not a function
Fixed this error
Issue-ID: APPC-1064
Change-Id: I59426d9a96ab67a7fbef6c540be26b7204a7ee7f
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Wrote test case to cover navigateToreference method of myVnfs component
Issue-ID: APPC-1064
Change-Id: Ie6417fb2e975164c9d5226d7e270ec4f7dbbdb1a
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Test case in userlogin form was expecting wrong values because of which
the test case failed. Changed the test case expecting values to proper
values.
Issue-ID: APPC-1064
Change-Id: I9b1aedc70a806b235c0b56d936370e8a1a62d2dd
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Test cases in userLogin-form spec file failed with below error,
Error: Cannot read property 'root' of undefined.
This error was because, activated route was not injected into the
testingbed. Fixed this error.
Issue-ID: APPC-1064
Change-Id: Ib9978b73be744204e8dd64b97abbc0959a4e5839
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Test cases in aboutus component spec file failed due to the changes made in ts
file. Fixed these issues
Issue-ID: APPC-1064
Change-Id: Ief9c517de5ecb57bac8787e064b2bec3f7c50f2c
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Removed ngbModal from imports and constructor as it was not used.
Issue-ID: APPC-1054
Change-Id: I92406941099384b1b17472d57c888041deb7e0a4
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Test cases in template-configuration spec file failed with the below
error,
Error: No provider for UtilityService.
Fixed this error.
Issue-ID: APPC-1064
Change-Id: Ibb580435a3f70024988434eba74b61be80423990
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
refactored payload in uploadArtifact method of reference dataform using
createPayloadForSave method of utlity service
Issue-ID: APPC-1100
Change-Id: I9f91725371da96e6d2384b2348e288ebc0af238d
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
added progress spinner for spreadsheet upload in test.component,ts
Issue-ID: APPC-1102
Change-Id: I9d030da990eae2e8efe5ae82cd1afd3c675aa286
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Moved the hard coded values from utility service file to app-contants
file as variables.
Issue-ID: APPC-1054
Change-Id: Iac62da47deeeb66402f413e90ee0ab50130ca185
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Test cases in parameter.component spec file failed with below error,
Error: No provider for NGXSpinnerService
Fixed this issue
Issue-ID: APPC-1064
Change-Id: I51d8e79888e182fef11d0c99936953ed0eabd380
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
refactored payload creation in retrieveNameValueFromAppc method of
param-name-value.component.ts by using the createPayloadForRetrieve
method in utility.service.ts
Issue-ID: APPC-1098
Change-Id: Ia5b4a7c259c9a27958b6df9c59869a79b03064ee
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Wrote test cases for loginGuardService
Issue-ID: APPC-1064
Change-Id: I9b742c860aa6a523b1c858380e8a025a621f01fd
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Wrote test cases for confirm modal component.
Issue-ID: APPC-1064
Change-Id: I6cac13f52730c31cd98e14fc8874012224b938f9
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Test cases in myvnfs component spec file failed with the below error,
Error: No provider for notification service
Fixed this issue
Issue-ID: APPC-1064
Change-Id: I39a451414e56b9db3eab7910c79d2d103b44380a
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
refactor payload creation in getPD parameter.ts using createPayloadForRetrieve
method in utility.service.ts
Issue-ID: APPC-1099
Change-Id: I976dfebfe60a123784853a7294125cf6075a653b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Test case was expecting wrong value from function in test.component.
fixed this issue.
Issue-ID: APPC-1064
Change-Id: I668778c0ae30f218204d652ed9efbd9bc0ace097
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
removed error messages that were hard coded in myvnfs component. Used
the variables from app-constants file for these errors.
Issue-ID: APPC-1064
Change-Id: I5acffb29e18cd0b135ee4bf206c507db26b9765c
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Wrote unit test cases for mapping-editor service. The covarage for this
file is now 75.96%
Issue-ID: APPC-1064
Change-Id: I4c413a076dd6194da9a19481c0fdc42f0ffe5789
Signed-off-by: Arundathi Patil<arundpil@in.ibm.com>
|
|
refactored payload creation for saving template and param artifacts to
APPC using createPayloadForSave method in utility.service.ts
Issue-ID: APPC-1105
Change-Id: I2dd446aebdbcbc1ffc070993ee53d09e25eeae6b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Test cases in param-name-value component spec file failed with the below
error,
Error: No provider for NgxSpinnerService
Fixed this error
Issue-ID: APPC-1064
Change-Id: Ib4e0b3276525973fb6a625d2366ed26cf3d94173
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Moved all the constant values in parameter component to app-Constants
file.
Issue-ID: APPC-1054
Change-Id: I507cc0a4aa8ddc8d6d42e97129b21a235b96b225
Signed-off-by: Arundathi Patil<arundpil@in.ibm.com>
|
|
This will remove all the duplicate code of ng-bootstrap popup.
Made following changes to the below files,
1. app.module.ts:
a. added the confirm modal component to declarations and entryComponents section because component will be created dynamically.
b. imported BootstrapModalModule from ng2-bootstrap-modal
2. vnfs.module.ts:
a. removed the confirm modal component from declarations and
entryComponents section as it is already declared as part of
app.module.ts.
3. confirm.component.ts:
a. added two more varibles 'cancelButtonText' and
'confirmButtonText' to ConfirmModel interface. these values will
be sent by the caller code and the button lables will be set
dynamically.
b. implemented cancel method that sets the modal result value to
false, this is called on click of close
button.
4. about.component.ts:
a. Made use of confirm.component.ts.
b. on click of 'view change log' buton we are calling open()
method which inturn opens the confirm modal component.
5. about.component.html:
a. Removed call to versionLogFile() method as this method is
called from open() method.
b. Removed the ng-template code of ng-bootstrap which is no more
required.
Issue-ID: APPC-1088
Change-Id: I9de545debed145ef35e31807acd1e9bd9cc2bad4
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
wrote test case to test selectedNavItem method in app component.
Issue-ID: APPC-1064
Change-Id: I8770fa19b024cbaa0f0bb86217ebe9255469f64b
Signed-off-by: Arundathi <arundpil@in.ibm.com>
|
|
Unsubscribed from observables in ngOndestroy method of myvnfs component.
This will release the resources held by the subscription.
Issue-ID: APPC-1049
Change-Id: I7cc7bd5aabeeb20934332541b99314a611d66f93
Signed-off-by: Arundathi Patil<arundpil@in.ibm.com>
|
|
All the test cases in template-configuration spec file failed with the
below error.
Error: "No provider for NGXSpinnerService".
Fixed this error.
Issue-ID: APPC-1064
Change-Id: I9ea042519e0f6ba94344d17b9d0e457c4c4480cd
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
Unsubscribed from observables in param-name-value component. This will
release any resources that the subscription holds.
Issue-ID: APPC-1049
Change-Id: Ie3aa18bfa9d5129a26abb2f33dd2f80e1cfc8bba
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
corrected commenting style in licence header of template configuration
html from "/*" to "<!--"
Issue-ID: APPC-1092
Change-Id: Ie3421a37db62e48495394f54ffd70b14ec2d053b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
added progress spinner while uplaoding param file for the user to have a visual representation of the upload
Issue-ID: APPC-1066
Change-Id: I411cca1677e924ee43050843401fd957a2aba3f9
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
added progress spinner in PD to show file upload progress
Issue-ID: APPC-1070
Change-Id: I28d237a3a69f68a9e9dbc6433c95dc53c4fbffbf
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
refactored payload creation process for template using utility service
createPayloadForRetrieve method
Issue-ID: APPC-1094
Change-Id: I1901a20c07f5d577ad5962b891f277771040b85f
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Wrote test case for vm-filtering pipe. the coverage for this file is now
100%.
Issue-ID: APPC-1064
Change-Id: I3ada33f251bbc180052eac8368b4d350a19c6860
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
refactored payload creation in getArtifacts method of
reference-dataform.component.ts. The payload is created now using
createPayloadForRetrieve method of utility.service.ts
Issue-ID: APPC-1095
Change-Id: I303a67d67b9764ada2d1d37adc9281442f44649e
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
added test case to param-name-value.spec.ts to increase code coverage
Issue-ID: APPC-1089
Change-Id: I2598eb2b3b7f7551f89f26e2ec6d8f820466cd42
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Removed fdescribe which was accidentally checked-in.
Issue-ID: APPC-1064
Change-Id: I08265f3de9cea66836ed7e194e4bd4f9d1159e7f
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
added methods in utility service for creating common payload method for save andretrieve and downloading artifact
Issue-ID: APPC-1063
Change-Id: I05d8e0df05bf74fe30358b0a44506baf03442a99
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
added progress spinner while uploading template file so that the user can know visually that the file is being uploaded
Issue-ID: APPC-1069
Change-Id: I4d17a1f64a241dc3dc49154ec6c8abe7babb793a
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Unable to run the test cases due to the below error in paramShare
service spec file,
"Argument of type '{ displayName: string; displayValue: string;}[]' is
not assignable to parameter of type 'Expected<{[index: string]: string } >' "
Fixed this error.
Issue-ID: APPC-1064
Change-Id: I9b9e99e9a5ed4a14469eb595625d1b3fd91e6672
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
added setTimeOut of 3.5 seconds in progress bar for retrieving PD data from APPC
Issue-ID: APPC-1073
Change-Id: I79432be9b3f74dfa84e7a37da6fb8d86c2a779f5
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Removed fdescribe in mapping-editor service file which was accidentally checked-in in the previous
checkin
Issue-ID: APPC-1064
Change-Id: I1151dda4881ba31198b176e14f9322d18126ab93
Signed-off-by: Arundathi <arundpil@in.ibm.com>
|
|
upgrade springfox swagger version to avoid security issue from guava.jar
Change-Id: I9c81b12886cbe82faa24e75acd2ea848edbb67e7
Issue-ID: APPC-1025
Signed-off-by: Taka Cho <tc012c@att.com>
|
|
upgrade http-client version to avoid nexus iq issue
Change-Id: I2fd4f2cd8b7529559cfabde527091c866a9ab359
Issue-ID: APPC-1025
Signed-off-by: Taka Cho <tc012c@att.com>
|
|
added error block in getArtifacts method to handle error scenario like error connecting to appc. The user will be notified with the angular2-notification whenever there is error connecting to appc.
Issue-ID: APPC-1083
Change-Id: I185e390cb0ddef2edea8f08d08ae124c7d05a06c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Replaced the if else logic in decideExtension and populateExistinAction
method with switch case for better presentation of the code as part of
plan for reference dataform code refactor
Issue-ID: APPC-1085
Change-Id: I002e61d53585ba61b96e1e6cb0f12443498df6e9
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Unsubscribed the observables in aboutus component.
Issue-ID: APPC-1049
Change-Id: I7f67a75e214f7b9996c269d613b9daa742a5e723
Signed-off-by: Arundathi <arundpil@in.ibm.com>
|
|
Fixed the failing test cases for build-artifacts component.
5 of the test cases in build-artifacts component spec were failing with
the below errors,
1. No Provider for Notification Service.
2. Cannot read property 'vnf-type' of undefined.
Fixed the above errors. The coverage for this component is now 84.78%.
Issue-ID: APPC-1064
Change-Id: Ifee45f86ce7093c9783d1f28a313869300bd8e39
Signed-off-by: Arundathi <arundpil@in.ibm.com>
|
|
The same variable values are set on file upload failure either due to
wrong format or due to wrong content of the file being uploaded in
uplaod() and uplaodedFileResult() methods of test component.
Moved this duplicate code to a single method called
setValuesOnFileUploadFailure() and called this method where required.
Issue-ID: APPC-1082
Change-Id: If92d375e3cfa44479c2d7f54915a1b6461bdda89
Signed-off-by: Arundathi <arundpil@in.ibm.com>
|