Fixed defects in test screen & updated test cases

Fixed few defects raised by ST in test screen and also updated test
cases to improve coverage. Also,changed code to match onap standards,
and rectfied grep code violations.

Issue-ID: APPC-730
Change-Id: I0286c38eb4f76dc8c0253a4ccab721b3ccfeff9d
Signed-off-by: sj108s <sj108s@us.att.com>

2 files changed, 43 insertions, 4 deletions

diff --git a/src/app/shared/modules/tidy-table/order-by.pipe.spec.ts b/src/app/shared/modules/tidy-table/order-by.pipe.spec.ts
index 82c57a1..5746fe9 100644
--- a/src/app/shared/modules/tidy-table/order-by.pipe.spec.ts
+++ b/src/app/shared/modules/tidy-table/order-by.pipe.spec.ts
@@ -20,10 +20,6 @@ limitations under the License.
 ECOMP is a trademark and service mark of AT&T Intellectual Property.
 ============LICENSE_END============================================
 */
-
-
-/* tslint:disable:no-unused-variable */
-
 import {OrderBy} from './order-by.pipe';
 
 describe('OrderByPipe', () => {
@@ -31,4 +27,36 @@ describe('OrderByPipe', () => {
         const pipe = new OrderBy();
         expect(pipe).toBeTruthy();
     });
+
+     it('ascending sorting', () => {
+        const pipe = new OrderBy();
+
+        let data =[
+            {'vnf-type':'vnf1','vnfc-type':'vnfc1','artifact-name':'artf1'},
+            {'vnf-type':'vnf2','vnfc-type':'vnfc2','artifact-name':'artf2'}
+          
+        ]
+        expect(pipe.transform(data,"vnf-type",true)[0]['vnf-type']).toBe('vnf1');
+        
+    });
+     it('descending sorting', () => {
+        const pipe = new OrderBy();
+
+        let data =[
+            {'vnf-type':'vnf1','vnfc-type':'vnfc1','artifact-name':'artf1'},
+            {'vnf-type':'vnf2','vnfc-type':'vnfc2','artifact-name':'artf2'}
+          
+        ]
+        expect(pipe.transform(data,"vnf-type",false)[0]['vnf-type']).toBe('vnf2');
+    });
+     it('descending sorting', () => {
+        const pipe = new OrderBy();
+
+        let data =[
+            {'vnf-type':undefined,'vnfc-type':'vnfc1','artifact-name':'artf1'},
+            {'vnf-type':'vnf2','vnfc-type':'vnfc2','artifact-name':'artf2'}
+          
+        ]
+        expect(pipe.transform(data,"vnf-type",false)[0]['vnf-type']).toBe('vnf2');
+    });
 });
diff --git a/src/app/shared/modules/tidy-table/table-filter.pipe.spec.ts b/src/app/shared/modules/tidy-table/table-filter.pipe.spec.ts
index d8fe6c7..5d73a14 100644
--- a/src/app/shared/modules/tidy-table/table-filter.pipe.spec.ts
+++ b/src/app/shared/modules/tidy-table/table-filter.pipe.spec.ts
@@ -31,4 +31,15 @@ describe('TableFilterPipe', () => {
         const pipe = new TableFilterPipe();
         expect(pipe).toBeTruthy();
     });
+    it('filter table based on input ', () => {
+        const pipe = new TableFilterPipe();
+
+        let data =[
+            {'vnf-type':'vnf1','vnfc-type':'vnfc1','artifact-name':'artf1'},
+            {'vnf-type':'vnf2','vnfc-type':'vnfc2','artifact-name':'artf2'}
+          
+        ]
+        let filter = ['vnf-type', 'vnfc-type', 'artifact-name'];
+        expect(pipe.transform(data,'vnf1',filter).length).toBe(1);
+    });
 });