diff options
author | Bharat saraswal <bharat.saraswal@huawei.com> | 2017-09-21 19:51:48 +0530 |
---|---|---|
committer | Bharat saraswal <bharat.saraswal@huawei.com> | 2017-09-21 15:37:50 +0000 |
commit | 571803511ad17e97750d0355ebb74abc4c7eeb0f (patch) | |
tree | 476482a9551258871b5fb4396745f6215f1fb58a /ajsc-aai/src/main/java/org/openecomp/aai/ajsc_aai/JaxrsUserService.java | |
parent | b7d0116d228ba50d89429c615ff3e88eec30885e (diff) |
Resolved below sonar issues:
reduced method complexitity.
handled null pointer exceptions.
creates static variables for string usability.
Issue-Id:AAI-211
Change-Id: Ia110923b3e157f73fbc65d5629b5bd22a872b3de
Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
Diffstat (limited to 'ajsc-aai/src/main/java/org/openecomp/aai/ajsc_aai/JaxrsUserService.java')
-rw-r--r-- | ajsc-aai/src/main/java/org/openecomp/aai/ajsc_aai/JaxrsUserService.java | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/ajsc-aai/src/main/java/org/openecomp/aai/ajsc_aai/JaxrsUserService.java b/ajsc-aai/src/main/java/org/openecomp/aai/ajsc_aai/JaxrsUserService.java index 39c78f6..360a50c 100644 --- a/ajsc-aai/src/main/java/org/openecomp/aai/ajsc_aai/JaxrsUserService.java +++ b/ajsc-aai/src/main/java/org/openecomp/aai/ajsc_aai/JaxrsUserService.java @@ -20,23 +20,24 @@ package org.openecomp.aai.ajsc_aai; +import java.util.HashMap; +import java.util.Map; import javax.ws.rs.GET; import javax.ws.rs.Path; import javax.ws.rs.PathParam; import javax.ws.rs.Produces; -import java.util.Map; -import java.util.HashMap; @Path("/user") public class JaxrsUserService { - - private static final Map<String,String> userIdToNameMap; - static { - userIdToNameMap = new HashMap<String,String>(); - userIdToNameMap.put("userID1","Name1"); - userIdToNameMap.put("userID2","Name2"); - } - + + private static final Map<String, String> userIdToNameMap; + + static { + userIdToNameMap = new HashMap<>(); + userIdToNameMap.put("userID1", "Name1"); + userIdToNameMap.put("userID2", "Name2"); + } + /** * Lookup user. * @@ -47,8 +48,7 @@ public class JaxrsUserService { @Path("/{userId}") @Produces("text/plain") public String lookupUser(@PathParam("userId") String userId) { - String name = userIdToNameMap.get(userId); + String name = userIdToNameMap.get(userId); return name != null ? name : "unknown id"; } - } |