Refactor HttpEntryTest

- make test cases independently runnable by removing shared state
- let method naming better reflect what is being tested
- assign commonly used objects on the class level when they are not modified in the test case
- parse error response object and assert error messages

Other:
- remove unnecessary saving in map in EdgeSerializer

Issue-ID: AAI-3658
Change-Id: I3b9704b8a6b6cfa6ecf4930dc3b1d1a7ce84764a
Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>

1 files changed, 3 insertions, 9 deletions

diff --git a/aai-core/src/main/java/org/onap/aai/serialization/db/EdgeSerializer.java b/aai-core/src/main/java/org/onap/aai/serialization/db/EdgeSerializer.java
index a5a08203..0c58717e 100644
--- a/aai-core/src/main/java/org/onap/aai/serialization/db/EdgeSerializer.java
+++ b/aai-core/src/main/java/org/onap/aai/serialization/db/EdgeSerializer.java
@@ -207,15 +207,9 @@ public class EdgeSerializer {
      * @param rule the rule
      */
     public void addProperties(Edge edge, EdgeRule rule) {
-        Map<EdgeProperty, String> propMap = new EnumMap<>(EdgeProperty.class);
-        propMap.put(EdgeProperty.CONTAINS, rule.getContains());
-        propMap.put(EdgeProperty.DELETE_OTHER_V, rule.getDeleteOtherV());
-        propMap.put(EdgeProperty.PREVENT_DELETE, rule.getPreventDelete());
-
-        for (Entry<EdgeProperty, String> entry : propMap.entrySet()) {
-            edge.property(entry.getKey().toString(), entry.getValue());
-        }
-
+        edge.property(EdgeProperty.CONTAINS.toString(), rule.getContains());
+        edge.property(EdgeProperty.DELETE_OTHER_V.toString(), rule.getDeleteOtherV());
+        edge.property(EdgeProperty.PREVENT_DELETE.toString(), rule.getPreventDelete());
         edge.property(EdgeField.PRIVATE.toString(), rule.isPrivateEdge());
         edge.property(AAIProperties.AAI_UUID, UUID.randomUUID().toString());
     }