Add functionality for reading ENV variables

Issue-ID: AAF-996
Signed-off-by: pwielebs <piotr.wielebski@nokia.com>
Change-Id: If216040d59390f0956bae7f747c8cb6bce2a7f9f

2 files changed, 235 insertions, 0 deletions

diff --git a/certServiceClient/src/test/java/org/onap/aaf/certservice/client/model/ClientConfigurationFactoryTest.java b/certServiceClient/src/test/java/org/onap/aaf/certservice/client/model/ClientConfigurationFactoryTest.java
new file mode 100644
index 00000000..e21f2510
--- /dev/null
+++ b/certServiceClient/src/test/java/org/onap/aaf/certservice/client/model/ClientConfigurationFactoryTest.java
@@ -0,0 +1,126 @@
+/*
+ * ============LICENSE_START=======================================================
+ * PROJECT
+ * ================================================================================
+ * Copyright (C) 2020 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.aaf.certservice.client.model;
+
+import org.junit.jupiter.api.Test;
+import org.onap.aaf.certservice.client.common.ClientConfigurationEnvs;
+import org.onap.aaf.certservice.client.common.EnvsForClient;
+import org.onap.aaf.certservice.client.exceptions.ClientConfigurationException;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class ClientConfigurationFactoryTest {
+
+    final String CA_NAME_VALID =  "caaaftest2";
+    final String TIME_OUT_VALID = "30000";
+    final String OUTPUT_PATH_VALID = "/opt/app/osaaf";
+    final String URL_TO_CERT_SERVICE_VALID = "http://cert-service:8080/v1/certificate/";
+    final String CA_NAME_INVALID =  "caaaftest2#$";
+    final String OUTPUT_PATH_INVALID = "/opt//app/osaaf";
+
+    private EnvsForClient envsForClient = mock(EnvsForClient.class);
+
+
+    @Test
+    void create_shouldReturnSuccessWhenAllVariablesAreSetAndValid() {
+        // given
+        when(envsForClient.getCaName()).thenReturn(CA_NAME_VALID);
+        when(envsForClient.getOutputPath()).thenReturn(OUTPUT_PATH_VALID);
+        when(envsForClient.getRequestTimeOut()).thenReturn(TIME_OUT_VALID);
+        when(envsForClient.getUrlToCertService()).thenReturn(URL_TO_CERT_SERVICE_VALID);
+
+        // when
+        ClientConfiguration configuration = new ClientConfigurationFactory(envsForClient).create();
+
+        // then
+        assertThat(configuration.getCaName()).isEqualTo(CA_NAME_VALID);
+        assertThat(configuration.getRequestTimeout()).isEqualTo(Integer.valueOf(TIME_OUT_VALID));
+        assertThat(configuration.getCertsOutputPath()).isEqualTo(OUTPUT_PATH_VALID);
+        assertThat(configuration.getUrlToCertService()).isEqualTo(URL_TO_CERT_SERVICE_VALID);
+    }
+
+    @Test
+    void create_shouldReturnSuccessWhenDefaultVariablesAreNotSet() {
+        // given
+        when(envsForClient.getCaName()).thenReturn(CA_NAME_VALID);
+        when(envsForClient.getOutputPath()).thenReturn(OUTPUT_PATH_VALID);
+
+        // when
+        ClientConfiguration configuration = new ClientConfigurationFactory(envsForClient).create();
+
+        // then
+        assertThat(configuration.getCaName()).isEqualTo(CA_NAME_VALID);
+        assertThat(configuration.getRequestTimeout()).isEqualTo(Integer.valueOf(TIME_OUT_VALID));
+        assertThat(configuration.getCertsOutputPath()).isEqualTo(OUTPUT_PATH_VALID);
+        assertThat(configuration.getUrlToCertService()).isEqualTo(URL_TO_CERT_SERVICE_VALID);
+    }
+
+    @Test
+    void create_shouldReturnClientExceptionWhenRequiredVariableIsNotSet() {
+        // given
+        when(envsForClient.getOutputPath()).thenReturn(OUTPUT_PATH_VALID);
+
+        // when
+        ClientConfigurationFactory configurationFactory = new ClientConfigurationFactory(envsForClient);
+
+        // when/then
+        assertThatExceptionOfType(ClientConfigurationException.class)
+                .isThrownBy(configurationFactory::create)
+                .withMessageContaining(ClientConfigurationEnvs.CA_NAME + " is invalid.");
+    }
+
+    @Test
+    void create_shouldReturnClientExceptionWhenCANameContainsSpecialCharacters() {
+        // given
+        when(envsForClient.getCaName()).thenReturn(CA_NAME_INVALID);
+        when(envsForClient.getOutputPath()).thenReturn(OUTPUT_PATH_VALID);
+        when(envsForClient.getRequestTimeOut()).thenReturn(TIME_OUT_VALID);
+        when(envsForClient.getUrlToCertService()).thenReturn(URL_TO_CERT_SERVICE_VALID);
+
+        // when
+        ClientConfigurationFactory configurationFactory = new ClientConfigurationFactory(envsForClient);
+
+        // when/then
+        assertThatExceptionOfType(ClientConfigurationException.class)
+                .isThrownBy(configurationFactory::create)
+                .withMessageContaining(ClientConfigurationEnvs.CA_NAME + " is invalid.");
+    }
+
+    @Test
+    void create_shouldReturnClientExceptionWhenOutputPathContainsSpecialCharacters() {
+        // given
+        when(envsForClient.getCaName()).thenReturn(CA_NAME_VALID);
+        when(envsForClient.getOutputPath()).thenReturn(OUTPUT_PATH_INVALID);
+        when(envsForClient.getRequestTimeOut()).thenReturn(TIME_OUT_VALID);
+        when(envsForClient.getUrlToCertService()).thenReturn(URL_TO_CERT_SERVICE_VALID);
+
+        // when
+        ClientConfigurationFactory configurationFactory = new ClientConfigurationFactory(envsForClient);
+
+        // when/then
+        assertThatExceptionOfType(ClientConfigurationException.class)
+                .isThrownBy(configurationFactory::create)
+                .withMessageContaining(ClientConfigurationEnvs.OUTPUT_PATH + " is invalid.");
+    }
+}
diff --git a/certServiceClient/src/test/java/org/onap/aaf/certservice/client/model/CsrConfigurationFactoryTest.java b/certServiceClient/src/test/java/org/onap/aaf/certservice/client/model/CsrConfigurationFactoryTest.java
new file mode 100644
index 00000000..39d44592
--- /dev/null
+++ b/certServiceClient/src/test/java/org/onap/aaf/certservice/client/model/CsrConfigurationFactoryTest.java
@@ -0,0 +1,109 @@
+/*
+ * ============LICENSE_START=======================================================
+ * PROJECT
+ * ================================================================================
+ * Copyright (C) 2020 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.aaf.certservice.client.model;
+
+import org.junit.jupiter.api.Test;
+import org.onap.aaf.certservice.client.common.CsrConfigurationEnvs;
+import org.onap.aaf.certservice.client.common.EnvsForCsr;
+import org.onap.aaf.certservice.client.exceptions.CsrConfigurationException;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class CsrConfigurationFactoryTest {
+
+    final String COMMON_NAME_VALID = "onap.org";
+    final String SANS_VALID = "test-name";
+    final String COUNTRY_VALID = "US";
+    final String LOCATION_VALID = "San-Francisco";
+    final String ORGANIZATION_VALID =  "Linux-Foundation";
+    final String ORGANIZATION_UNIT_VALID = "ONAP";
+    final String STATE_VALID = "California";
+    final String COMMON_NAME_INVALID = "onap.org*&";
+
+    private EnvsForCsr envsForCsr = mock(EnvsForCsr.class);
+
+
+    @Test
+    void create_shouldReturnSuccessWhenAllVariablesAreSetAndValid() {
+        // given
+        when(envsForCsr.getCommonName()).thenReturn(COMMON_NAME_VALID);
+        when(envsForCsr.getSubjectAlternativesName()).thenReturn(SANS_VALID);
+        when(envsForCsr.getCountry()).thenReturn(COUNTRY_VALID);
+        when(envsForCsr.getLocation()).thenReturn(LOCATION_VALID);
+        when(envsForCsr.getOrganization()).thenReturn(ORGANIZATION_VALID);
+        when(envsForCsr.getOrganizationUnit()).thenReturn(ORGANIZATION_UNIT_VALID);
+        when(envsForCsr.getState()).thenReturn(STATE_VALID);
+
+        // when
+        CsrConfiguration configuration = new CsrConfigurationFactory(envsForCsr).create();
+
+        // then
+        assertThat(configuration.getCommonName()).isEqualTo(COMMON_NAME_VALID);
+        assertThat(configuration.getSubjectAlternativeNames()).isEqualTo(SANS_VALID);
+        assertThat(configuration.getCountry()).isEqualTo(COUNTRY_VALID);
+        assertThat(configuration.getLocation()).isEqualTo(LOCATION_VALID);
+        assertThat(configuration.getOrganization()).isEqualTo(ORGANIZATION_VALID);
+        assertThat(configuration.getOrganizationUnit()).isEqualTo(ORGANIZATION_UNIT_VALID);
+        assertThat(configuration.getState()).isEqualTo(STATE_VALID);
+    }
+
+    @Test
+    void create_shouldReturnSuccessWhenNotRequiredVariablesAreNotSet() {
+        // given
+        when(envsForCsr.getCommonName()).thenReturn(COMMON_NAME_VALID);
+        when(envsForCsr.getState()).thenReturn(STATE_VALID);
+        when(envsForCsr.getCountry()).thenReturn(COUNTRY_VALID);
+        when(envsForCsr.getOrganization()).thenReturn(ORGANIZATION_VALID);
+
+        // when
+        CsrConfiguration configuration = new CsrConfigurationFactory(envsForCsr).create();
+
+        // then
+        assertThat(configuration.getCommonName()).isEqualTo(COMMON_NAME_VALID);
+        assertThat(configuration.getCountry()).isEqualTo(COUNTRY_VALID);
+        assertThat(configuration.getOrganization()).isEqualTo(ORGANIZATION_VALID);
+        assertThat(configuration.getState()).isEqualTo(STATE_VALID);
+    }
+
+
+    @Test
+    void create_shouldReturnCsrConfigurationExceptionWhenCommonNameContainsSpecialCharacters() {
+        // given
+        when(envsForCsr.getCommonName()).thenReturn(COMMON_NAME_INVALID);
+        when(envsForCsr.getSubjectAlternativesName()).thenReturn(SANS_VALID);
+        when(envsForCsr.getCountry()).thenReturn(COUNTRY_VALID);
+        when(envsForCsr.getLocation()).thenReturn(LOCATION_VALID);
+        when(envsForCsr.getOrganization()).thenReturn(ORGANIZATION_VALID);
+        when(envsForCsr.getOrganizationUnit()).thenReturn(ORGANIZATION_UNIT_VALID);
+        when(envsForCsr.getState()).thenReturn(SANS_VALID);
+
+        // when
+        CsrConfigurationFactory configurationFactory = new CsrConfigurationFactory(envsForCsr);
+
+        // when/then
+        assertThatExceptionOfType(CsrConfigurationException.class)
+                .isThrownBy(configurationFactory::create)
+                .withMessageContaining(CsrConfigurationEnvs.COMMON_NAME + " is invalid.");
+    }
+}