summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArundathi Patil <arundpil@in.ibm.com>2018-12-05 19:30:02 +0530
committerIBM602-PC0F1E3C\Arundathi <arundpil@in.ibm.com>2018-12-05 19:30:25 +0530
commit078467f242dd9e10c124031c4119e23f27e66a97 (patch)
tree2583d1b5eb9fe44a1f21479f952fcb886228eb26
parentc2445ee11b66efebdd5efe92fddf9526926c736e (diff)
Sonar Fix: List.java
Fixed sonar issues/code-smells across this file. Issue-ID: AAF-665 Change-Id: I9bdadaf370ad0890a1617603e5eecaa507e72984 Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
-rw-r--r--auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/perm/List.java34
1 files changed, 15 insertions, 19 deletions
diff --git a/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/perm/List.java b/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/perm/List.java
index 5df2afa2..d0481bc5 100644
--- a/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/perm/List.java
+++ b/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/perm/List.java
@@ -34,8 +34,20 @@ import org.onap.aaf.misc.env.APIException;
import aaf.v2_0.Perms;
public class List extends BaseCmd<Perm> {
-// private static final String LIST_PERM_DETAILS = "list permission details";
-
+ private static final String permFormat = "%-30s %-30s %-10s\n";
+ private static final Comparator<aaf.v2_0.Perm> permCompare = new Comparator<aaf.v2_0.Perm>() {
+ @Override
+ public int compare(aaf.v2_0.Perm a, aaf.v2_0.Perm b) {
+ int rc;
+ if ((rc=a.getType().compareTo(b.getType()))!=0) {
+ return rc;
+ }
+ if ((rc=a.getInstance().compareTo(b.getInstance()))!=0) {
+ return rc;
+ }
+ return a.getAction().compareTo(b.getAction());
+ }
+ };
public List(Perm parent) {
super(parent,"list");
@@ -47,7 +59,7 @@ public class List extends BaseCmd<Perm> {
}
// Package Level on purpose
abstract class ListPerms extends Retryable<Integer> {
- protected int list(Future<Perms> fp,String header, String parentPerm) throws CadiException, APIException {
+ protected int list(Future<Perms> fp,String header, String parentPerm) throws CadiException {
if (fp.get(AAFcli.timeout())) {
report(fp,header, parentPerm);
} else {
@@ -56,22 +68,6 @@ public class List extends BaseCmd<Perm> {
return fp.code();
}
}
-
- private static final Comparator<aaf.v2_0.Perm> permCompare = new Comparator<aaf.v2_0.Perm>() {
- @Override
- public int compare(aaf.v2_0.Perm a, aaf.v2_0.Perm b) {
- int rc;
- if ((rc=a.getType().compareTo(b.getType()))!=0) {
- return rc;
- }
- if ((rc=a.getInstance().compareTo(b.getInstance()))!=0) {
- return rc;
- }
- return a.getAction().compareTo(b.getAction());
- }
- };
-
- private static final String permFormat = "%-30s %-30s %-10s\n";
void report(Future<Perms> fp, String ... str) {
reportHead(str);