aboutsummaryrefslogtreecommitdiffstats
path: root/ice_validator/tests/test_environment_file_parameters.py
blob: 41a2aa17b94f6b40933b0190d0331e478ccaa9da (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
# -*- coding: utf8 -*-
# ============LICENSE_START====================================================
# org.onap.vvp/validation-scripts
# ===================================================================
# Copyright © 2019 AT&T Intellectual Property. All rights reserved.
# ===================================================================
#
# Unless otherwise specified, all software contained herein is licensed
# under the Apache License, Version 2.0 (the "License");
# you may not use this software except in compliance with the License.
# You may obtain a copy of the License at
#
#             http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
#
#
# Unless otherwise specified, all documentation contained herein is licensed
# under the Creative Commons License, Attribution 4.0 Intl. (the "License");
# you may not use this documentation except in compliance with the License.
# You may obtain a copy of the License at
#
#             https://creativecommons.org/licenses/by/4.0/
#
# Unless required by applicable law or agreed to in writing, documentation
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# ============LICENSE_END============================================
#
#
""" environment file structure
"""
import os

import re
import pytest
from tests.helpers import (
    prop_iterator,
    get_param,
    get_environment_pair,
    validates,
    find_environment_file,
    categories,
)
from tests.structures import Heat
from tests.utils.nested_files import file_is_a_nested_template


# Whats persistent mean? It means it goes in env.
# When adding an additional case, note the ","
# at the end of a property to make it a tuple.
ENV_PARAMETER_SPEC = {
    "PLATFORM PROVIDED": [
        {"property": ("vnf_id",), "persistent": False, "kwargs": {}},
        {"property": ("vnf_name",), "persistent": False, "kwargs": {}},
        {"property": ("vf_module_id",), "persistent": False, "kwargs": {}},
        {"property": ("vf_module_index",), "persistent": False, "kwargs": {}},
        {"property": ("vf_module_name",), "persistent": False, "kwargs": {}},
        {"property": ("workload_context",), "persistent": False, "kwargs": {}},
        {"property": ("environment_context",), "persistent": False, "kwargs": {}},
        {"property": (r"^(.+?)_net_fqdn$",), "persistent": False, "kwargs": {}},
    ],
    "ALL": [{"property": ("name",), "persistent": False, "kwargs": {}}],
    "OS::Nova::Server": [
        {"property": ("image",), "persistent": True, "kwargs": {}},
        {"property": ("flavor",), "persistent": True, "kwargs": {}},
        {"property": ("availability_zone",), "persistent": False, "kwargs": {}},
    ],
    "OS::Neutron::Port": [
        {"property": ("network",), "persistent": False, "kwargs": {}},
        {
            "property": ("fixed_ips", "ip_address"),
            "persistent": False,
            "network_type": "external",
            "kwargs": {"exclude_parameter": re.compile(r"^(.+?)_int_(.+?)$")},
        },
        {
            "property": ("fixed_ips", "ip_address"),
            "persistent": True,
            "network_type": "internal",
            "kwargs": {"exclude_parameter": re.compile(r"^((?!_int_).)*$")},
        },
        {"property": ("fixed_ips", "subnet"), "persistent": False, "kwargs": {}},
        {
            "property": ("allowed_address_pairs", "ip_address"),
            "persistent": False,
            "network_type": "external",
            "kwargs": {"exclude_parameter": re.compile(r"^(.+?)_int_(.+?)$")},
        },
        {
            "property": ("allowed_address_pairs", "ip_address"),
            "persistent": True,
            "network_type": "internal",
            "kwargs": {"exclude_parameter": re.compile(r"^((?!_int_).)*$")},
        },
    ],
    "OS::ContrailV2::InterfaceRouteTable": [
        {
            "property": (
                "interface_route_table_routes",
                "interface_route_table_routes_route",
            ),
            "persistent": False,
            "kwargs": {},
        }
    ],
    "OS::Heat::ResourceGroup": [
        {
            "property": ("count",),
            "persistent": True,
            "kwargs": {
                "exclude_resource": re.compile(
                    r"^(.+?)_subint_(.+?)_port_(.+?)_subinterfaces$"
                )
            },
        }
    ],
    "OS::ContrailV2::InstanceIp": [
        {
            "property": ("instance_ip_address",),
            "persistent": False,
            "network_type": "external",
            "kwargs": {"exclude_resource": re.compile(r"^.*_int_.*$")},
        },
        {
            "property": ("instance_ip_address",),
            "persistent": True,
            "network_type": "internal",
            "kwargs": {"exclude_resource": re.compile(r"(?!.*_int_.*)")},
        },
        {
            "property": ("subnet_uuid",),
            "persistent": False,
            "network_type": "internal",
            "kwargs": {"exclude_resource": re.compile(r"(?!.*_int_.*)")},
        },
    ],
    "OS::ContrailV2::VirtualMachineInterface": [
        {
            "property": (
                "virtual_machine_interface_allowed_address_pairs",
                "virtual_machine_interface_allowed_address_pairs_allowed_address_pair",
                "virtual_machine_interface_allowed_address_pairs_allowed_address_pair_ip",
                "virtual_machine_interface_allowed_address_pairs_allowed_address_pair_ip_ip_prefix",
            ),
            "persistent": False,
            "network_type": "external",
            "kwargs": {"exclude_resource": re.compile(r"(?!.*_int_.*)")},
        }
    ],
}


def run_test_parameter(yaml_file, resource_type, *prop, **kwargs):
    template_parameters = []
    invalid_parameters = []
    param_spec = {}
    parameter_spec = ENV_PARAMETER_SPEC.get(
        resource_type
    )  # matching spec dict on resource type
    for spec in parameter_spec:
        # iterating through spec dict and trying to match on property
        if spec.get("property") == prop:
            yep = True
            for (
                k,
                v,
            ) in (
                kwargs.items()
            ):  # now matching on additional kwargs passed in from test (i.e. network_type)
                if not spec.get(k) or spec.get(k) != v:
                    yep = False
            if yep:
                param_spec = spec
                if resource_type == "PLATFORM PROVIDED":
                    if file_is_a_nested_template(yaml_file):
                        pytest.skip(
                            "Not checking nested files for PLATFORM PROVIDED params"
                        )
                    template_parameters.append(
                        {"resource": "", "param": param_spec.get("property")[0]}
                    )
                else:
                    all_resources = False
                    if resource_type == "ALL":
                        all_resources = True
                    template_parameters = get_template_parameters(
                        yaml_file,
                        resource_type,
                        param_spec,
                        all_resources=all_resources,
                    )  # found the correct spec, proceeding w/ test
                break

    for parameter in template_parameters:
        param = parameter.get("param")
        persistence = param_spec.get("persistent")

        if env_violation(yaml_file, param, spec.get("persistent")):
            human_text = "must" if persistence else "must not"
            human_text2 = "was not" if persistence else "was"

            invalid_parameters.append(
                "{} parameter {} {} be enumerated in an environment file, but "
                "parameter {} for {} {} found.".format(
                    resource_type, prop, human_text, param, yaml_file, human_text2
                )
            )

    assert not invalid_parameters, "\n".join(invalid_parameters)


def get_preload_excluded_parameters(yaml_file, persistent_only=False, env_spec=None):
    """
    Returns set of all parameters that should not be included in the preload's
    vnf parameters/tag-values section.

    if persistent_only only parameters that are marked as persistent will
    be excluded
    """
    env_spec = env_spec or ENV_PARAMETER_SPEC
    results = []
    for resource_type, specs in env_spec.items():
        # apply to all resources if not in the format of an OpenStack resource
        all_resources = "::" not in resource_type
        for spec in specs:
            if persistent_only and not spec.get("persistent"):
                continue
            results.extend(get_template_parameters(yaml_file, resource_type,
                                                   spec, all_resources, nested_resources=True))
    results = {item["param"] for item in results}
    for param in Heat(yaml_file).parameters:
        # AZs often are manipulated and passed into nested templates making
        # them difficult to detect by looking for the assignment.  We'll
        # just extract them from the parameters if they are there to be safe
        if re.match(r"availability_zone_\d+", param):
            results.add(param)
    return results


def get_template_parameters(yaml_file, resource_type, spec, all_resources=False, nested_resources=False):
    parameters = []

    heat = Heat(yaml_file)
    if all_resources:
        resources = heat.resources if not nested_resources else heat.get_all_resources()
    else:
        resources = heat.get_resource_by_type(resource_type, all_resources=nested_resources)
    for rid, resource_props in resources.items():
        for param in prop_iterator(resource_props, *spec.get("property")):
            if param and get_param(param) and param_helper(spec, get_param(param), rid):
                # this is first getting the param
                # then checking if its actually using get_param
                # then checking a custom helper function (mostly for internal vs external networks)
                parameters.append({"resource": rid, "param": get_param(param)})
    return parameters


def env_violation(yaml_file, parameter, persistent):
    # Returns True IF there's a violation, False if everything looks good.

    filepath, filename = os.path.split(yaml_file)
    environment_pair = get_environment_pair(yaml_file)
    if not environment_pair:  # this is a nested file perhaps?
        environment_pair = find_environment_file(
            yaml_file
        )  # we want to check parent env
        if not environment_pair:
            pytest.skip("unable to determine environment file for nested yaml file")

    env_yaml = environment_pair.get("eyml")
    parameters = env_yaml.get("parameters", {})
    in_env = False
    if parameters:  # env file can be just parameters:
        for param, value in parameters.items():
            if re.match(parameter, param):
                in_env = True
                break

    # confusing return. This function is looking for a violation.
    return not persistent == in_env


def param_helper(spec, param, rid):
    # helper function that has some predefined additional
    # checkers, mainly to figure out if internal/external network
    keeper = True
    for k, v in spec.get("kwargs").items():
        if k == "exclude_resource" and re.match(v, rid):
            keeper = False
            break
        elif k == "exclude_parameter" and re.match(v, param):
            keeper = False
            break

    return keeper


@validates("R-91125")
def test_nova_server_image_parameter_exists_in_environment_file(yaml_file):
    run_test_parameter(yaml_file, "OS::Nova::Server", "image")


@validates("R-69431")
def test_nova_server_flavor_parameter_exists_in_environment_file(yaml_file):
    run_test_parameter(yaml_file, "OS::Nova::Server", "flavor")


@categories("environment_file")
@validates("R-22838", "R-99812")
def test_nova_server_name_parameter_doesnt_exist_in_environment_file(yaml_file):
    run_test_parameter(yaml_file, "ALL", "name")


@categories("environment_file")
@validates("R-59568")
def test_nova_server_az_parameter_doesnt_exist_in_environment_file(yaml_file):
    run_test_parameter(yaml_file, "OS::Nova::Server", "availability_zone")


@categories("environment_file")
@validates("R-20856")
def test_nova_server_vnf_id_parameter_doesnt_exist_in_environment_file(yaml_file):
    run_test_parameter(yaml_file, "PLATFORM PROVIDED", "vnf_id")


@categories("environment_file")
@validates("R-72871")
def test_nova_server_vf_module_id_parameter_doesnt_exist_in_environment_file(yaml_file):
    run_test_parameter(yaml_file, "PLATFORM PROVIDED", "vf_module_id")


@categories("environment_file")
@validates("R-37039")
def test_nova_server_vf_module_index_parameter_doesnt_exist_in_environment_file(
    yaml_file
):
    run_test_parameter(yaml_file, "PLATFORM PROVIDED", "vf_module_index")


@categories("environment_file")
@validates("R-36542")
def test_nova_server_vnf_name_parameter_doesnt_exist_in_environment_file(yaml_file):
    run_test_parameter(yaml_file, "PLATFORM PROVIDED", "vnf_name")


@categories("environment_file")
@validates("R-80374")
def test_nova_server_vf_module_name_parameter_doesnt_exist_in_environment_file(
    yaml_file
):
    run_test_parameter(yaml_file, "PLATFORM PROVIDED", "vf_module_name")


@categories("environment_file")
@validates("R-02691")
def test_nova_server_workload_context_parameter_doesnt_exist_in_environment_file(
    yaml_file
):
    run_test_parameter(yaml_file, "PLATFORM PROVIDED", "workload_context")


@categories("environment_file")
@validates("R-13194")
def test_nova_server_environment_context_parameter_doesnt_exist_in_environment_file(
    yaml_file
):
    run_test_parameter(yaml_file, "PLATFORM PROVIDED", "environment_context")


@categories("environment_file")
@validates("R-29872")
def test_neutron_port_network_parameter_doesnt_exist_in_environment_file(yaml_file):
    run_test_parameter(yaml_file, "OS::Neutron::Port", "network")


@categories("environment_file")
@validates("R-39841", "R-87123", "R-62590", "R-98905", "R-93030", "R-62590")
def test_neutron_port_external_fixedips_ipaddress_parameter_doesnt_exist_in_environment_file(
    yaml_file
):
    run_test_parameter(
        yaml_file,
        "OS::Neutron::Port",
        "fixed_ips",
        "ip_address",
        network_type="external",
    )


@validates("R-28795", "R-97201", "R-93496", "R-90206", "R-98569", "R-93496")
def test_neutron_port_internal_fixedips_ipaddress_parameter_exists_in_environment_file(
    yaml_file
):
    run_test_parameter(
        yaml_file,
        "OS::Neutron::Port",
        "fixed_ips",
        "ip_address",
        network_type="internal",
    )


@categories("environment_file")
@validates("R-83677", "R-80829", "R-69634", "R-22288")
def test_neutron_port_fixedips_subnet_parameter_doesnt_exist_in_environment_file(
    yaml_file
):
    run_test_parameter(
        yaml_file, "OS::Neutron::Port", "fixed_ips", "subnet", network_type="internal"
    )


@categories("environment_file")
@validates("R-83412", "R-83418")
def test_neutron_port_external_aap_ip_parameter_doesnt_exist_in_environment_file(
    yaml_file
):
    run_test_parameter(
        yaml_file,
        "OS::Neutron::Port",
        "allowed_address_pairs",
        "subnet",
        network_type="external",
    )


@categories("environment_file")
@validates("R-92193")
def test_network_fqdn_parameter_doesnt_exist_in_environment_file(yaml_file):
    run_test_parameter(yaml_file, "PLATFORM PROVIDED", r"^(.+?)_net_fqdn$")


@categories("environment_file")
@validates("R-76682")
def test_contrail_route_prefixes_parameter_doesnt_exist_in_environment_file(yaml_file):
    run_test_parameter(
        yaml_file,
        "OS::ContrailV2::InterfaceRouteTable",
        "interface_route_table_routes",
        "interface_route_table_routes_route",
    )


@validates("R-50011")
def test_heat_rg_count_parameter_exists_in_environment_file(yaml_file):
    run_test_parameter(yaml_file, "OS::Heat::ResourceGroup", "count")


@categories("environment_file")
@validates("R-100020", "R-100040", "R-100060", "R-100080", "R-100170")
def test_contrail_external_instance_ip_does_not_exist_in_environment_file(yaml_file):
    run_test_parameter(
        yaml_file,
        "OS::ContrailV2::InstanceIp",
        "instance_ip_address",
        network_type="external",
    )


@validates("R-100100", "R-100120", "R-100140", "R-100160", "R-100180")
def test_contrail_internal_instance_ip_does_exist_in_environment_file(yaml_file):
    run_test_parameter(
        yaml_file,
        "OS::ContrailV2::InstanceIp",
        "instance_ip_address",
        network_type="internal",
    )


@categories("environment_file")
@validates("R-100210", "R-100230", "R-100250", "R-100270")
def test_contrail_subnet_uuid_does_not_exist_in_environment_file(yaml_file):
    run_test_parameter(yaml_file, "OS::ContrailV2::InstanceIp", "subnet_uuid")


@categories("environment_file")
@validates("R-100320", "R-100340")
def test_contrail_vmi_aap_does_not_exist_in_environment_file(yaml_file):
    run_test_parameter(
        yaml_file,
        "OS::ContrailV2::VirtualMachineInterface",
        "virtual_machine_interface_allowed_address_pairs",
        "virtual_machine_interface_allowed_address_pairs_allowed_address_pair",
        "virtual_machine_interface_allowed_address_pairs_allowed_address_pair_ip",
        "virtual_machine_interface_allowed_address_pairs_allowed_address_pair_ip_ip_prefix",
    )