Sonar fix for vvp 291 and 292

Issue-ID: VVP-291

Change-Id: I4d2eebbb9d4d96b17cc09a5de34e95e41cb9ec7d
Signed-off-by: Mamtha <mamtha.sabesan@in.ibm.com>

1 files changed, 2 insertions, 7 deletions

diff --git a/ice_validator/tests/test_nova_servers_vm_types.py b/ice_validator/tests/test_nova_servers_vm_types.py
index d3d0dbb..36ada32 100644
--- a/ice_validator/tests/test_nova_servers_vm_types.py
+++ b/ice_validator/tests/test_nova_servers_vm_types.py
@@ -42,7 +42,7 @@ import re
 
 from tests import cached_yaml as yaml
 
-from .helpers import validates
+from .helpers import validates, is_nova_server
 
 from .utils.vm_types import get_vm_types_for_resource, get_vm_types
 
@@ -64,13 +64,8 @@ def test_vm_type_consistent_on_nova_servers(yaml_file):
 
     invalid_nova_servers = []
     for k, v in yml["resources"].items():
-        if not isinstance(v, dict):
-            continue
-        if v.get("type") != "OS::Nova::Server":
+        if not is_nova_server(v):
             continue
-        if "properties" not in v:
-            continue
-
         vm_types = get_vm_types_for_resource(v)
         if len(vm_types) != 1:
             invalid_nova_servers.append(k)