diff options
author | 2018-12-17 12:43:02 -0800 | |
---|---|---|
committer | 2018-12-17 13:04:00 -0800 | |
commit | 1f4df7c7ad27b23773ad9cdbe4db1632ce388cf1 (patch) | |
tree | 8092104f8be23051ff81c9f71ee34116df4d33ba /ice_validator/tests/test_get_file_only_reference_local_files.py | |
parent | ca9085f0f77d442d3741a8c754e65cc45b6a318d (diff) |
[VVP] updating validation scripts in dublin
- adding backlog of new validation scripts for dublin
- updating existing tests
- removing outdated tests
Issue-ID: VVP-123
Change-Id: Ib8260889ac957c1dd28d8ede450fc8edc6fb0ec0
Signed-off-by: stark, steven <steven.stark@att.com>
Diffstat (limited to 'ice_validator/tests/test_get_file_only_reference_local_files.py')
-rw-r--r-- | ice_validator/tests/test_get_file_only_reference_local_files.py | 59 |
1 files changed, 51 insertions, 8 deletions
diff --git a/ice_validator/tests/test_get_file_only_reference_local_files.py b/ice_validator/tests/test_get_file_only_reference_local_files.py index a419585..58a1384 100644 --- a/ice_validator/tests/test_get_file_only_reference_local_files.py +++ b/ice_validator/tests/test_get_file_only_reference_local_files.py @@ -1,5 +1,5 @@ # -*- coding: utf8 -*- -# ============LICENSE_START======================================================= +# ============LICENSE_START==================================================== # org.onap.vvp/validation-scripts # =================================================================== # Copyright © 2017 AT&T Intellectual Property. All rights reserved. @@ -37,8 +37,11 @@ # # ECOMP is a trademark and service mark of AT&T Intellectual Property. # - +"""test get_file +""" import re +from os import listdir +from os import path from os import sep import pytest @@ -47,14 +50,19 @@ from tests import cached_yaml as yaml from .helpers import validates from .utils.nested_iterables import find_all_get_file_in_yml +VERSION = "1.0.0" -@validates('R-99646') -def test_get_file_only_reference_local_files(yaml_file): - ''' +# pylint: disable=invalid-name + + +@validates("R-41888") +@pytest.mark.base +def test_get_file_no_url_retrieval(yaml_file): + """ Make sure that all references to get_file only try to access local files and only assume a flat directory structure - ''' - is_url = re.compile(r'(?:http|https|file|ftp|ftps)://.+') + """ + is_url = re.compile(r"(?:http|https|file|ftp|ftps)://.+") with open(yaml_file) as fh: yml = yaml.load(fh) @@ -74,4 +82,39 @@ def test_get_file_only_reference_local_files(yaml_file): invalid_files.append(get_file) continue - assert not set(invalid_files) + assert not set(invalid_files), "External get_file references detected {}".format( + invalid_files + ) + + +@validates("R-76718") +@pytest.mark.base +def test_get_file_only_reference_local_files(yaml_file): + """ + Make sure that all references to get_file only try to access local files + and only assume a flat directory structure + """ + is_url = re.compile(r"(?:http|https|file|ftp|ftps)://.+") + base_dir, filename = path.split(yaml_file) + + with open(yaml_file) as fh: + yml = yaml.load(fh) + + # skip if parameters are not defined + if "resources" not in yml: + pytest.skip("No resources specified in the heat template") + + get_files = find_all_get_file_in_yml(yml["resources"]) + + invalid_files = [] + for get_file in get_files: + if is_url.match(get_file): + pytest.skip("external get_file detected") + continue + if get_file not in listdir(base_dir): + invalid_files.append(get_file) + continue + + assert not set(invalid_files), "Non-local files detected in get_file {}".format( + invalid_files + ) |