[VVP] Update validations based on VNFRQTS-637dublin

Update to the latest bundled requirements text
Update aap_exempt message to better reflect verbiage
Remove unneeded test: tests_neutron_port_addresses (requirement removed)
Map aap_exempt requirement to associated tests

Also adding new helper scripts to help detect divergences between
VNF Requirements and VVP as well as other VVP best practices:

checks.py - Pre-commit checks
- requirements are up-to-date with VNFRQTS
- all testable requirements have tests
- all non-testable requirements are *not* mapped to tests
- flake8 passes
- self-test passes

update_reqs.py - Updates the the contents of heat_requirements.json
with latest req'ts from VNFRQTS Nexus artifact

Change-Id: Ia197de3254a1a0369224939f66a5f98c601a314d
Issue-ID: VVP-216
Signed-off-by: Lovett, Trevor <trevor.lovett@att.com>

1 files changed, 4 insertions, 2 deletions

diff --git a/ice_validator/tests/test_allowed_address_pairs_include_vm_type_network_role.py b/ice_validator/tests/test_allowed_address_pairs_include_vm_type_network_role.py
index 6fdb815..6b3c63c 100644
--- a/ice_validator/tests/test_allowed_address_pairs_include_vm_type_network_role.py
+++ b/ice_validator/tests/test_allowed_address_pairs_include_vm_type_network_role.py
@@ -82,7 +82,7 @@ aap_regx_dict = {
 }
 
 
-@validates("R-41492", "R-35735", "R-159016", "R-91810", "R-41956")
+@validates("R-41492", "R-35735", "R-159016", "R-91810", "R-41956", "R-41493")
 def test_external_aap_format(yaml_file):
     check_parameter_format(
         yaml_file,
@@ -91,6 +91,7 @@ def test_external_aap_format(yaml_file):
         NeutronPortProcessor,
         "allowed_address_pairs",
         "ip_address",
+        exemptions_allowed=True,
     )
 
 
@@ -106,7 +107,7 @@ def test_internal_aap_format(yaml_file):
     )
 
 
-@validates("R-100280", "R-100290", "R-100310", "R-100330", "R-100350")
+@validates("R-100280", "R-100290", "R-100310", "R-100330", "R-100350", "R-41493")
 def test_external_aap_format_contrail(yaml_file):
     check_parameter_format(
         yaml_file,
@@ -117,6 +118,7 @@ def test_external_aap_format_contrail(yaml_file):
         "virtual_machine_interface_allowed_address_pairs_allowed_address_pair",
         "virtual_machine_interface_allowed_address_pairs_allowed_address_pair_ip",
         "virtual_machine_interface_allowed_address_pairs_allowed_address_pair_ip_ip_prefix",
+        exemptions_allowed=True,
     )