aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEzhilarasi <ezhrajam@in.ibm.com>2019-10-03 19:50:11 +0530
committerEzhilarasi R <ezhrajam@in.ibm.com>2019-10-04 09:04:08 +0000
commitc66f5bcac351c595e94046cfe70fd982257b2db3 (patch)
tree309f4dc89eb8ead285cc54993d160f49f1c80bcd
parent3d9c7371509f58e53312e5ded8ac90d292e60c6d (diff)
Sonarfix in structures.py
Reduced cognitive complexity Change-Id: I2f435ba1d5980405fed66bfb1e4f4ad543b0ba4e Issue-ID: VVP-286 Signed-off-by: Ezhilarasi <ezhrajam@in.ibm.com>
-rw-r--r--ice_validator/tests/structures.py18
1 files changed, 11 insertions, 7 deletions
diff --git a/ice_validator/tests/structures.py b/ice_validator/tests/structures.py
index 0223bc3..a435246 100644
--- a/ice_validator/tests/structures.py
+++ b/ice_validator/tests/structures.py
@@ -252,15 +252,19 @@ class ContrailV2NetworkFlavorBaseProcessor(HeatProcessor):
network_flavor = cls.network_flavor_internal
else:
p = param.get("get_param")
- if isinstance(p, str):
- if "_int_" in p or p.startswith("int_"):
- network_flavor = cls.network_flavor_internal
- elif "_subint_" in p:
- network_flavor = cls.network_flavor_subint
- else:
- network_flavor = cls.network_flavor_external
+ network_flavor = cls.get_network_format(p)
return network_flavor
+ @classmethod
+ def get_network_format(cls, param):
+ if isinstance(param, str):
+ if "_int_" in param or param.startswith("int_"):
+ return cls.network_flavor_internal
+ elif "_subint_" in param:
+ return cls.network_flavor_subint
+ else:
+ return cls.network_flavor_external
+
class ContrailV2InstanceIpProcessor(ContrailV2NetworkFlavorBaseProcessor):
""" ContrailV2 InstanceIp