1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
|
/*
* Copyright 2020 Nokia
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*/
package org.onap.cvc.csar.cc.sol004;
import org.assertj.core.api.Condition;
import org.assertj.core.api.HamcrestCondition;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.ExpectedException;
import org.onap.cvc.csar.CSARArchive;
import java.util.List;
import static org.assertj.core.api.Assertions.assertThat;
import static org.hamcrest.CoreMatchers.allOf;
import static org.hamcrest.CoreMatchers.containsString;
import static org.onap.cvc.csar.cc.sol004.IntegrationTestUtils.configureTestCase;
import static org.onap.cvc.csar.cc.sol004.IntegrationTestUtils.convertToMessagesList;
import static org.onap.cvc.csar.cc.sol004.IntegrationTestUtils.convertToFilesList;
public class VTPValidateCSARR816745IntegrationTest {
private static final boolean IS_PNF = true;
private static final String TEST_CSAR_DIRECTORY = "pnf/r816745/";
private static final int NUMBER_OF_EXPECTED_ERRORS = 4;
private static final String LETTER_S_WITH_ASCII_CODE = "s(115)";
private VTPValidateCSARR816745 testCase;
@Rule
public ExpectedException exceptionRule = ExpectedException.none();
@Before
public void setUp() {
testCase = new VTPValidateCSARR816745();
}
@Test
public void shouldAddPmDictionaryLoadingErrorWhenPmDictionaryHaveNoSourceInManifest() throws Exception {
// given
configureTestCase(testCase, TEST_CSAR_DIRECTORY + "csar-with-missing-source-value-for-pm-dictionary-in-manifest.csar", "vtp-validate-csar-r816745.yaml", IS_PNF);
// when
testCase.execute();
// then
List<CSARArchive.CSARError> errors = testCase.getErrors();
assertThat(errors.size()).isEqualTo(1);
assertThat(convertToMessagesList(errors)).contains("Fail to load PM_Dictionary With error: onap_pm_dictionary in manifest does not contains key 'Source'");
}
@Test
public void shouldNotReportAnyErrorWhenCsarIsNotContainingPmDictionary() throws Exception {
// given
configureTestCase(testCase, TEST_CSAR_DIRECTORY + "csar-with-no-pm-dictionary.csar", "vtp-validate-csar-r816745.yaml", IS_PNF);
// when
testCase.execute();
// then
List<CSARArchive.CSARError> errors = testCase.getErrors();
assertThat(errors.size()).isZero();
}
@Test
public void shouldReturnNoErrorsWhenCsarContainsValidPmDictionary() throws Exception {
// given
configureTestCase(testCase, TEST_CSAR_DIRECTORY + "csar-with-valid-pm-dictionary.csar", "vtp-validate-csar-r816745.yaml", IS_PNF);
// when
testCase.execute();
// then
List<CSARArchive.CSARError> errors = testCase.getErrors();
assertThat(errors.size()).isEqualTo(0);
}
@Test
public void shouldReturnNoErrorsWhenZipContainsCsarWithValidPmDictionary() throws Exception {
// given
configureTestCase(testCase, TEST_CSAR_DIRECTORY + "zip-with-valid-pm-dictionary.zip", "vtp-validate-csar-r816745.yaml", IS_PNF);
// when
testCase.execute();
// then
List<CSARArchive.CSARError> errors = testCase.getErrors();
assertThat(errors.size()).isEqualTo(0);
}
@Test
public void shouldReturnListOfErrorsWhenCsarContainsInvalidPmDictionary() throws Exception {
// given
configureTestCase(testCase, TEST_CSAR_DIRECTORY + "csar-with-invalid-pm-dictionary.csar", "vtp-validate-csar-r816745.yaml", IS_PNF);
// when
testCase.execute();
// then
assertThatReturnedErrorsAreCorrect(testCase.getErrors());
}
@Test
public void shouldReturnListOfErrorsWhenZipContainsCsarWithInvalidPmDictionary() throws Exception {
// given
configureTestCase(testCase, TEST_CSAR_DIRECTORY + "zip-with-invalid-pm-dictionary.zip", "vtp-validate-csar-r816745.yaml", IS_PNF);
// when
testCase.execute();
// then
assertThatReturnedErrorsAreCorrect(testCase.getErrors());
}
@Test
public void shouldAddPmDictionaryLoadingErrorWhenGivenInvalidPath() throws Exception {
// given
configureTestCase(testCase, TEST_CSAR_DIRECTORY + "csar-with-empty-pm-dictionary.csar", "vtp-validate-csar-r816745.yaml", IS_PNF);
// when then
testCase.execute();
// then
List<CSARArchive.CSARError> errors = testCase.getErrors();
assertThat(errors.size()).isEqualTo(1);
assertThat(convertToMessagesList(errors)).contains("Fail to load PM_Dictionary With error: PM_Dictionary YAML file is empty");
}
@Test
public void shouldReturnListContainingOneErrorsWhenCsarContainsPmDictionaryWithInvalidKeyMapping() throws Exception {
// given
configureTestCase(testCase, TEST_CSAR_DIRECTORY + "csar-with-invalid-pm-dictionary-invalid-mapping.csar", "vtp-validate-csar-r816745.yaml", IS_PNF);
// when
testCase.execute();
// then
List<CSARArchive.CSARError> errors = testCase.getErrors();
assertThat(errors.size()).isEqualTo(1);
assertThat(convertToMessagesList(errors).get(0)).contains(
"Fail to load PM_Dictionary With error: mapping values are not allowed here"
);
}
@Test
public void shouldReturnListContainingOneErrorsWhenCsarContainsPmDictionaryWithIncorrectEscapeCharacter() throws Exception {
// given
configureTestCase(testCase, TEST_CSAR_DIRECTORY + "csar-with-invalid-pm-dictionary-unknown-escape-character.csar", "vtp-validate-csar-r816745.yaml", IS_PNF);
// when
testCase.execute();
// then
List<CSARArchive.CSARError> errors = testCase.getErrors();
assertThat(errors.size()).isEqualTo(1);
assertThat(convertToMessagesList(errors).get(0)).contains(
"Fail to load PM_Dictionary With error: while scanning a double-quoted scalar",
"found unknown escape character " + LETTER_S_WITH_ASCII_CODE
);
}
@Test
public void shouldReturnProperRequestNumber() {
assertThat(testCase.getVnfReqsNo()).isEqualTo("R816745");
}
private void assertThatReturnedErrorsAreCorrect(List<CSARArchive.CSARError> errors) {
assertThat(errors.size()).isEqualTo(NUMBER_OF_EXPECTED_ERRORS);
Condition<String> containingSameFileForAllErrors = new HamcrestCondition<>(
containsString("Artifacts/Deployment/Measurements/PM_Dictionary.yml")
);
assertThat(convertToFilesList(errors))
.haveExactly(NUMBER_OF_EXPECTED_ERRORS, containingSameFileForAllErrors);
Condition<String> containingErrorForMissingValueInFirstDocument = new HamcrestCondition<>(allOf(
containsString("Invalid YAML document in PM_Dictionary file."),
containsString("In document number 1"),
containsString("Path: /pmMetaData/pmFields/"),
containsString("Key not found: measChangeType")
));
assertThat(convertToMessagesList(errors)).haveExactly(1, containingErrorForMissingValueInFirstDocument);
Condition<String> containingErrorForWrongValueInFirstDocument = new HamcrestCondition<>(allOf(
containsString("Invalid YAML document in PM_Dictionary file."),
containsString("In document number 1"),
containsString("Path: /pmMetaData/pmFields/measResultType"),
containsString("Value(s) is/are not in array of accepted values."),
containsString("value(s): integer"),
containsString("accepted value(s): [float, uint32, uint64]")
));
assertThat(convertToMessagesList(errors)).haveExactly(1, containingErrorForWrongValueInFirstDocument);
Condition<String> containingErrorForMissingValueInSecondDocument = new HamcrestCondition<>(allOf(
containsString("Invalid YAML document in PM_Dictionary file."),
containsString("In document number 2"),
containsString("Path: /pmMetaData/pmFields/"),
containsString("Key not found: measChangeType")
));
assertThat(convertToMessagesList(errors)).haveExactly(1, containingErrorForMissingValueInSecondDocument);
Condition<String> containingErrorForWrongValueInArrayInThirdDocument = new HamcrestCondition<>(allOf(
containsString("Invalid YAML document in PM_Dictionary file."),
containsString("In document number 3"),
containsString("Path: /pmMetaData/pmFields/measAdditionalFields/vendorField1"),
containsString("Value(s) is/are not in array of accepted values."),
containsString("value(s): [Z, A]"),
containsString("accepted value(s): [X, Y, Z]")
));
assertThat(convertToMessagesList(errors)).haveExactly(1, containingErrorForWrongValueInArrayInThirdDocument);
}
}
|
