1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
|
# -*- coding: utf8 -*-
# ============LICENSE_START=======================================================
# org.onap.vvp/validation-scripts
# ===================================================================
# Copyright © 2017 AT&T Intellectual Property. All rights reserved.
# ===================================================================
#
# Unless otherwise specified, all software contained herein is licensed
# under the Apache License, Version 2.0 (the “License”);
# you may not use this software except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
#
#
# Unless otherwise specified, all documentation contained herein is licensed
# under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
# you may not use this documentation except in compliance with the License.
# You may obtain a copy of the License at
#
# https://creativecommons.org/licenses/by/4.0/
#
# Unless required by applicable law or agreed to in writing, documentation
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# ============LICENSE_END============================================
#
# ECOMP is a trademark and service mark of AT&T Intellectual Property.
#
import pytest
import yaml
from .utils.network_roles import get_network_role_from_port
import re
def test_allowed_address_pairs_format(heat_template):
'''
Make sure all allowed_address_pairs properties follow the allowed
naming conventions
'''
allowed_formats = [
["allowed_address_pairs", "string", "internal",
re.compile(r'(.+?)_int_(.+?)_floating_v6_ip')],
["allowed_address_pairs", "string", "internal",
re.compile(r'(.+?)_int_(.+?)_floating_ip')],
["allowed_address_pairs", "string", "external",
re.compile(r'(.+?)_floating_v6_ip')],
["allowed_address_pairs", "string", "external",
re.compile(r'(.+?)_floating_ip')],
["allowed_address_pairs", "string", "internal",
re.compile(r'(.+?)_int_(.+?)_v6_ip_\d+')],
["allowed_address_pairs", "string", "internal",
re.compile(r'(.+?)_int_(.+?)_ip_\d+')],
["allowed_address_pairs", "string", "external",
re.compile(r'(.+?)_v6_ip_\d+')],
["allowed_address_pairs", "string", "external",
re.compile(r'(.+?)_ip_\d+')],
["allowed_address_pairs", "comma_delimited_list",
"internal", re.compile(r'(.+?)_int_(.+?)_v6_ips')],
["allowed_address_pairs", "comma_delimited_list",
"internal", re.compile(r'(.+?)_int_(.+?)_ips')],
["allowed_address_pairs", "comma_delimited_list",
"external", re.compile(r'(.+?)_v6_ips')],
["allowed_address_pairs", "comma_delimited_list",
"external", re.compile(r'(.+?)_ips')],
]
with open(heat_template) as fh:
yml = yaml.load(fh)
# skip if resources are not defined
if "resources" not in yml:
pytest.skip("No resources specified in the heat template")
# check both valid and invalid patterns to catch edge cases
invalid_allowed_address_pairs = []
for v1 in yml["resources"].values():
if not isinstance(v1, dict):
continue
if "properties" not in v1:
continue
if v1.get("type") != "OS::Neutron::Port":
continue
network_role = get_network_role_from_port(v1)
for k2, v2 in v1["properties"].items():
if k2 != "allowed_address_pairs":
continue
for v3 in v2:
if "ip_address" not in v3:
continue
if "get_param" not in v3["ip_address"]:
continue
valid_allowed_address_pair = False
for v4 in allowed_formats:
param = v3["ip_address"]["get_param"]
if isinstance(param, list):
param = param[0]
# check if pattern matches
m = v4[3].match(param)
if m:
if v4[2] == "internal" and\
len(m.groups()) > 1 and\
m.group(2) == network_role:
valid_allowed_address_pair = True
break
elif v4[2] == "external" and\
len(m.groups()) > 0 and\
m.group(1).endswith("_" + network_role):
valid_allowed_address_pair = True
break
if not valid_allowed_address_pair:
invalid_allowed_address_pairs.append(param)
assert not set(invalid_allowed_address_pairs)
|
