Age | Commit message (Collapse) | Author | Files | Lines |
|
Using the @Override annotation is useful for two reasons :
It elicits a warning from the compiler if the annotated method doesn't actually override anything, as in the case of a misspelling.
It improves the readability of the source code by making it obvious that methods are overridden.
Issue-ID: VID-612
Change-Id: I90f07b6da5934fcba0c6d4106a75684438d8bb4b
Signed-off-by: anushadasari <danush10@in.ibm.com>
|
|
The == and != operators do type coercion before comparing values. This is bad because it can mask type errors. For example, it evaluates ' \t\r\n' == 0 as true.
It is best to always use the side-effect-less === and !== operators instead.
Issue-ID: VID-656
Change-Id: If93fe032fae618bb0bd7112c24a0e4d3acab6337
Signed-off-by: anushadasari <danush10@in.ibm.com>
|
|
|
|
Keystore instantiation is failing on jenkins.
Add mocked keystore
Issue-ID: VID-653
Signed-off-by: wsliwka <wojciech.sliwka@nokia.com>
Change-Id: I428db5b14d90c63de6b11ad5d366e839efbf33ed
|
|
Change-Id: I4bace8cf4eeba84ad13794e2abe9d5e525dc91ea
Issue-ID: VID-638
Signed-off-by: Ittay Stern <ittay.stern@att.com>
|
|
FE will send the None_Upgrade action therefore we need to map it to Upgrade
Issue-ID: VID-651
Signed-off-by: Amichai Hemli <amichai.hemli@intl.att.com>
Change-Id: Ia4806386dcd8faf557f0c17a2f533afa386b2ec1
|
|
|
|
|
|
Issue-ID: VID-596
Signed-off-by: Sara Weiss <sara.weiss@intl.att.com>
Change-Id: I81155ff877016995ef977358d3bf9fddf75a18ce
|
|
Issue-ID: VID-638
Change-Id: Ia971cc95f03ed1e3372302afd3c699633370204f
Signed-off-by: Ittay Stern <ittay.stern@att.com>
|
|
Using the @Override annotation is useful for two reasons :
It elicits a warning from the compiler if the annotated method doesn't actually override anything, as in the case of a misspelling.
It improves the readability of the source code by making it obvious that methods are overridden.
Issue-ID: VID-612
Change-Id: Ic628b85f7a3e4c08712c88298fa4620ecddce0cc
Signed-off-by: anushadasari <danush10@in.ibm.com>
|
|
In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.
Issue-ID: VID-607
Change-Id: I27deafe5e97d71be4b5b6501f3cda0a19769123b
Signed-off-by: anushadasari <danush10@in.ibm.com>
|
|
In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.
Issue-ID: VID-607
Change-Id: Ibf05db5e76be01c78cfac8196fcf4bb09dfa7709
Signed-off-by: anushadasari <danush10@in.ibm.com>
|
|
In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.
Issue-ID: VID-607
Change-Id: Id3fd3e7baea856e8aab4c5c7c509a6c00bb44ced
Signed-off-by: anushadasari <danush10@in.ibm.com>
|
|
In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.
Issue-ID: VID-607
Change-Id: I45637083e88ac2e1c4cb27519a3116f2f5f792e8
Signed-off-by: anushadasari <danush10@in.ibm.com>
|
|
In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.
Issue-ID: VID-607
Change-Id: I2adee2c4d945cde39d796106fa6540d875b25219
Signed-off-by: anushadasari <danush10@in.ibm.com>
|
|
In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line
Issue-ID: VID-607
Change-Id: I6798e2fbf4439e5336e1af734aa762449454f04f
Signed-off-by: anushadasari <danush10@in.ibm.com>
|
|
In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.
Issue-ID: VID-607
Change-Id: I74a97be12bc5a110c4afd7f2d3eaf51b0ae707c8
Signed-off-by: anushadasari <danush10@in.ibm.com>
|
|
In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line
Issue-ID: VID-607
Change-Id: I351d26cab21fffe5925dd6bc64691166e5c3ea3d
Signed-off-by: anushadasari <danush10@in.ibm.com>
|
|
In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.
Issue-ID: VID-607
Change-Id: I1fd965413585256c09e61c2a19b0651800e65eab
Signed-off-by: anushadasari <danush10@in.ibm.com>
|
|
Issue-ID: VID-253
Change-Id: I4df5756d14969a2c0daa777c75c1365837f9ad1f
Signed-off-by: Ittay Stern <ittay.stern@att.com>
|
|
Need to URL-encode the path segments when sending URL in the custom queries to A&AI
Issue-ID: VID-596
Signed-off-by: Amichai Hemli <amichai.hemli@intl.att.com>
Change-Id: Ie551cccfc1a8c627984185324a59c18f13200e91
|
|
|
|
|
|
|
|
Issue-ID: VID-646
Signed-off-by: Einat Vinouze <einat.vinouze@intl.att.com>
Change-Id: Id1f84dadd31840cf9fa3cdbc7afd7da727a22c7f
|
|
Issue-ID: VID-596
Change-Id: I591da151bb27a46c217edec552e7c9c670a96aaa
Signed-off-by: Sara Weiss <sara.weiss@intl.att.com>
|
|
|
|
Issue-ID: VID-596
Change-Id: Ieb89980f7e802fe2508950a0e1a23188145fd85e
Signed-off-by: Sara Weiss <sara.weiss@intl.att.com>
|
|
Issue-ID: VID-470
Change-Id: I2eeb3780ffe161c8616fb72573d4ce4916edc9ee
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
|
|
vm.scheduleWorkflow()
In addition, show error message when no Portal-frame. Use the dumped
data to revive ChangeManagementTest tests by capturing the error's
payload.
Issue-ID: VID-397
Change-Id: I978bf537c43b0e3933e82c761c60cd067ab2cf27
Signed-off-by: Ittay Stern <ittay.stern@att.com>
|
|
added new unit tests to AaiControllerTest
Issue-ID: VID-649
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
Change-Id: Ib16f31487e09e0dfdd0813e2a16def620e166be2
|
|
Change-Id: Iecb4d6fbb79c5920d088fe536e6622690f8f881e
Issue-ID: VID-253
Signed-off-by: Ittay Stern <ittay.stern@att.com>
|
|
Issue-ID: VID-253
Change-Id: Icae6caf5f720da0c7587f62380d1783669e69d9f
Signed-off-by: Ittay Stern <ittay.stern@att.com>
|
|
methods
Change-Id: Idb39f7d5e723598e34e737522c4f73d8de3df93c
Issue-ID: VID-253
Signed-off-by: Ittay Stern <ittay.stern@att.com>
|
|
|
|
Send Homing_solution=none during macro instantiation
Add flag 'FLAG_DISABLE_HOMING' (by default set to true) which defines
whether homing_solution should be in request to so or not
Issue-ID: VID-576
Signed-off-by: wsliwka <wojciech.sliwka@nokia.com>
Change-Id: I6151151a0256a5bb4e637acf08ae511f4b265dc2
Signed-off-by: wsliwka <wojciech.sliwka@nokia.com>
|
|
|
|
|
|
Issue-ID: VID-646
Signed-off-by: Einat Vinouze <einat.vinouze@intl.att.com>
Change-Id: Ifc6a43f9b34c5c792a05cc3502c1e8fcf5023210
|
|
Change-Id: I74b6f5dbf614cf3a29a8c1570a1f113d191f7e57
Issue-ID: VID-631
Signed-off-by: Ittay Stern <ittay.stern@att.com>
|
|
Issue-ID: VID-646
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I533221a6115c4a2d00ce3ed02eef4d1ad882df3a
|
|
|
|
Issue-ID: VID-596
Signed-off-by: Alexey Sandler <alexey.sandler@intl.att.com>
Change-Id: I72d9c2c9dc3f39fcc3c87e083ac230d20135e979
|
|
Issue-ID: VID-643
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I906ae56d874ca4b8a760cdfb45ce23cf0e6cf6c3
|
|
FasterXML jackson-databind versions 2.x through 2.9.9.1 are vulnerable.
we will use 2.9.9.3 for jackson-databind only
Issue-ID: VID-640
Signed-off-by: Amichai Hemli <amichai.hemli@intl.att.com>
Change-Id: I537cb83ad787522b75fdee59ffabb51def747096
|
|
|
|
As we are now using AaiController2, the AaiController endpoint of change-management is redundant
Issue-ID: VID-596
Signed-off-by: Amichai Hemli <amichai.hemli@intl.att.com>
Change-Id: I68289eb5acb02af75c052e891dc6f77a48dc62c7
|
|
Change-Id: I4c3de5eeaac8e576b6a52a87dbe3dc148c203edb
Issue-ID: VID-611
Signed-off-by: Ittay Stern <ittay.stern@att.com>
|
|
Issue-ID: VID-637
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Ia9340269dd6a4a6616a6fdbfe166eea0731490de
|