diff options
| author |   Eylon Malin <eylon.malin@intl.att.com> | 2019-08-29 15:55:20 +0300 |
|---|---|---|
| committer | Eylon Malin <eylon.malin@intl.att.com> | 2019-08-29 15:55:20 +0300 |
| commit | 955722b6ddf8ddeab3d1904f5514a5be9226a59f (patch) | |
| tree | ee7da90f66b7bbd8bb89da8ab203e93fbe5408d3 /vid-app-common/src/main/java/org/onap | |
| parent | 44d49cc9257c70ffdf70b9f6c8252792e706c48b (diff) | |
edit of macro services in new view edit screen
Fix Vid Notion Builder behavior according -
all macro non transport services should open the new view edit screen
Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Icd45fcbfcb4bf8928f44f73fb3ddd84ac1f1d341
Diffstat (limited to 'vid-app-common/src/main/java/org/onap')
| -rw-r--r-- | vid-app-common/src/main/java/org/onap/vid/asdc/parser/VidNotionsBuilder.java | 13 | ||||
| -rw-r--r-- | vid-app-common/src/main/java/org/onap/vid/properties/Features.java | 1 |
2 files changed, 7 insertions, 7 deletions
diff --git a/vid-app-common/src/main/java/org/onap/vid/asdc/parser/VidNotionsBuilder.java b/vid-app-common/src/main/java/org/onap/vid/asdc/parser/VidNotionsBuilder.java index c9c2649ae..d35c8df9c 100644 --- a/vid-app-common/src/main/java/org/onap/vid/asdc/parser/VidNotionsBuilder.java +++ b/vid-app-common/src/main/java/org/onap/vid/asdc/parser/VidNotionsBuilder.java @@ -170,16 +170,15 @@ public class VidNotionsBuilder { return VidNotions.InstantiationUI.SERVICE_WITH_VNF_GROUPING; } - if (featureManager.isActive(Features.FLAG_1908_COLLECTION_RESOURCE_NEW_INSTANTIATION_UI) && - featureManager.isActive(Features.FLAG_1908_RESUME_MACRO_SERVICE) && - isServiceWithCollectionResource(serviceModel)) { - return VidNotions.InstantiationUI.SERVICE_WITH_COLLECTION_RESOURCE; + if (featureManager.isActive(Features.FLAG_1908_MACRO_NOT_TRANSPORT_NEW_VIEW_EDIT) && + isMacro(serviceModel) && + !isTransportService(csarHelper) && + //till new view/edit would support fabric service activation + !hasFabricConfiguration(csarHelper)) { + return VidNotions.InstantiationUI.MACRO_SERVICE; } if (featureManager.isActive(Features.FLAG_1902_NEW_VIEW_EDIT)) { - if (isMacro(serviceModel) && !isMacroExcludedFromAsyncFlow(serviceModel)) { - return VidNotions.InstantiationUI.MACRO_SERVICE; - } VidNotions.InstantiationUI instantiationUISuggestion = suggestInstantiationUI(csarHelper, serviceModel); if (instantiationUISuggestion!=VidNotions.InstantiationUI.LEGACY) { return instantiationUISuggestion; diff --git a/vid-app-common/src/main/java/org/onap/vid/properties/Features.java b/vid-app-common/src/main/java/org/onap/vid/properties/Features.java index bc3c6c8ec..f8eaabfda 100644 --- a/vid-app-common/src/main/java/org/onap/vid/properties/Features.java +++ b/vid-app-common/src/main/java/org/onap/vid/properties/Features.java @@ -70,6 +70,7 @@ public enum Features implements Feature { FLAG_1908_RELEASE_TENANT_ISOLATION, FLAG_1908_A_LA_CARTE_VNF_NEW_INSTANTIATION_UI, FLAG_FLASH_REPLACE_VF_MODULE, + FLAG_1908_MACRO_NOT_TRANSPORT_NEW_VIEW_EDIT, FLAG_PNP_INSTANTIATION, FLAG_HANDLE_SO_WORKFLOWS, FLAG_CREATE_ERROR_REPORTS |