Fix sonar issue in vid-app-common

Fix Either log or rethrow this exception
Fix "serviceInstanceId" is already a string, there's no need to call "toString()" on it
Fix Replace this if-then-else statement by a single return statement

Issue-ID: VID-464
Change-Id: I87652f6aeecf668757f668535377f2ff9a95a7cf
Signed-off-by: Parshad Patel <pars.patel@samsung.com>

1 files changed, 1 insertions, 1 deletions

diff --git a/vid-app-common/src/main/java/org/onap/vid/services/RoleGenaratorServiceImpl.java b/vid-app-common/src/main/java/org/onap/vid/services/RoleGenaratorServiceImpl.java
index db40ce23c..790dbfa55 100644
--- a/vid-app-common/src/main/java/org/onap/vid/services/RoleGenaratorServiceImpl.java
+++ b/vid-app-common/src/main/java/org/onap/vid/services/RoleGenaratorServiceImpl.java
@@ -61,7 +61,7 @@ public class RoleGenaratorServiceImpl implements RoleGeneratorService {
 
         }
         catch (Exception e) {
-            Log.error("There was an error in updating roles "+e.getMessage());
+            Log.error("There was an error in updating roles ", e);
         }
         return query;
     }